From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5509FC433FE for ; Thu, 24 Nov 2022 11:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hiQkvUlZGGgQHh9lf6L5cfbW4Bp13mcQwCwYoZfFRAY=; b=00F3A4/xzDoTODG01kisBinSHP YQxpVLVkyRDl/99rCe9UByajJTdcrSt4MtBQojiDgdj9qxEi2F/T7S5FQq8x1OW6UOSFiVJUooTXe DOIKraZPRZtEPNSNYj8gEU1Hu+WbxCUFfyUPUo0uolhL2lwaYYT4LjC6tvDu7t9esxcEAFBjRQJmi VeWAQwNTX8MKy+wf1ihZP2h54cF9Ny+hVV30XjqPwkOqbuD36tlbXIrEGdRaowWln25qZzHYwC8R9 IJ/fH1rgSQ8MWATQJ8+zUo/bc+vf+b+Mki6UvvP7caGARt0XPDSD17CfcuZw5auBRyzCjBCazO8nn 0PhCAw3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyAjs-008Bxy-DQ; Thu, 24 Nov 2022 11:49:56 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyAjo-008Bvj-QL for linux-arm-kernel@lists.infradead.org; Thu, 24 Nov 2022 11:49:54 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id C2B395802A8; Thu, 24 Nov 2022 06:49:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 24 Nov 2022 06:49:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1669290589; x=1669297789; bh=OHFx68nmnn /ceAUAI4qgZcV6iBa2E8isOTaxL9ONytc=; b=HJiPVgLyhrcSJIoI5oHBuPCtif 7TkeOKloNPGFr9G7HpxETWIMqUwKFx7SL0JFIN+tCq7qTefMU73nDb1kgWY9jEvg jju8MAnU/W05uYdGIOo0suZbsbnlpf6AARruwbjhh7i0zHTNROi8w9fsLR+/J+uI f2k5Yn79Z5tPdt/6/Tx5DUQUAY3F5CNLACZt2EWIfOpA2BxKKAkED9sTiNGG8t9j Ox5M/iBawaCECjHYxKQvyUSfQyE/k6FerKXCxUwZkCogrOqHhSOaKWZH4RLP+9tU K9c2QGBt55ntYGJaWExIy1fpWtiPMjl7R3S+X29r22VUVBPgRlMssonXNFcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669290589; x=1669297789; bh=OHFx68nmnn/ceAUAI4qgZcV6iBa2 E8isOTaxL9ONytc=; b=J0uwUwXhLVqUyKTozkwlimGquvlzDQkdPFAmgu6P/Gva zBEet87p11qgTrBX3XIePgLUa6o0iKWmbAijtdFm3m6jX3sFI2A+XANbsS1ziNUc lB1dYIjGgsVTV4IIPiOiEDdo72Kist/8YrNKcpBaW+cALs27xmBxozD8SL6UYZNs +PSczmcvdsS5ZGV6QwesmFhMwp3QdWmxb1SNwavWw6LKO74i71QmKgTebKxG2UrZ bivRxY+dD9UYez5vVu3mFzjEzKc3lHRmhR9f9T8XucrUoG0/WclxpqyBYZIRslpn HvOE5Y2B8QvhuF7QywZXFyxGQuKjkQUdc6NGRTprMg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieefgdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Nov 2022 06:49:47 -0500 (EST) Date: Thu, 24 Nov 2022 12:49:45 +0100 From: Maxime Ripard To: Samuel Holland , Jernej Skrabec , Maarten Lankhorst , Rodrigo Vivi , Joonas Lahtinen , Ben Skeggs , Chen-Yu Tsai , David Airlie , Jani Nikula , Tvrtko Ursulin , Emma Anholt , Karol Herbst , Lyude Paul , Thomas Zimmermann , Dave Stevenson , Hans de Goede , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org, Mateusz Kwiatkowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Dom Cobley , Phil Elwell , Geert Uytterhoeven Subject: Re: [PATCH v10 00/19] drm: Analog TV Improvements Message-ID: <20221124114945.oqilsc7zjth4jwso@houat> References: <20220728-rpi-analog-tv-properties-v10-0-256dad125326@cerno.tech> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221124_034953_540346_87886B78 X-CRM114-Status: GOOD ( 34.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5937384618128213827==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5937384618128213827== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="apvrjccnplb3u7fu" Content-Disposition: inline --apvrjccnplb3u7fu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 21, 2022 at 03:51:26PM +0100, Daniel Vetter wrote: > On Thu, Nov 17, 2022 at 10:28:43AM +0100, Maxime Ripard wrote: > > Hi, > >=20 > > Here's a series aiming at improving the command line named modes suppor= t, > > and more importantly how we deal with all the analog TV variants. > >=20 > > The named modes support were initially introduced to allow to specify t= he > > analog TV mode to be used. > >=20 > > However, this was causing multiple issues: > >=20 > > * The mode name parsed on the command line was passed directly to the > > driver, which had to figure out which mode it was suppose to match; > >=20 > > * Figuring that out wasn't really easy, since the video=3D argument o= r what > > the userspace might not even have a name in the first place, but > > instead could have passed a mode with the same timings; > >=20 > > * The fallback to matching on the timings was mostly working as long = as > > we were supporting one 525 lines (most likely NSTC) and one 625 lin= es > > (PAL), but couldn't differentiate between two modes with the same > > timings (NTSC vs PAL-M vs NSTC-J for example); > >=20 > > * There was also some overlap with the tv mode property registered by > > drm_mode_create_tv_properties(), but named modes weren't interacting > > with that property at all. > >=20 > > * Even though that property was generic, its possible values were > > specific to each drivers, which made some generic support difficult. > >=20 > > Thus, I chose to tackle in multiple steps: > >=20 > > * A new TV mode property was introduced, with generic values, each dr= iver > > reporting through a bitmask what standard it supports to the usersp= ace; > >=20 > > * This option was added to the command line parsing code to be able to > > specify it on the kernel command line, and new atomic_check and res= et > > helpers were created to integrate properly into atomic KMS; > >=20 > > * The named mode parsing code is now creating a proper display mode f= or > > the given named mode, and the TV standard will thus be part of the > > connector state; > >=20 > > * Two drivers were converted and tested for now (vc4 and sun4i), with > > some backward compatibility code to translate the old TV mode to the > > new TV mode; > >=20 > > Unit tests were created along the way. > >=20 > > One can switch from NTSC to PAL now using (on vc4) > >=20 > > modetest -M vc4 -s 53:720x480i -w 53:'TV mode':1 # NTSC > > modetest -M vc4 -s 53:720x576i -w 53:'TV mode':4 # PAL > >=20 > > Let me know what you think, > > Maxime >=20 > Maxime asked me to drop an Ack-in-principle on this, and I'm not sure I > have any useful input here with my utter lack of understanding for TV > things (I never even had one in my entire life, that's how much I don't > care). But it seems to check all the design boxes around solving annoying > uapi/kms-config issues properly, so >=20 > Acked-in-principle-or-something-like-that-by: Daniel Vetter Thanks! I jumped the gun a bit too fast and forgot to amend the TV property commit message before pushing it out. For the record though, that property is usable through xrandr, xorg.conf or any equivalent compositor mechanism Maxime --apvrjccnplb3u7fu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY39aWQAKCRDj7w1vZxhR xacgAP9NPkwQFyz0CvvFS5SzvELVnj6t9GBuTq/qrHpTLaRyaAD9GJpLyjLeg7Jy Z0pnBngL2vXGtvYVUCMQy5VhVkMtuAg= =fhxt -----END PGP SIGNATURE----- --apvrjccnplb3u7fu-- --===============5937384618128213827== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5937384618128213827==--