From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73407C433FE for ; Thu, 24 Nov 2022 14:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h0B7QRTZWsAMIMXxdrmhXhUiut5Y4ihQUddC5tOi/i8=; b=jIxYu8NoKyBn9I ZEorNBXN2+A9qhlcHYVWOIW7khXuZ24o+LC893M2BJY1jT315m4sc07x+3E0BAodXGskvne41do+C B+cJ+gU1NGx8y+sVRBKFqwgso6qmOmyzYo4YmwGvs7DTGAU/86T9lsUfDp6koYupAvZQh9JuVuG9m zvPv/ZxNbBD63s9Nxcgxvmr0WhzUWUy3jZri3svK0nauuO2yfcQpr3O7O/SVpDDx/ksmu8CcLmzGN CCVJxAd+gwCiQU9Q9lDLGanBbmxYPL9gM8YGpDv0OYm0AO0KjenhYLMKfP9rbpvIHYxYVD3m3ZYxZ qgyXEqalzf/tIewBSCZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyDgK-009Vp0-TI; Thu, 24 Nov 2022 14:58:29 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyDgH-009Vj7-9S for linux-arm-kernel@lists.infradead.org; Thu, 24 Nov 2022 14:58:27 +0000 Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 245BBFF808; Thu, 24 Nov 2022 14:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669301899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R0aMYsPot2Cc7oq/Rax295Xkb9Vir2RNZBvjjC86qDQ=; b=RkQyHRUIq3cVAh2+AjZw3WMevLFXThJ7Tr/U63jUkglsa9tuz8M9ci/BsWcqxuallO+zEx Kk93ln2Ua86pPD+BP+bxzjynSqb3cwt96/ksNj4HA15O+r00QG5+A9QEAn3IiQMmGKGFGN gIBZ4Rrdr9mIOhCVZG/WwRdRgHXGzWSblbvk4+hsvIz44/uSi4FNyYqQ6KXUQnzp8qLiNG qZ29U9qBVqdJ5AOPApWqR1DB1IdlvuYjVQWfJd+BfVYWsrcAa+Sp31ndRD7nCCbMlsGyEU JQvN5BxcH2sO6plOXPi4ktfinr11BPTE9tuMcqNeQcTcgROB+bpKGLq4u7FLiw== Date: Thu, 24 Nov 2022 15:58:17 +0100 From: Thomas Petazzoni To: Vadym Kochan Cc: Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Krzysztof Kozlowski , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Elad Nachman , Raz Adashi , Yuval Shaia Subject: Re: [PATCH v2 2/3] PCI: armada8k: Add AC5 SoC support Message-ID: <20221124155817.5f372417@windsurf> In-Reply-To: <20221124135829.2551873-3-vadym.kochan@plvision.eu> References: <20221124135829.2551873-1-vadym.kochan@plvision.eu> <20221124135829.2551873-3-vadym.kochan@plvision.eu> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221124_065825_517157_98C87A11 X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Thu, 24 Nov 2022 15:58:27 +0200 Vadym Kochan wrote: > -static int armada8k_pcie_start_link(struct dw_pcie *pci) > -{ > - u32 reg; > - > - /* Start LTSSM */ > - reg = dw_pcie_readl_dbi(pci, PCIE_GLOBAL_CONTROL_REG); > - reg |= PCIE_APP_LTSSM_EN; > - dw_pcie_writel_dbi(pci, PCIE_GLOBAL_CONTROL_REG, reg); > - > - return 0; > -} So this code is going away, but I don't see it being re-added anywhere. I don't think anything in the code you are adding that sets the LTSSM_EN bit in PCIE_GLOBAL_CONTROL_REG. Am I missing something? Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel