From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E7A1C4332F for ; Fri, 25 Nov 2022 15:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5LCAmuVjl3fyW8tKG/CfCEiwx8zGwZd7k9xcP7kxeXk=; b=rGtYwdSfzxDDeo hKPQvWTg4w/4xuIyTydc5qLN4CD5GcFENx5FDygqQriQ69aSnxRwW0mUghx9aRGQgWAMJoa8eBEYw WCbdKlI+lNSIX0Vq3wZ+KM9qb5m+B8yz91q16YKj3/hESJUe+u4vLVtyCtwLK3MXTxs39UT6gsbHZ aTpTM/sakaJswAB9cwVEbKvrdpRI5/t+8gg7grtZwsnuMmbn1Wgy9eLopyPzFblEvLIQdsJsYpn45 I9DMH9VaGNpGvOF1fCDQJQT9CWT0XfowiRNOFj9lSY3pqu0OY8xJerXkp8o0XG9lMJI/9tKBF3S3w vnijZcXEBK5shAZIvCTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyaz9-0002H8-HP; Fri, 25 Nov 2022 15:51:27 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyaz5-00027q-1z for linux-arm-kernel@lists.infradead.org; Fri, 25 Nov 2022 15:51:25 +0000 Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id A50931BF203; Fri, 25 Nov 2022 15:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669391472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GPaT39sAq6bB/8jycs8Qu4XNOLXdQXN9CIa8CNq+0DU=; b=d/iWI35QnhWrUQmu3eK7MTp+CL19nh+Yxmv+C3PgagomoCjafmL46X4+idl8P6GeM7d7W/ IuyPuItiyYGPs6TsLADAGD0fSGx6to8UDVu3P9UK3lyMkSj/644Y+Y5bjxkZyDmYKd2Qga DUF4/VbHFuiaCTiZ0UHRpzPT1DjliCWV4/upp90Fv1szfz/rUHVVRGz1w5qZJuqmV8DlmS cNOkK0+d9366JLreDe2UDAfAZ62wxQCkvsA9I3ZhrdFmqD0kW5jtdEEkWlnU2CmcNCVjUK Fkf7YKCimzEimQEb0AaOSeczhQyCpHoJCRmyNQeq1OscLIz4gU7xdWoeIXLmHA== Date: Fri, 25 Nov 2022 16:51:09 +0100 From: Thomas Petazzoni To: Vadym Kochan Cc: Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Krzysztof Kozlowski , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Elad Nachman , Raz Adashi , Yuval Shaia Subject: Re: [PATCH v2 2/3] PCI: armada8k: Add AC5 SoC support Message-ID: <20221125165109.6059d3a5@windsurf> In-Reply-To: References: <20221124135829.2551873-1-vadym.kochan@plvision.eu> <20221124135829.2551873-3-vadym.kochan@plvision.eu> <20221124155817.5f372417@windsurf> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221125_075123_394722_90F8755F X-CRM114-Status: GOOD ( 11.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! On Fri, 25 Nov 2022 08:43:06 +0000 Vadym Kochan wrote: > [quote] > this is not needed, as by the time Linux is loaded, link has already been established (by boot loaders) > > So this code is not needed. > [/quote] Not ideal to rely on the bootloader for this sort of initialization, and if we want to do this change, perhaps it should be done in another patch. But again, the fact that "it works for Marvell because their vendor U-Boot does the right thing prior to loading Linux" is not really a very solid argument to drop kernel code :-/ Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel