From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF3CFC43217 for ; Sun, 27 Nov 2022 18:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v9Ug/0TY82xvhDQvon7ZZX4HAAsLqd4/7N0hC39qIaI=; b=olE1hjZm+KisZW bltJ/9PdNjR0/8zrkFidghhvAxyh4CTsG5twSNQukd7YT/U8k5cd2VOnP6YQKQZt+dnh6QpWga3OZ DS9/nBz92zmzkYtHfi8KGC8mQnhUEyQIkRBNrL2DyatSVNb4xRfDkTl4b0wm4EicjFIee9zjo0EZb qw/LZ7lNkS73AszIj8F9tBFIFqwVOvIf03McmYq6WFJlOsWzp/tryyg521tZz0RoKjGe8Aq0NRzqD 3TaAEtgO48CCkgpN4tjxvXJHiICXEHD4mOzpQGfN8wAqCLM9xPzADJ7KeiA7EhFI7WtCzaey5e4m1 dKm5gPJ/+g2RBIvwOyBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozMIa-00Cw1A-VJ; Sun, 27 Nov 2022 18:22:41 +0000 Received: from mail-io1-f46.google.com ([209.85.166.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozMIY-00CvzQ-Gn for linux-arm-kernel@lists.infradead.org; Sun, 27 Nov 2022 18:22:40 +0000 Received: by mail-io1-f46.google.com with SMTP id h206so6200100iof.10 for ; Sun, 27 Nov 2022 10:22:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vukWGyYF9LYnWEtUXZi++E5sJfGRcnavjJ89dxRwcfA=; b=6Dyo5wHq5Jt2wJrZyr2c4mOaMtvS7gti6nCTbPAASPAGRm8QL+QSwsGSBDsxxL5k4K 5xiRpioJTXjo+v5heZn6SedrWBKNUQpPrL3Gsi/BkaZ9+JVHHPOOY6niuOd9cmnqNHjQ Y7eMM+JB1H9TYNZcU9dH96JXRtQ1T8Hwbs9ISiFoObQytsNQI/N5xjYuld2w6M9wH6DA ktAFPV0R9HEivFwEowpKV0pKzp619d0GXMYRwp3hUNUDFMDWjd8SwPCqCSf7ub1jxgs8 8IpEw+0hp5SYFWVHRL8l//eMDTk5s7Ux17VMui38aaUxWQS1BkrMx2MrVnQcTpmrDUtM OY6w== X-Gm-Message-State: ANoB5pkrNaWsyYeskSWzgm8WyY+a2UalVoAAwha75iXoGI+fSgIYo4Mw 53fMPUeCAHwiMsBbchjjoQ== X-Google-Smtp-Source: AA0mqf52id4ogOIrUkQbo6wDm6Jj1UbJySa/csflYIxoWGpZdD7lafsWa0xqORF+oFNfTceNY8Asbg== X-Received: by 2002:a02:9547:0:b0:375:3dd1:743c with SMTP id y65-20020a029547000000b003753dd1743cmr14810797jah.281.1669573353061; Sun, 27 Nov 2022 10:22:33 -0800 (PST) Received: from robh_at_kernel.org ([2605:ef80:80c1:3b80:81db:640f:ef27:c9e2]) by smtp.gmail.com with ESMTPSA id u13-20020a056638304d00b00372bbd04b75sm3611473jak.87.2022.11.27.10.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Nov 2022 10:22:32 -0800 (PST) Received: (nullmailer pid 144847 invoked by uid 1000); Sun, 27 Nov 2022 18:22:32 -0000 Date: Sun, 27 Nov 2022 12:22:32 -0600 From: Rob Herring To: Tony Lindgren Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-pwm@vger.kernel.org, Thierry Reding , Krzysztof Kozlowski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format Message-ID: <20221127182232.GA128974-robh@kernel.org> References: <20221122123225.59106-1-tony@atomide.com> <20221123024153.GB1026269-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221127_102238_582328_79951B01 X-CRM114-Status: GOOD ( 30.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 23, 2022 at 08:58:54AM +0200, Tony Lindgren wrote: > * Rob Herring [221123 02:31]: > > On Tue, Nov 22, 2022 at 02:32:24PM +0200, Tony Lindgren wrote: > > > Let's allow node numbering in decimal format too. > > > = > > > Simple human-readable increments/IDs are usually decimal, hex is only= for > > > addresses as noted by Krzysztof Kozlowski . > > > = > > > Let's use an improved match suggested by Krzysztof Kozlowski > > > and improved a bit by Uwe Kleine-K= =F6nig > > > . > > > = > > > Cc: linux-pwm@vger.kernel.org > > > Cc: Thierry Reding > > > Suggested-by: Krzysztof Kozlowski > > > Suggested-by: Uwe Kleine-K=F6nig > > > Signed-off-by: Tony Lindgren > > > --- > > > = > > > Changes since v2: > > > = > > > - Use pattern suggested by Krzysztof and Uwe > > > = > > > Changes since v1: > > > = > > > - New patch added to deal with pwm-omap-dmtimer binding > > > = > > > --- > > > Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > = > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documen= tation/devicetree/bindings/pwm/pwm.yaml > > > --- a/Documentation/devicetree/bindings/pwm/pwm.yaml > > > +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml > > > @@ -13,7 +13,7 @@ select: false > > > = > > > properties: > > > $nodename: > > > - pattern: "^pwm(@.*|-[0-9a-f])*$" > > > + pattern: "^pwm(@.+|-[0-9a-f]+)?$" > > = > > So now pwm-10 could be either? > = > Yes. > = > > I'm fine with decimal, but can we do that everywhere we do this -N = > > naming? > = > Do you mean the '[0-9a-f]' users that don't use '[0-9af]+'? No, I mean for all cases of -N, can be we consistent. Either = we use hex or we use decimal. = > = > These can be found with: > = > $ find Documentation/devicetree/bindings/ -name \*.yaml | \ > xargs grep pattern: | grep '\[0-9a-f\]' | grep -v '\[0-9a-f\]+' Not quite. It's just cases of '-N': $ find Documentation/devicetree/bindings/ -name \*.yaml | xargs gre= p pattern: | grep '\-\[0-9a-f\]' | grep -v '\[0-9a-f\]+' Documentation/devicetree/bindings/phy/intel,combo-phy.yaml: pattern: "co= mbophy(@.*|-[0-9a-f])*$" Documentation/devicetree/bindings/pwm/pwm.yaml: pattern: "^pwm(@.*|-[0-9= a-f])*$" Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml= : pattern: "^timestamp(@.*|-[0-9a-f])?$" Documentation/devicetree/bindings/watchdog/watchdog.yaml: pattern: "^wat= chdog(@.*|-[0-9a-f])?$" Documentation/devicetree/bindings/spi/spi-controller.yaml: pattern: "^sp= i(@.*|-[0-9a-f])*$" Documentation/devicetree/bindings/rtc/rtc.yaml: pattern: "^rtc(@.*|-[0-9= a-f])*$" And there's probably some more in dtschema. > = > Not sure if some of these need to intentionally limit the node numbering > to 15. No, I think it was all just cases of 15 should be enough for anyone. > = > If you have some other criteria in mind, let me know :) If the numbering is hex, then it is as you have it. (Though we can't = enforce that. If it is decimal, then the regex should be ([0-9]|[1-9][0-9]+). = Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel