From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EA30C433FE for ; Wed, 30 Nov 2022 04:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AJ/JSPlS89nul4bMOqNSCVAbD3g0Xdh6xRVzoCkjGcs=; b=Pue9X8lSZJ4UPY 3CKL2+E5cyDU7jB08IiSC2nb2iiZw1w+88eDvOdq1zWk2upopulm25fxle/lXgs5Wwu3MaVlCNnJa jctgviP2f3aIaPdDf+F2JX3jBfbmjVV+gJaSaIKQzuIt4oj+9GvC85uXcA8C9omKcluDJZhhVQ12O N2SA+NEM0a6RUdSMPIjepsveabfnAj91nq3LhN2TnEO8Rn0A3F9QHh06I9Zqkx3UAIPuoycRekNR9 8DUbHH1VUjnTZHZ9+0fMakxaLTYWa2Csav/PnDtzo2xfApfypkw7yzzQv4Oadc2ueF2ygyBVU5r3q 6au425sBH8pveCpfEgiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0EpE-00D1uS-GD; Wed, 30 Nov 2022 04:36:00 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0EpB-00D1r6-3U for linux-arm-kernel@lists.infradead.org; Wed, 30 Nov 2022 04:35:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6E492B81A22; Wed, 30 Nov 2022 04:35:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86811C433C1; Wed, 30 Nov 2022 04:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669782953; bh=x8nbYm06jHz/XeCUDHAODP1xl6lP6WKv6YN0M3Vc+bI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QurYTJW3SxARDl3Sw3bY+lt1m11cmqLXqH3qRoqI6xwtr2l7eBFxuC9haYFh4YL/N ODoWVt9XUI4vr0VpDTyqdbAUGDlCZB6SGW6P3vi2JisG/zL0vqz5PSWXP8a+wrufsV bzHjdFlr4arTwrPCk/SU/O59rd4VWSi119N6EtmpckCJoxc5Yv4x5qxS0hbA6dt2Z+ torc21Va69+/WhGqR/D7b18bbQrrANGFTa6VDSdO2riEQsWcgYWUzbPBadrTttHomB 5lBQ3XNzZmoEgZnPXoNVZNebr/xyzjZeFQjhf94gnhvbveP68ZnyocnQSRPBrMiIvm wq9Ap9pbr0lxQ== Date: Tue, 29 Nov 2022 20:35:51 -0800 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH net-next 1/3] net: pcs: altera-tse: use read_poll_timeout to wait for reset Message-ID: <20221129203551.170d93e1@kernel.org> In-Reply-To: <20221125131801.64234-2-maxime.chevallier@bootlin.com> References: <20221125131801.64234-1-maxime.chevallier@bootlin.com> <20221125131801.64234-2-maxime.chevallier@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221129_203557_366684_452808D5 X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 25 Nov 2022 14:17:59 +0100 Maxime Chevallier wrote: > - for (i = 0; i < SGMII_PCS_SW_RESET_TIMEOUT; i++) { > - if (!(tse_pcs_read(tse_pcs, MII_BMCR) & BMCR_RESET)) > - return 0; > - udelay(1); > - } > - > - return -ETIMEDOUT; > + return read_poll_timeout(tse_pcs_read, bmcr, (bmcr & BMCR_RESET), > + 10, SGMII_PCS_SW_RESET_TIMEOUT, 1, > + tse_pcs, MII_BMCR); You say "no functional change intended" in the cover letter but you switch from udelay to usleep and change timeouts here. I presume this is intentional but should be mentioned in the commit message, I think. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel