From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B8E2C4332F for ; Thu, 1 Dec 2022 23:49:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B8MzlssIRWcAARUvwEsMsxVTAW0mej4IrIBU0B1FXDE=; b=0PEgOBm16uE9Wr BATsnyxLjnzRIWHC/EpV3bXrdC/F7fYHt+q1trKreqsvud4JqvQeUrMp/yK31GacOzBpo0LHJqxTz UL9glWGgcGwqBTe4l+6VU1AiMQks9PBgytEOkhQgnpreD5Bmh+cxUKTmU3/dYzzyeLN9JpKUijoj3 C1VxTgqMnVEZQ4A30S4J0sWz+TSP8fp0EUdianva3ky6cERIozOCB/rKgB4rJFFPUgcK+Ktu+usqy 3hIcdZftA/YptGGJgbL/laypeeL8qP2xouyz1tg6UH/J/FNBidQxJ5b7n1qPkyRGHn4CGXpfjMJeQ i+KKcJOMN3GEwNsgC2AA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0tHz-00BqR3-37; Thu, 01 Dec 2022 23:48:23 +0000 Received: from mail-oa1-f50.google.com ([209.85.160.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0stU-00BdzG-U2 for linux-arm-kernel@lists.infradead.org; Thu, 01 Dec 2022 23:23:06 +0000 Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-1432a5f6468so3889638fac.12 for ; Thu, 01 Dec 2022 15:23:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nWHREg3K9q2Uq2ob8YkTAtl0cbLjNrJW4Aev5O+DjTk=; b=GsrxUqp5IXlsr2eu0nWTEVRUgaAjMGqV0bZL/j/hBWW6eET7qYJz6EzrSVc8uhZEeN 3s1NvSSSYU3VavT1cqPGADg4uBen+HMz+7X0MWP3sN7xkDzkRz/x5CP8UD+aLBtm+NIE y/6tS8UkV5V3UgJhw3b3kNWv2yfvuE+1tjQQ2lzqf8hrLIeletxz3+yrTt7FCs4azm4j y1UGAdPinYRJqeByLd64hxp5XyixY4pa7+DAPzaBUBDV68vJSsNJJvRA3odMPqrA05FH QyI7S5+NRYbAAZmQnWiXs0cbOwXAJn676eMZNuk2TKloUUecVfbn190qIm/hQvYoTLaN YwpQ== X-Gm-Message-State: ANoB5pkykrZ2HoUJAtWD06mhJ4zALc3/p+SVIFX+esn6EbFb+rP8lk8B eljcZzOB3vnDp0HVyyptcg== X-Google-Smtp-Source: AA0mqf7DmRJSFtG8dcbg49pfVMbnv1yJ+mEa1tNolTW9KSHVjM4y2+6Ho9iGfbmZXERvKMU+zCeNLQ== X-Received: by 2002:a05:6870:d7a5:b0:142:80e3:1dbd with SMTP id bd37-20020a056870d7a500b0014280e31dbdmr39257160oab.253.1669936981101; Thu, 01 Dec 2022 15:23:01 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id ay19-20020a056808301300b00354b0850fb6sm2381703oib.33.2022.12.01.15.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 15:23:00 -0800 (PST) Received: (nullmailer pid 1671892 invoked by uid 1000); Thu, 01 Dec 2022 23:22:59 -0000 Date: Thu, 1 Dec 2022 17:22:59 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Chukun Pan , "David S . Miller" , Krzysztof Kozlowski , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Wu , Krzysztof Kozlowski , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rk3568 xpcs compatible Message-ID: <20221201232259.GA1668339-robh@kernel.org> References: <20221129072714.22880-1-amadeus@jmu.edu.cn> <4692527.5fSG56mABF@diego> <8eb78282-08c2-24bf-4049-5c610dd781fc@linaro.org> <3689593.Mh6RI2rZIc@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3689593.Mh6RI2rZIc@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_152305_014632_FA9C6774 X-CRM114-Status: GOOD ( 24.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 29, 2022 at 11:22:28AM +0100, Heiko St=FCbner wrote: > Am Dienstag, 29. November 2022, 10:59:34 CET schrieb Krzysztof Kozlowski: > > On 29/11/2022 10:56, Heiko St=FCbner wrote: > > > Am Dienstag, 29. November 2022, 09:49:08 CET schrieb Krzysztof Kozlow= ski: > > >> On 29/11/2022 08:27, Chukun Pan wrote: > > >>> The gmac of RK3568 supports RGMII/SGMII/QSGMII interface. > > >>> This patch adds a compatible string for the required clock. > > >>> > > >>> Signed-off-by: Chukun Pan > > >>> --- > > >>> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++= ++ > > >>> 1 file changed, 6 insertions(+) > > >>> > > >>> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.y= aml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > >>> index 42fb72b6909d..36b1e82212e7 100644 > > >>> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > >>> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > >>> @@ -68,6 +68,7 @@ properties: > > >>> - mac_clk_rx > > >>> - aclk_mac > > >>> - pclk_mac > > >>> + - pclk_xpcs > > >>> - clk_mac_ref > > >>> - clk_mac_refout > > >>> - clk_mac_speed > > >>> @@ -90,6 +91,11 @@ properties: > > >>> The phandle of the syscon node for the peripheral general re= gister file. > > >>> $ref: /schemas/types.yaml#/definitions/phandle > > >>> = > > >>> + rockchip,xpcs: > > >>> + description: > > >>> + The phandle of the syscon node for the peripheral general re= gister file. > > >> > > >> You used the same description as above, so no, you cannot have two > > >> properties which are the same. syscons for GRF are called > > >> "rockchip,grf", aren't they? > > > = > > > Not necessarily :-) . > > = > > OK, then description should have something like "...GRF for foo bar". > = > Actually looking deeper in the TRM, having these registers "just" written > to from the dwmac-glue-layer feels quite a bit like a hack. > = > The "pcs" thingy referenced in patch2 actually looks more like a real dev= ice > with its own section in the TRM and own iomem area. This pcs device then > itself has some more settings stored in said pipe-grf. > = > So this looks more like it wants to be an actual phy-driver. There's a PCS binding now. Seems like it should be used if there is = also a PHY already. PCS may be part of the PHY or separate block AIUI. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel