From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F5B4C4332F for ; Fri, 2 Dec 2022 22:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: Date:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=qJNokMBArqXdl4vEGrNPXPDyQYEe4fdwgaC4OWlEBs4=; b=q6TcPdk27/6xSt 5lH9YVZqXwao85zZHKEBKD+EiOW/Qcwv44Md+YWO7CYVa+cKuX9Z0RRj+ej/TVS1TfcWjcCFt8T3j ldJamSIrDLjGzVtBUgTir//da3rRr/Jqnt3OwnRcsNyLlM6LjBmsfxcgZCiCjmndPCLpIv50L4qJG iZn/nxvjY/Mw9Fr1hORRlCdGJ5pHunnPm+fmJIMWTJjboxe4yaA4zHVwRY6PNrmZ2fOPlcmQMw13a ShEtlgJyhMqTOyhKOX/ItpJYag2md4MEsJMq3AGsQnuPLryBRFU8Hk/ZPpia5Fvdhm0BJtsX5UzMk WSEGyryJhAnIis4yaG6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p1EVo-001WQM-PH; Fri, 02 Dec 2022 22:28:04 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p1EVl-001WOe-C1 for linux-arm-kernel@lists.infradead.org; Fri, 02 Dec 2022 22:28:02 +0000 Received: by mail-pl1-x636.google.com with SMTP id 4so5928592pli.0 for ; Fri, 02 Dec 2022 14:27:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=ALZWGLHwa13YfXZGkxW0FB63ANWeHG5fPT+X9QnIXNE=; b=X3/Ygkl9QthpO86CXg54X6whNZrFQqYUC0a1gJ7z1caR4J8jEDl6DfVlTLaBNivhcY NiphJrlOXZlUsJ+SpV9Zi/OaCqZQmF+w8BKtnwGuplrgBPudjQNAGaFRELzlURBACYjN fvskVx3RWz/t+JrUbcEZFBXzzW/hbUS1lG/vc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ALZWGLHwa13YfXZGkxW0FB63ANWeHG5fPT+X9QnIXNE=; b=x6sqBSOfW/eifJi9+fVkTo7NJFcsVhC5aCr2nusxY8Ex1mN9fnVKBa+x6iDcsKxi8C h3O+5AV5wLLrKxYHdbTJVm8ghc53RRjVJ2V85lRwyyvfpoFVrSB1jo+z4w9i2gAJ7qTB efQYOKpjusvsNjPt/7AGwFjkHomNbDoKxT6zQ6W+wbmmXcOm+oIpGjK+/WmM8/TahCTH CrYKIr+SEumlr+89hCtDI/K1WlGxMtNUjjnehLUb0Mvc+KjqzoG8F2yFITp5sJwXjANx oAsw+JG6mO7IeVkZsWYTUo979IRi/FAszw7tNRcXnRsczuZmElr+bBrDaLIbrGPmxeEH 1CFg== X-Gm-Message-State: ANoB5pkg2psSmRccZVYEOD4A+Ao2HVzUL/70rObPPIg8VmIqcz4STvUa PAj6lWT0isofNCRbq2E7ArkRFQ== X-Google-Smtp-Source: AA0mqf5jLuXI/3izYGoUxy610VM/+FmgD12XJpKjAnMQ9yTLUWnTyNdgZ4kJJE+Exwk0YwLhcYT/sQ== X-Received: by 2002:a17:90b:3608:b0:219:6b1b:63d8 with SMTP id ml8-20020a17090b360800b002196b1b63d8mr14207707pjb.143.1670020078378; Fri, 02 Dec 2022 14:27:58 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x22-20020a170902821600b00189ac5a2340sm5734186pln.124.2022.12.02.14.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 14:27:57 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Fri, 2 Dec 2022 14:27:57 -0800 To: Shayne Chen Cc: Lorenzo Bianconi , linux-wireless@vger.kernel.org, Jakub Kicinski , Kalle Valo , StanleyYP Wang , Matthias Brugger , Peter Chiu , Eric Dumazet , Money Wang , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Howard Hsu , linux-mediatek@lists.infradead.org, Felix Fietkau , "David S. Miller" , Evelyn Tsai , linux-kernel@vger.kernel.org, MeiChia Chiu , Paolo Abeni , Sean Wang , Bo Jiao , Ryder Lee , Sujuan Chen , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: mt7996_mcu_ie_countdown(): Insecure data handling Message-ID: <202212021427.3A86EE0@keescook> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_142801_462027_B798AF5B X-CRM114-Status: UNSURE ( 8.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221202 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Thu Dec 1 17:29:14 2022 +0100 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices") Coverity reported the following: *** CID 1527797: Insecure data handling (TAINTED_SCALAR) drivers/net/wireless/mediatek/mt76/mt7996/mcu.c:415 in mt7996_mcu_ie_countdown() 409 struct mt76_phy *mphy = &dev->mt76.phy; 410 struct mt7996_mcu_rxd *rxd = (struct mt7996_mcu_rxd *)skb->data; 411 const char *data = (char *)&rxd[1], *tail; 412 struct header *hdr = (struct header *)data; 413 struct tlv *tlv = (struct tlv *)(data + 4); 414 vvv CID 1527797: Insecure data handling (TAINTED_SCALAR) vvv Using tainted variable "hdr->band" as an index into an array "(*dev).mt76.phys". 415 if (hdr->band && dev->mt76.phys[hdr->band]) 416 mphy = dev->mt76.phys[hdr->band]; 417 418 tail = skb->data + le16_to_cpu(rxd->len); 419 while (data + sizeof(struct tlv) < tail && le16_to_cpu(tlv->len)) { 420 switch (le16_to_cpu(tlv->tag)) { If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1527797 ("Insecure data handling") Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices") Thanks for your attention! -- Coverity-bot _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel