From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 386C2C352A1 for ; Sat, 3 Dec 2022 05:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vfCjDdwzKCfZBSRWHEdRvnSazQUDKozj/ic1pnjhIjc=; b=eKzsfdYOiGYPIb hVCt0726X6y9UNw04WmiQ0ObmLswiE+xV8SlAil3YtvP3x+1HdKPBVuASMLi2HHcUTGrBlBoNulVO f/jkWKxp7QTqp47oBVi+rkw05Nqw1E/4skGZiMZ1ZaN66iF7aKa5gQmS3IlkwIcz4v7mpLTTjJ4ex VVvQ42Gfc2+fy+RcxZPE4uiNu6bN6YdTdmufLX1hL5C45wf3o2tKPhZ0h8nhuF17jkHw/laW5ZkRB YvklIxXtP8m2Ut6y0oG62zj2MEWWjhKpm5uGQtBXZe2xG+yssSizFEvQpxQTOZPkEP7/if0LY/lPl +6p5Y+lj9EaIKzuP+tKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p1KcK-002SAF-RO; Sat, 03 Dec 2022 04:59:12 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p1KcI-002S9d-J0 for linux-arm-kernel@lists.infradead.org; Sat, 03 Dec 2022 04:59:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EAA6B60ABB; Sat, 3 Dec 2022 04:59:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D542BC433D6; Sat, 3 Dec 2022 04:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670043549; bh=WLqBpD/hSijALuUZgakx2ku24eQYSRBUVggDObxBitk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TzK10HAu0CIj719qjw8PCN2xzDB73wBFHbXEp/E3lMahLs81IOyNEOfrbIimej+BM QuwIlkQ/V8h9ZaUnCmsPpcXkubbgeRK0Ng60VRClOtHROKE4XcGKMDMzBPFMrlF3k/ 3oa59IA8W22yfIFAspjpqTyqyIFvLRPLPTFZ91QI4YZmaaoIzhMZJUTX3k2mAND1wf +APOJYi7+pvaqPZcMM0BZWE2cJX0UbcJ34wH66XgzjaWUy0p92D1UEZdAHP9zajGHA Q0uWzb47lNPN8R54wz52EgV5/SfoCqoLLvfgaNaMAUeRr+xpb3SFwY9MQcvEg9KgIn aRF9eGyfsdsrg== Date: Fri, 2 Dec 2022 20:59:07 -0800 From: Jakub Kicinski To: Qiheng Lin Cc: , , , , , , , , , Subject: Re: [PATCH] net: microchip: sparx5: Fix missing destroy_workqueue of mact_queue Message-ID: <20221202205907.39eabc1c@kernel.org> In-Reply-To: <20221201134717.25750-1-linqiheng@huawei.com> References: <20221201134717.25750-1-linqiheng@huawei.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_205910_692974_B37B9A7D X-CRM114-Status: UNSURE ( 8.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 1 Dec 2022 21:47:17 +0800 Qiheng Lin wrote: > The mchp_sparx5_probe() won't destroy workqueue created by > create_singlethread_workqueue() in sparx5_start() when later > inits failed. Add destroy_workqueue in the cleanup_ports case, > also add it in mchp_sparx5_remove() This is a fix so it needs a Fixes tag. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel