From: Andre Przywara <andre.przywara@arm.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] pwm: sun4i: Propagate errors in .get_state() to the caller
Date: Fri, 2 Dec 2022 23:37:38 +0000 [thread overview]
Message-ID: <20221202233738.281329b1@slackpad.lan> (raw)
In-Reply-To: <20221201154822.mx7jafj3tyxes5ab@pengutronix.de>
On Thu, 1 Dec 2022 16:48:22 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> On Thu, Dec 01, 2022 at 03:22:23PM +0000, Andre Przywara wrote:
> > .get_state() can return an error indication now. Make use of it to
> > propagate an impossible prescaler encoding, should that have sneaked in
> > somehow.
> > Also check the return value of clk_get_rate(). That's unlikely to fail,
> > but we use that in two divide operations down in the code, so let's
> > avoid a divide-by-zero condition on the way.
> >
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> > Hi,
> >
> > this goes on top of Uwe's series to introduce and observe .get_state
> > failures: https://lore.kernel.org/linux-pwm/20221130152148.2769768-12-u.kleine-koenig@pengutronix.de/T/#m9af39aa03bbd9bb7b31b3600f110c65ee0e8e70b
> > Actually it only relies on patch 01/11 from that.
>
> I recommend to put this info in machine-readable form into your patch.
> If you applied my patch #1 on v6.1-rc1 and this on top, you'd do
>
> git format-patch -1 --base v6.1-rc1
>
> This results in two additional lines that the build bots can evaluate,
> to find the right setup to test your patch.
Ah, nice one, didn't know about that. And just went I wanted to
complain that this relies on public branches and committed patches, I
learned that it doesn't.
So I got:
base-commit: eb7081409f94a9a8608593d0fb63a1aa3d6f95d8
prerequisite-patch-id: 3022328f2919301d79d852ef148c3f9dc4d723d6
Do you want me to resend the patch with this information?
> Apart from that:
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks for that!
Cheers,
Andre
>
> and thanks to pick up on this topic,
> Uwe
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-02 23:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 15:22 [PATCH] pwm: sun4i: Propagate errors in .get_state() to the caller Andre Przywara
2022-12-01 15:48 ` Uwe Kleine-König
2022-12-02 23:37 ` Andre Przywara [this message]
2022-12-03 1:56 ` Samuel Holland
2022-12-03 9:50 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202233738.281329b1@slackpad.lan \
--to=andre.przywara@arm.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox