From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADDB9C3A5A7 for ; Tue, 6 Dec 2022 21:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PQEzI06YXJBR2HteKwwdW6ejo3r/16qkgQS5vls9cf8=; b=zZ086flOrLVauE aFzVVNKp3KHHCN6YBw6ntt/+zGbawsbjn7DKV1qu9EIzdZDuSRCvEATQjKqY0iC/ry5BLNwBLBZiC lXrF8Ei9OXF3M+rsrbdmjBnPclN2Q5+YycZ9+/eg2jjYVNuU7BqqaV5OZvmkC3dkP/0o9Tzj5Egej t7k3pIRU5/YpD/TDOFAKeuvQXh/+lFLkPGGxDuHHi64hOMjNXNFFYc5uVpPNommDnXlFQIEcl5XP7 Lma/qN69QM4VaskbKXOeVdOe3hWhiH+kuxaVq7sXKl6pjrtQpY+c60DyiOolkQti52qecEfunh2pl 9GYk9PmqcQ7If6H7h9Ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2f7K-002WMf-Qe; Tue, 06 Dec 2022 21:04:42 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2f7H-002WJ6-Db for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 21:04:40 +0000 Received: by mail-lf1-x12f.google.com with SMTP id bp15so25577107lfb.13 for ; Tue, 06 Dec 2022 13:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bGfC41RTI6jgj8ywYESKxaRQC3IxCMppOBqs9HFb7hI=; b=bNQEtaR1NsMh9mBbNKD/Y01RTcj/56safmMbTV/XW62mfIJ4Q2KApj/steVorzOSvc ld9uCsyPAxJYAPy79UOF9M3rXiJQjqcLyWxuefpT7WA6VMckwzOhQnmPEhsgRjmzOxnc Iyw8R76JCvgW+E23NufgvCV4kagx6FLlbbdh6AnXqHigklPlbkuj50CzZhDJrkWGKFc5 d4XrH3K95NJs5ju+3Neok+onvTqB2Qo9384vttmTufY3TTwvUQtr5gCzclfArNjX71QM r5EtdiKwXIS544o6qQWwwSKL/NX13b5zssd1zLHSuEO5eDBpSIix9DJhZd4B7T3yzZ// G7bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bGfC41RTI6jgj8ywYESKxaRQC3IxCMppOBqs9HFb7hI=; b=wHcLsj9Pl9nlnACNq/6pqH0m/fBTQxfz435XCzIXz3dO32ZFDWY33lKtUvad9JM3Gd YHZdwJdYGNQOdCnjPlig64pG480F3PjBmh/L7Idz69EWCA3O2iL13yU/JyISXv8aFxgX gw37mDxXd9Hs0HJ3U+5LuCMvza/abjPXzmU3q4QFj3EETQEtVBZodSkJ58ygZ0ufdsjn Cc/9AFiDC+ksWNAbAmMK+d2oJ8nyG3Ix5IZbr5Og+vWEj4TvSmX+2ku+UUglsvinV1y/ uL4fa7rCQBROkiilw+Wh/nvu+waKPE/HNMDl1adpjx9/0hg9HWzpVSy/C/vic5WEiN0j IoVw== X-Gm-Message-State: ANoB5pn4VSFfROJjB1AAfriLBnMCtDt5nFIXsYkJCPSKFhMrykUavhrw Dgcm3f1RsBLUpjjUeHQxheg= X-Google-Smtp-Source: AA0mqf6lk8n1mSovdZxsNEks0iX3SYkOI7bB3GP+FfVi9H/dJoGvipfviaVx3C8lx6rPgOyVK/Nh3Q== X-Received: by 2002:a05:6512:104e:b0:4b5:604a:5b24 with SMTP id c14-20020a056512104e00b004b5604a5b24mr5337245lfb.550.1670360676996; Tue, 06 Dec 2022 13:04:36 -0800 (PST) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id p1-20020ac24ec1000000b004991437990esm2618593lfr.11.2022.12.06.13.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 13:04:36 -0800 (PST) Date: Wed, 7 Dec 2022 00:04:34 +0300 From: Serge Semin To: Damien Le Moal Cc: Arnd Bergmann , Anders Roxell , Niklas Cassel , Naresh Kamboju , Praneeth Bajjuri , Serge Semin , open list , Linux ARM , "regressions@lists.linux.dev" , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "lkft-triage@lists.linaro.org" , Lukas Bulwahn , Carlos Hernandez , Sumit Semwal Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag Message-ID: <20221206210434.wdttz5aj7ipzsvcy@mobilestation> References: <20221017155246.zxal2cfehjgaajcu@mobilestation> <20221205011105.4do4trbytq4bfw5b@mobilestation> <98670e23-6553-4788-8662-9403c480af82@app.fastmail.com> <20221206084637.olaflvqmxwoo467a@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_130439_496001_EE97439B X-CRM114-Status: GOOD ( 22.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 06, 2022 at 06:12:48PM +0900, Damien Le Moal wrote: > On 12/6/22 17:46, Serge Semin wrote: > > On Mon, Dec 05, 2022 at 10:24:22PM +0900, Damien Le Moal wrote: > >> On 12/5/22 19:08, Arnd Bergmann wrote: > >>> On Mon, Dec 5, 2022, at 02:11, Serge Semin wrote: > >>>> On Thu, Dec 01, 2022 at 12:48:32PM +0100, Anders Roxell wrote: > >>> > >>>>> > >>>>> for (i = 0; i < hpriv->n_clks; i++) { > >>>>> - if (!strcmp(hpriv->clks[i].id, con_id)) > >>>>> + if (hpriv->clks && hpriv->clks[i].id && > >>>>> + !strcmp(hpriv->clks[i].id, con_id)) > >>>>> return hpriv->clks[i].clk; > >>>>> } > >>>> > >>>> Indeed I should have taken into account that devm_clk_bulk_get_all() > >>>> can get unnamed clocks too. But checking the hpriv->clks pointer for > >>>> being not null is redundant, since the ahci_platform_get_resources() > >>>> procedure makes sure that the array is always allocated. At the very > >>>> least you shouldn't check the pointer in the loop, but can make sure > >>>> that the clks array is available before it. > >>> > > > >>> Do you think this is otherwise the correct fix then? Any chance we > >>> can still get a version of it into 6.1? > > > > I'll think of a better solution. But at this stage it seems like the > > best choice seeing the bindings permit having unnamed clocks > > specified. > > > >> > >> If someone sends me a proper patch to apply, I can send a last PR for 6.1 > >> to Linus before week end. > > > > I'll submit the patch today. Thanks. > > Anders just posted one. Can you review it please ? Done. Thanks. -Serge(y) > > > > > -Serge(y) > > > >> > >> > >>> > >>> Arnd > >> > >> -- > >> Damien Le Moal > >> Western Digital Research > >> > > -- > Damien Le Moal > Western Digital Research > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel