From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEDC0C4332F for ; Thu, 8 Dec 2022 16:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jq2CPg1b5uYOt9Sg/yEQij0Xnm7sWEN/eBdoU+zZ8UM=; b=X5NUAQFE+GKKz0 i0uUX3vEJvo3ynINc2CHw7zcrxTIOdr6GT5lENza+2CU7VJN2yf0gKIxxrnEx0HxHAGvnXFY92rt0 M3A8XSoybvhpQPJkOoocennXJytr7M3c5vFdZFTSbmApI1lS5phDW3KI80lPY7YOD/fSK4xjjpzt3 CrNT85OwhcKb4WKihHobe5C5en6y5dnrWRLI4eermblE5lCpo86dTzSrWcRpskd2NTVpVLjgTPzpX 3vF12VSNIYzjN1xmyGaIQI69bMQaaskK+2sr51clMYw6VzcZH48cOqzEL/Muhwt9LiHAZn0JPCMbM 5XXjotNNCvzcw2oAbtvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3JWZ-004wbK-1i; Thu, 08 Dec 2022 16:13:27 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3JWE-004w5R-Ts for linux-arm-kernel@lists.infradead.org; Thu, 08 Dec 2022 16:13:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 96633B8244B; Thu, 8 Dec 2022 16:13:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30F6DC43392; Thu, 8 Dec 2022 16:13:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670515984; bh=Qde2C0XseICWJ9axUHk+ySbKeUZMloNhqaNQY6sMTyk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=pDEu0Ne9buL6WbAiy8oy1XYCB2SNCbUolexneKZsD7Xy7q+2viRVZuDto53lz4dKw oiKGGVt+cVmr0yxYe9DZtE2ERXAcYkQtVQUBet1vlrbLiH8ujdiEsh8oV2efEPfU8w lCxd5sUovbXb+TQpf/wK/njOV2lbyNsKuM4x1C5W7pu9WFsBtdZ+GLFf/kmUSex6Ug jx+YCKZmJMCUTHGjHikKd5N+he4ee6A6OtCcxzM37ldIDYoTaso0iakpI0LMZ7yWgY 9LLyHd0wDuJFqri64ov48Luf+cLXsnOKf2S0BU4kxS+aDYjZiHym4F0GIxfbwPwuoe Pmx3TOqeC56Rg== From: Mark Brown Date: Thu, 08 Dec 2022 16:03:22 +0000 Subject: [PATCH 1/6] arm64/cpufeature: Fix field sign for DIT hwcap detection MIME-Version: 1.0 Message-Id: <20221207-arm64-sysreg-helpers-v1-1-149fa1308a23@kernel.org> References: <20221207-arm64-sysreg-helpers-v1-0-149fa1308a23@kernel.org> In-Reply-To: <20221207-arm64-sysreg-helpers-v1-0-149fa1308a23@kernel.org> To: Catalin Marinas , Will Deacon Cc: Suzuki K Poulose , James Morse , linux-arm-kernel@lists.infradead.org, Mark Brown X-Mailer: b4 0.11.0-dev-64ef0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1840; i=broonie@kernel.org; h=from:subject:message-id; bh=Qde2C0XseICWJ9axUHk+ySbKeUZMloNhqaNQY6sMTyk=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBjkg0H2ocyVf6FUz9dCxEtq8QAJxJ5/mZE8PYoSZya hzas7xGJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCY5INBwAKCRAk1otyXVSH0CASB/ 0brMd4M6lE/rYepDFV8vrWxPTrb0RK2M5qEZFNr7IHHcp3Okz3bhcbMI1S5zD34eeDeH/qFPuGdNGK GP9Xh2cj7y0dfW89AN4iIjg52kHOdBRDtoAjzQSEt/QB5l12R8nPDe2C5TayA31MrBAOEyZONdPTNO NWuQF3QSSFCyu/C7t9q7GHx373aXhEpHfIWu5DNaOdzVv+VIevOLxl9n/ns0RrXMg9D+gWw/5h5ku2 rZV4zEYGMiL45rQ6LUNf4CphjZcU/LrI/LJk57pst/CEV2ILWB6qKMlDsPZjBmi3OOIDbWz6grhuKa NkG6w4jAx6n5aycbTHglny/cbR/Km1 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221208_081307_303094_2BC1C665 X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since it was added our hwcap for DIT has specified that DIT is a signed field but this appears to be incorrect, the two values for the enumeration are: 0b0000 NI 0b0001 IMP which look like a normal signed enumeration and the in-kernel DIT usage added by 01ab991fc0ee ("arm64: Enable data independent timing (DIT) in the kernel") detects the feature with a signed enum. Fix the hwcap to specify the field as signed. Fixes: 7206dc93a58f ("arm64: Expose Arm v8.4 features") Signed-off-by: Mark Brown --- arch/arm64/kernel/cpufeature.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index 7e76e1fda2a1..c687b0052a3f 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -2775,7 +2775,7 @@ static const struct arm64_cpu_capabilities arm64_elf_hwcaps[] = { HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_FP_SHIFT, 4, FTR_SIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_FPHP), HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_AdvSIMD_SHIFT, 4, FTR_SIGNED, 0, CAP_HWCAP, KERNEL_HWCAP_ASIMD), HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_AdvSIMD_SHIFT, 4, FTR_SIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_ASIMDHP), - HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_DIT_SHIFT, 4, FTR_SIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_DIT), + HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_DIT_SHIFT, 4, FTR_UNSIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_DIT), HWCAP_CAP(SYS_ID_AA64ISAR1_EL1, ID_AA64ISAR1_EL1_DPB_SHIFT, 4, FTR_UNSIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_DCPOP), HWCAP_CAP(SYS_ID_AA64ISAR1_EL1, ID_AA64ISAR1_EL1_DPB_SHIFT, 4, FTR_UNSIGNED, 2, CAP_HWCAP, KERNEL_HWCAP_DCPODP), HWCAP_CAP(SYS_ID_AA64ISAR1_EL1, ID_AA64ISAR1_EL1_JSCVT_SHIFT, 4, FTR_UNSIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_JSCVT), -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel