From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8689AC4332F for ; Tue, 27 Dec 2022 13:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k2xBj8ZNaHTTkm1M4wJG0jyFvNiC2DdU6Swpg+sjAYY=; b=eu6wqzk9WFQW81 +EVlyP43IUiWLlHa2tMw9Az+TA+Pk7zSQaVx/TRfyqMZ141Oiccyj0ReCOmkVekeK/CCtVn8i1wmi A991xU/y22Z1SqjfpXMND1fn2p4xdEj993UD587e1dB/yBJ6r45h67tLcAWgo5S3ZVrjy1vmNVn09 xLalpFBFoLu5sEF0bfXeNK6TXHhHK3McUWkTAuZo9PfHqOgy2vXF3j3cqKo0RK1rwPQmTYRkWR2mb 9oD1jZxzUFcny2Do68Dec7zGVKRENqRdlxewDuBbVmP00hv4e+Hi5HbxCRSzWKZYJWp05/hFViJjQ Ucwo3+4eEUUFmi0utSLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pA9Xi-00D4M1-Fq; Tue, 27 Dec 2022 12:58:54 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pA9Xe-00D4KL-Ku for linux-arm-kernel@lists.infradead.org; Tue, 27 Dec 2022 12:58:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 381616114D; Tue, 27 Dec 2022 12:58:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32742C433F2; Tue, 27 Dec 2022 12:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672145929; bh=63/jcnnYaKocGU5v3WqK31EHGIjP46LRXnzXrtNcw74=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rA+mZPszyDHFOthQAaonMxxvx4QyvE5Ys/P9oT2FqYp52anw5F7XWFxEYuKAWebDS EmNL9u5HsZIi/irHiLBZ8SDZ+ALaqby3OcNp0tZMgBqTInrIgdMxDiW7AwzaczZJ1i MrQhOPSPWhGRr+78Kb+824WFTd+tPNulXg4s446H7uRz8rwqOp75Er+zz0WQdhjWyb Q1Tq5b0LrLw2PNxymDbjGUUKk4YZcJ8eGvBH8hwJzqtorl/JDka64yP4bpH2Rh94lt 7lt9jXPCeWO4KrVm2LiyuhR8wztopOoKd9HTi4LVkGb8mD7vlL6bObUWKNHMjE3JP+ pMjeOQB1zqjgg== From: Mark Brown Date: Tue, 27 Dec 2022 12:55:54 +0000 Subject: [PATCH v3 1/7] arm64/cpufeature: Fix field sign for DIT hwcap detection MIME-Version: 1.0 Message-Id: <20221207-arm64-sysreg-helpers-v3-1-0d71a7b174a8@kernel.org> References: <20221207-arm64-sysreg-helpers-v3-0-0d71a7b174a8@kernel.org> In-Reply-To: <20221207-arm64-sysreg-helpers-v3-0-0d71a7b174a8@kernel.org> To: Catalin Marinas , Will Deacon Cc: Suzuki K Poulose , James Morse , Mark Rutland , linux-arm-kernel@lists.infradead.org, Mark Brown X-Mailer: b4 0.12-dev-7ab1d X-Developer-Signature: v=1; a=openpgp-sha256; l=1897; i=broonie@kernel.org; h=from:subject:message-id; bh=63/jcnnYaKocGU5v3WqK31EHGIjP46LRXnzXrtNcw74=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBjquwAFwfaq7zYNu1H9+Sl0zol8LxOX51cZElBZh16 MmP2jyuJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCY6rsAAAKCRAk1otyXVSH0Mq+B/ wPF5OGFpMyjN8tp3WgJ6nbO8lF59FRWtQRAcDoCtP7w+BQ0qfZzEgUTjtsOaryrOB0l3bnFVfI6FtS RqgF82UlnPiONb2FLm7B2cYKJTuD0ifSWV+mDGYYA0bF/ipzp/wziWHuGuiqlWTE9dO1nkhaTFTy20 LDrWZ+7apYNg/NTPObc3BWpdwNFVnlXOL9keAro1Wre3aL8qzRBwFgI/7gnjQndR0yM56No6KEs+O4 XTMyOUSRRgYJ8FmvENS1vJbUFwW+JYP8tWQRRZw1ZS1kf5y8J4UxVj5spP8DBeKzG/4Sf53CFa+02n F41Xpsi6UGlmV9R64rG2nLUR5hOC97 X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221227_045850_783381_B8598ABA X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since it was added our hwcap for DIT has specified that DIT is a signed field but this appears to be incorrect, the two values for the enumeration are: 0b0000 NI 0b0001 IMP which look like a normal unsigned enumeration and the in-kernel DIT usage added by 01ab991fc0ee ("arm64: Enable data independent timing (DIT) in the kernel") detects the feature with an unsigned enum. Fix the hwcap to specify the field as unsigned. Fixes: 7206dc93a58f ("arm64: Expose Arm v8.4 features") Reviewed-by: Mark Rutland Signed-off-by: Mark Brown --- arch/arm64/kernel/cpufeature.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index a77315b338e6..ee40dca9f28e 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -2777,7 +2777,7 @@ static const struct arm64_cpu_capabilities arm64_elf_hwcaps[] = { HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_FP_SHIFT, 4, FTR_SIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_FPHP), HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_AdvSIMD_SHIFT, 4, FTR_SIGNED, 0, CAP_HWCAP, KERNEL_HWCAP_ASIMD), HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_AdvSIMD_SHIFT, 4, FTR_SIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_ASIMDHP), - HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_DIT_SHIFT, 4, FTR_SIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_DIT), + HWCAP_CAP(SYS_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_DIT_SHIFT, 4, FTR_UNSIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_DIT), HWCAP_CAP(SYS_ID_AA64ISAR1_EL1, ID_AA64ISAR1_EL1_DPB_SHIFT, 4, FTR_UNSIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_DCPOP), HWCAP_CAP(SYS_ID_AA64ISAR1_EL1, ID_AA64ISAR1_EL1_DPB_SHIFT, 4, FTR_UNSIGNED, 2, CAP_HWCAP, KERNEL_HWCAP_DCPODP), HWCAP_CAP(SYS_ID_AA64ISAR1_EL1, ID_AA64ISAR1_EL1_JSCVT_SHIFT, 4, FTR_UNSIGNED, 1, CAP_HWCAP, KERNEL_HWCAP_JSCVT), -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel