From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B5BAC352A1 for ; Wed, 7 Dec 2022 14:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=16R7y76BVyvpuivOHEdcUCrm3vAoFa222tuaMcE8Pis=; b=DgfzGX5m+gXpXE erqjvUIg21yz18d3N37gA8Y5BOsnETH40tm9soc3huSnKs0kh5L9j/qG8tAq21F6feZNn7zACfa/p 6KZzf1C4v5UaXuJcHvwFIr/gVp7q5LolycTcbln1OwWrbkCim0t+i3hlleZVOIbev0/S9/GVgNvRI YHjUErVGZglfw58pNh9UHq9gCPMCcrl/Lts0RzbAKOxA/Omx55X+xjiY32QJgzVWpG8LSxxzpi6ig kONQgpWpYQRZVD+LqCCOwrIoiG3UVZuw7z8AejLlByesO2RrGnZBEGH3TW6ENrfxaKBGo5uNDDEvV lxkHTcS5YhKwMl6GVL8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2vQe-004tKR-4p; Wed, 07 Dec 2022 14:29:44 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2vQa-004tIk-QV for linux-arm-kernel@lists.infradead.org; Wed, 07 Dec 2022 14:29:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C4AF1B81E67; Wed, 7 Dec 2022 14:29:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36CD7C433C1; Wed, 7 Dec 2022 14:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670423377; bh=6AueI/R7NkY5/yznLeaPmx1C6XPv/QQTTXkT55QnZhM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=gxquZ4G5MCdgIzZBBwRm1O3iITEHwuoqcju1+xmdA9s9FaF2e2TYyn6TGKKMvumST Zfn6hThPkWYG1yJbYFGzA/JkHTcjB/iw8A9JDA5/u8bD4jX/bOf7nxig/iWiBMVN6N 4EYQTu9q6crkhxnGEpmopQB8m8RsQ3yF/yA9JrN0li/zz3V+HtolbP/qlwvdt7JRdH PiUm1CXfgKvM779F+XWpxaN9f3DWVvIw1fWNQksfzE5NJ6h1eMaqRNGYs/MoelwHy5 yt+cx1rkKC4K/rbPRkZJehPO3cAxUeKJxalaEC6v1qyw1b5KdaU9HjfkeT0hLPFs+7 Cahb1FOKE8IYA== Date: Wed, 7 Dec 2022 08:29:35 -0600 From: Bjorn Helgaas To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Lorenzo Pieralisi , Gregory CLEMENT , pali@kernel.org, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lukas Wunner Subject: Re: [PATCH v2 01/10] PCI: pciehp: Enable Command Completed Interrupt only if supported Message-ID: <20221207142935.GA1440263@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220927141926.8895-2-kabel@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221207_062941_082229_236B9A2F X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 27, 2022 at 04:19:17PM +0200, Marek Beh=FAn wrote: > From: Pali Roh=E1r > = > The No Command Completed Support bit in the Slot Capabilities register > indicates whether Command Completed Interrupt Enable is unsupported. > = > We already check whether No Command Completed Support bit is set in > pcie_wait_cmd(), and do not wait in this case. > = > Let's not enable this Command Completed Interrupt at all if NCCS is set, > so that when users dump configuration space from userspace, the dump > does not confuse them by saying that Command Completed Interrupt is not > supported, but it is enabled. > = > Signed-off-by: Pali Roh=E1r > Signed-off-by: Marek Beh=FAn > Reviewed-by: Lukas Wunner Since this isn't directly related to aardvark or the rest of the series, I applied this to pci/hotplug for v6.2, thanks! > --- > drivers/pci/hotplug/pciehp_hpc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pcieh= p_hpc.c > index 040ae076ec0e..10e9670eea0b 100644 > --- a/drivers/pci/hotplug/pciehp_hpc.c > +++ b/drivers/pci/hotplug/pciehp_hpc.c > @@ -811,7 +811,9 @@ static void pcie_enable_notification(struct controlle= r *ctrl) > else > cmd |=3D PCI_EXP_SLTCTL_PDCE; > if (!pciehp_poll_mode) > - cmd |=3D PCI_EXP_SLTCTL_HPIE | PCI_EXP_SLTCTL_CCIE; > + cmd |=3D PCI_EXP_SLTCTL_HPIE; > + if (!pciehp_poll_mode && !NO_CMD_CMPL(ctrl)) > + cmd |=3D PCI_EXP_SLTCTL_CCIE; > = > mask =3D (PCI_EXP_SLTCTL_PDCE | PCI_EXP_SLTCTL_ABPE | > PCI_EXP_SLTCTL_PFDE | > -- = > 2.35.1 > = > = > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel