From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2269FC4708E for ; Wed, 7 Dec 2022 15:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m1sjKE5VeRjz6Bibv7QTTXQs7cAWpfH1G8jcXUpWLwE=; b=jM7VGCHesgU6DO CJuRX2ywphSev3m3rXQhkNbhDvHs2g8T/Nb0+05RG9ASOLta9riyg5Q7CNv4JNIy7wEsEe77qzwEu NfQnA4ge/TiMSnwI/IMU+gtS13XJJVfdfdR/cwQpD/OqD8bSBXBRWhFTtBsf18LlRjjyMa+HH2Mdb yth4XwSCE2YMcjLwJOeMVHHilyVhyNyZafSzDeheH3w4MLXqU/LMElwER4IIPgKrSXstzOUUkJUEF GzPijgY1ZuEj28p5iDRM++s0aVbEAUKIcz8j5viT2ndsDtbNBYjqz8jzz1gTC6lGiW5eP7Abm7p7X yOly+/L7zrVv7ajWtI1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2wSn-005ukq-JQ; Wed, 07 Dec 2022 15:36:01 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2wSj-005udu-MS for linux-arm-kernel@lists.infradead.org; Wed, 07 Dec 2022 15:35:59 +0000 Received: by mail-oi1-f174.google.com with SMTP id v82so21117113oib.4 for ; Wed, 07 Dec 2022 07:35:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lBpBd7+pFnpb+CGSyhsTaAtXlwJmyfr3U6zIXBU+CU8=; b=SFgpMw98xRZcvb0ajJKNE6j+q8VBLLBBORKsMkEPr5UvJj22878YRgIQ5T7w+DG8wP i3GwhH9WQG6cdQHU/VBOtUq2EaeD83gOhmVpllMx6eQIh2f+4c6Hc4k0T9zvkeWmdTIs PIWzH2KsQbBxgxqqRMXFz2UKwBVYtpwzXjeIwaHd0EuOu57+lhjCcKcEEqUOI5D+0JJc j5uC4bomlBEB8StfY5PLqyqsYF9WlzwKL9IVRcpGUR8vswQ75BntthB1VU1uQnO3J9oQ 10B7U7pelEVKmxo+kws03B3oT45TjPAAmdBqwhV7f0HpRKbm658nUuSbucGfy1WcK/eL 9FbQ== X-Gm-Message-State: ANoB5plwNznWWWQSXAIwDILdLVhtnd9ybVQqWLcLUSFScirvLBV/fWAy VPQCOXapEbmdHY5hre92IXpLxRD2EA== X-Google-Smtp-Source: AA0mqf6Feu1onLJPtKNVbwwfEe7rbawqt0LgfrOo7YBldPyEM5I/BsLZS0ysSmXTDBpwIUzHe7p7Mw== X-Received: by 2002:aca:1e0d:0:b0:35b:b54d:19a with SMTP id m13-20020aca1e0d000000b0035bb54d019amr21750341oic.242.1670427354571; Wed, 07 Dec 2022 07:35:54 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id s17-20020a056870631100b00136f3e4bc29sm12245693oao.9.2022.12.07.07.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 07:35:54 -0800 (PST) Received: (nullmailer pid 2275786 invoked by uid 1000); Wed, 07 Dec 2022 15:35:53 -0000 Date: Wed, 7 Dec 2022 09:35:53 -0600 From: Rob Herring To: Kunihiko Hayashi Cc: Krzysztof Kozlowski , Masami Hiramatsu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/16] dt-bindings: soc: socionext: Add UniPhier SoC-glue logic Message-ID: <20221207153553.GA2269092-robh@kernel.org> References: <20221207055405.30940-1-hayashi.kunihiko@socionext.com> <20221207055405.30940-10-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221207055405.30940-10-hayashi.kunihiko@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221207_073557_755547_51D3C2FD X-CRM114-Status: GOOD ( 18.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 07, 2022 at 02:53:58PM +0900, Kunihiko Hayashi wrote: > Add devicetree binding schema for the SoC-glue logic implemented on > Socionext Uniphier SoCs. > > This SoC-glue logic is a set of miscellaneous function registers > handling signals for specific devices outside system components, > and also has multiple functions such as I/O pinmux, usb-phy, debug, > clock-mux for a specific SoC, and so on. > > Signed-off-by: Kunihiko Hayashi > --- > .../socionext,uniphier-soc-glue.yaml | 113 ++++++++++++++++++ > 1 file changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml > > diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml > new file mode 100644 > index 000000000000..6fc790963660 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-glue.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-soc-glue.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Socionext UniPhier SoC-glue logic > + > +maintainers: > + - Kunihiko Hayashi > + > +description: |+ > + SoC-glue logic implemented on Socionext UniPhier SoCs is a collection of > + miscellaneous function registers handling signals outside system components. > + > +properties: > + compatible: > + items: > + - enum: > + - socionext,uniphier-ld4-soc-glue > + - socionext,uniphier-pro4-soc-glue > + - socionext,uniphier-pro5-soc-glue > + - socionext,uniphier-pxs2-soc-glue > + - socionext,uniphier-sld8-soc-glue > + - socionext,uniphier-ld11-soc-glue > + - socionext,uniphier-ld20-soc-glue > + - socionext,uniphier-pxs3-soc-glue > + - socionext,uniphier-nx1-soc-glue > + - const: simple-mfd > + - const: syscon > + > + reg: > + maxItems: 1 > + > +patternProperties: > + "^pinctrl(@[0-9a-f]+)?$": > + $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml# > + > + "^usb-hub(@[0-9a-f]+)?$": > + $ref: /schemas/phy/socionext,uniphier-usb2-phy.yaml# > + > + "^clock-controller(@[0-9a-f]+)?$": > + $ref: /schemas/clock/socionext,uniphier-clock.yaml# > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - socionext,uniphier-pro4-soc-glue > + - socionext,uniphier-ld11-soc-glue > + else: > + patternProperties: > + "^usb-hub(@[0-9a-f]+)?$": false While just if and else is valid json-schema, we require 'then'. Can you change this to 'if: { not: {...}, then: {}'. You should be getting a warning for this. The rest of the warnings from the bot look like false positives you can ignore. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel