From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B16B5C4332F for ; Thu, 8 Dec 2022 16:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v9f4/N+PeEFtftGb8vxorXn12yzgjz4vVXc+c3XsSS4=; b=p2yV9krJT01oYU Q26Hk9h8NezCCu4xcKd4dc/12S/eUop83bbzRBZC1EQjfiuYF9+M3/53A5zYKAHXWgtaqmDmi94IT obTAtokc2CKilIaVGSoCzdSITAVAQkqiuEUA2khcbev+i8YL+0wrmm5/boNreZV+6RcoBLPtCTpPz rHNYa1/rvuVe0BZhuUbM6awiYD98wfzBEPK/IqqHm9ibcbyXcQY026T0ixp43N5cKaiBHu8PxtiIg PHULd2fZJxjbsXjfbj3cqdM31wylte/D9ti47ZAVBVAMU0M9BDZiCLPLryRK9WiiY4UIBzoKlKgjW hKWh5bzVCyC/0mC2ir4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3Jcw-0053CV-9p; Thu, 08 Dec 2022 16:20:03 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3Jcs-0053BE-9G for linux-arm-kernel@lists.infradead.org; Thu, 08 Dec 2022 16:19:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 159F461F90; Thu, 8 Dec 2022 16:19:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F6D2C433EF; Thu, 8 Dec 2022 16:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670516396; bh=M+Jm9v4PbD+01xedeGhK2H9LDFBDPBUKSkXffaF+n4g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nrXhlD5XL3j5Ua9Mq2v5wzA2shGW068fVnqoxFM1z57paGvpw4n1xZbuEyjyXfB9j gaExw6exvMeKoNHPDC2I9nd3O5xQNkrqv+TYJAvY13SbUt7T5CjSP7NOdFHBs93P6p yVbhKZgrUCKCxmOW/W9Ci4CHWY1OcuTOva7LVGmRVqjAZTVijbRKulTrbNUT6Oob1X vPyZkToqrE8gb2HzD6NTqpBkhpmzRwbHqig7r8HN/5WMf8ZP2pWyia5ut6oFVk5e0d rXxTp8UxmeU7ZNR7ojspfpnhHasD5VrC9UBNjmCTU+3u/t5zIWZhzBEOBxqLCnnDUQ ersxppwIOY63Q== Date: Thu, 8 Dec 2022 08:19:55 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , Vadim Fedorenko , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, "Olech, Milena" , "Michalik, Michal" Subject: Re: [RFC PATCH v4 2/4] dpll: Add DPLL framework base functions Message-ID: <20221208081955.335ca36c@kernel.org> In-Reply-To: References: <20221202212206.3619bd5f@kernel.org> <20221205161933.663ea611@kernel.org> <20221206092705.108ded86@kernel.org> <20221207085941.3b56bc8c@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221208_081958_400179_14C448F9 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 8 Dec 2022 09:14:32 +0100 Jiri Pirko wrote: > >Running DPLL control in a namespace / container. > > > >I mean - I generally think netns is overused, but yes, it's what > >containers use, so I think someone may want to develop their > >timer controller SW in as a container? > > The netdevices to control are already in the container. Isn't that > enough? For DPLL config we need to delegate the permission. So we'd need a "is net admin in namespace X" check, no? > >> Thinking about it a bit more, DPLL itself has no network notion. The > >> special case is SyncE pin, which is linked to netdevice. Just a small > >> part of dpll device. And the netdevice already has notion of netns. > >> Isn't that enough? > > > >So we can't use devlink or netdev. Hm. So what do we do? > >Make DPLLs only visible in init_net? And require init_net admin? > >And when someone comes asking we add an explicit "move to netns" > >command to DPLL? > > Well, as I wrote. The only part needed to be network namespaced are the > netdev related pins. And netdevices have netns support. So my question > again, why is that not enough? For config which goes thru rtnl, yes, but we also need a caps check for: + DPLL_CMD_DEVICE_SET, + DPLL_CMD_PIN_SET, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel