From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AC05C4332F for ; Fri, 9 Dec 2022 12:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rq0QxArpyl+taWxR/W/n+8WYkQaLlbTtiwlLu8QwpEg=; b=Q7rqKE5JQW0Nf8 +qNVfCFtlQnctaDCFa5FaNsRnLPnyB8D4JFC8aCy+3Q5TNOJ3kNgTieuekJF44OdpKEVGiQRzBR2o 0ncMZQZF9tRdzwlcIhjR5e8iBpelOlZ5PWCt3qeElCrWYKm44gA8XOzXAcL+LAMKLzC7GyuDDbsR7 PikWyAGnKgtOF1Gk5mKu+LFksAZ3Viov4dgBcmhQfTArLzMDIGiB40Vn8mPGAcvKL8a5quz4akiZi kZZJcAXrd52uVBAaUYrmM+savnOh79McbbBQtQ7LZ9rknRKd4r1cR2HoVWATYls+uNpUidG7QALx+ p3xhwZRT/hKkFhX/chdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3cvL-007nZe-4o; Fri, 09 Dec 2022 12:56:19 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3cvI-007nN6-Ul for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 12:56:18 +0000 Received: by mail-ed1-x531.google.com with SMTP id r26so2945703edc.10 for ; Fri, 09 Dec 2022 04:56:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7d1Hk/u5OkE2zPYqVbYpGU1t6ccVyflAO01wLSPYehQ=; b=nrcyWL5B1D8yzm6Claadu23KRt4dCLQtQAj73LLu7tsf+fEBzT/Lc/Ue6lS5DKTgK/ UHc75St4Muf57R5UmYqzFRHKc0qu9UbqFN6kNVFKVCZSvfqVrs9uxUJx73P/NTxkECEa iUA5ZLXWXZ+YvoBwsHkMNZEvYuJ+FR7l6RBcX8Hs4t4SYgJkPsSw/+3/h/ft0VFjJOge hFRhvqY4Np343jaAUrpHfDA5epFToMDsrgJKomlCQrFA8jenbVrSm+6lFmA3Lm1nbQ3S 10oMLMsCuVJjpih+mRqFx0vVPyIfygG5Y2QJxjLHP+OO0fy4lLbPUlD84m47Jpx1F/Lm bU7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7d1Hk/u5OkE2zPYqVbYpGU1t6ccVyflAO01wLSPYehQ=; b=CIdoUYZP8liWQHrdBGon871clifYmb1hlPkmYg3+msOKUxDshpsEPBw9j5p0gvobhr izUWX3GJ/PB82IdunLbtbbuPsrHXhxCVQjhzkOB3vxMa3yD40OaFKZcg6gO5kdnsA4Fh I3A8Sy7qABBkSv2oRxTVZI+6qL98aQ1ipv/0kVS/XiGRNbhxaOQE+nhTrmj7NvEgX6nj 8ZCcbjhWXHXk7vTcG7SXUG3wo6MjlgEmNHMo922ez7KY67qIrz4+FVU3xXoWz5mvO1Xi 0XKENzy/f0wKbr0M/g5aglJNhf8L1I2Od6jlwViL3KM6FJAIANHirSvQEW2T526t37iY Dtcw== X-Gm-Message-State: ANoB5plf/87+Efh45/jFW9mYx/Z8SjmBE/afZRauh7+I1iv7EfrTSAIh EL/gIJZPb3m0VaHsp2ZGlDc= X-Google-Smtp-Source: AA0mqf4B49UrOCx9aH+8tTfjnZpNxCiOB8/xSuBspW9baeEO5llmBHb6DqPi1DEiCpU1RegX2WHWng== X-Received: by 2002:a05:6402:4006:b0:46c:d5e8:2fc9 with SMTP id d6-20020a056402400600b0046cd5e82fc9mr6363175eda.13.1670590574002; Fri, 09 Dec 2022 04:56:14 -0800 (PST) Received: from skbuf ([188.27.185.190]) by smtp.gmail.com with ESMTPSA id n13-20020a05640204cd00b004677b1b1a70sm595922edw.61.2022.12.09.04.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 04:56:13 -0800 (PST) Date: Fri, 9 Dec 2022 14:56:11 +0200 From: Vladimir Oltean To: Horatiu Vultur Cc: Michael Walle , Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, daniel.machon@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, lars.povlsen@microchip.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, richardcochran@gmail.com Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221209125611.m5cp3depjigs7452@skbuf> References: <20221203104348.1749811-5-horatiu.vultur@microchip.com> <20221208092511.4122746-1-michael@walle.cc> <20221208130444.xshazhpg4e2utvjs@soft-dev3-1> <20221209092904.asgka7zttvdtijub@soft-dev3-1> <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_045617_014921_BD7A39A2 X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 09, 2022 at 01:58:57PM +0100, Horatiu Vultur wrote: > > Does it also work out of the box with the following patch if > > the interface is part of a bridge or do you still have to do > > the tc magic from above? > > You will still need to enable the TCAM using the tc command to have it > working when the interface is part of the bridge. FWIW, with ocelot (same VCAP mechanism), PTP traps work out of the box, no need to use tc. Same goes for ocelot-8021q, which also uses the VCAP. I wouldn't consider forcing the user to add any tc command in order for packet timestamping to work properly. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel