From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F7F4C4332F for ; Fri, 9 Dec 2022 14:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M9DOtMvlW1y7YZrO1M2GxekICPMsLuFjsT+5gxlLgl0=; b=gbrizTLpWfDOPK GC8RUuIpkoeqAM9O5waCqY3wExiYqP5PthEZtAA9kb2UApvW5bAUnmwNwlV+4KwfhjQAck5OEfu81 qoGAV0cmLxxE9WoFlKe+1heoI/2cbocnKfOdmatP9YFStv8kD6pBQxDUeDzfvZYouutiCm+6i4zjZ Zb0fFh+hes/ujD2/inTysXPpRaFGgPw2lYZ3mp/GgF+/WAXRLf6RrjE22UOKkrcYPOx5sD5apUVE/ dfpA5AGP1Xq8L/fBpkH+ZVT/gqjRn4HD4hpA1LhQoyycFnIgkdVHSjvWde6nxTkE+JniHd/L8mUhk iDy2pSh/YpvoqHugVEuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3eBR-008LnM-HK; Fri, 09 Dec 2022 14:17:02 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3e92-008KZE-T1 for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 14:14:34 +0000 Received: by mail-ed1-x532.google.com with SMTP id c66so3247238edf.5 for ; Fri, 09 Dec 2022 06:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=njNEdeCX3LeD6obQtBUMLdU2E9++XdRLWPu7vVBlAeA=; b=YouCT/pV13R+oR5x7eur72V4wd1rmyWDhlKQfyLGGDS3c4Cf0TSVuD9xca7Wa2PPb2 HUMcChLk/zXhSMtJBX+zKmWkqmwr+tMk3XVyZGurCeFTiaJCeGl57Ld39VA49CJX319M 9lNg27jgnRdqMUI3Y9HyUbQMFBXvFzAK6+WY82IcpoFfARy/rgNvbIFEawMuk6vZNW5Y PWWHvD1btsgooE5/guwvMvUz/jUKsqneZlFyqkopb8lvsao3QCII7sTJjSOPobwdyVuE ZKqSst7UpN9fLacvWpf8KSSIzWxIkR8uGYsubxOy812bGPqezyFsCWNFXyA87ahkrd2e +iHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=njNEdeCX3LeD6obQtBUMLdU2E9++XdRLWPu7vVBlAeA=; b=5JDzNigyA+irBUbk9igahBcaXnl2kbvV22WKtk34lj3q/lcQklCrrqa491L4+udT3h jUfmp4nLCkshilGVVt1Q+Bz7pkqd79MuU4U0SzMd3493fy22uFk1OKNm5xeuY2BkIQ4u NyBCR8J1StAvicQBjvORYm+nkD/BpwWIKzSoiO9rIl38bjZBgjxU47xUVFpi3L2wezdJ 0jnGlE67QDkB7XUeROyDa8hJmCermVL8+5ETCb1kftLPcDLuFPDgl8PqrWOUAHJ/P7MJ JO0jYvH7qKpn+6wnIvvkdqYVfyIHeHsLusXp03/tfIfdL6qnxxc57yg58yhrnBTGBC1f ylMg== X-Gm-Message-State: ANoB5pntceHqWxKTA0jhp0pGODlEI2tDdbedrcMlg2eqcVe2TzGpbXUo md3rr5qx/9SGs0ouHQ9QSlU= X-Google-Smtp-Source: AA0mqf78N0gl+Qh1C/I/Y/HMJqIzV06ohrt6b/FTqmbTW1L9ki0TvhzOALuzHFJFNF/7ZeoFIwYBZg== X-Received: by 2002:a05:6402:e06:b0:46c:2c94:d30a with SMTP id h6-20020a0564020e0600b0046c2c94d30amr5836585edh.31.1670595269014; Fri, 09 Dec 2022 06:14:29 -0800 (PST) Received: from skbuf ([188.27.185.190]) by smtp.gmail.com with ESMTPSA id a35-20020a509ea6000000b0046a0096bfdfsm688698edf.52.2022.12.09.06.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 06:14:28 -0800 (PST) Date: Fri, 9 Dec 2022 16:14:26 +0200 From: Vladimir Oltean To: Michael Walle Cc: Horatiu Vultur , Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, daniel.machon@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, lars.povlsen@microchip.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, richardcochran@gmail.com Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221209141426.2b7psesiu6txd6ue@skbuf> References: <20221203104348.1749811-5-horatiu.vultur@microchip.com> <20221208092511.4122746-1-michael@walle.cc> <20221208130444.xshazhpg4e2utvjs@soft-dev3-1> <20221209092904.asgka7zttvdtijub@soft-dev3-1> <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> <20221209125611.m5cp3depjigs7452@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_061432_999041_70189223 X-CRM114-Status: GOOD ( 22.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 09, 2022 at 03:05:01PM +0100, Michael Walle wrote: > Am 2022-12-09 13:56, schrieb Vladimir Oltean: > > On Fri, Dec 09, 2022 at 01:58:57PM +0100, Horatiu Vultur wrote: > > > > Does it also work out of the box with the following patch if > > > > the interface is part of a bridge or do you still have to do > > > > the tc magic from above? > > > > > > You will still need to enable the TCAM using the tc command to have it > > > working when the interface is part of the bridge. > > > > FWIW, with ocelot (same VCAP mechanism), PTP traps work out of the box, > > no need to use tc. Same goes for ocelot-8021q, which also uses the VCAP. > > I wouldn't consider forcing the user to add any tc command in order for > > packet timestamping to work properly. > > +1 > Esp. because there is no warning. I.e. I tried this patch while > the interface was added on a bridge and there was no error > whatsoever. Also, you'd force the user to have that Kconfig option > set. Yup. What I said about Ocelot is also applicable to MRP traps, which Horatiu added. No tc necessary there, either. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel