From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 933E6C4332F for ; Fri, 9 Dec 2022 14:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3hvv34LLhAiouMELW3/rJ8KPwoXvvwmFLoQ1hi5nkfQ=; b=q4iYah1PjyLrIK jookxhrVIPt1qTT3jUrEqUiK13w2FrEUcb3qufAQq0A/EVbzaNAELTN/tX2knl+0nVuUFczHPrMmk Rn/hl2rS9jwcXvxCJkXfNhi3JJ0we1edZ0Nxm6ZLJhu5J1regeSHIaE3WiCjM4IFIYKubnNI2wwTW vdyBSA1uepVUvDuFwz5vhbKERAS4RYQRVzG9+PVVa6xYTXAsJlMqlHs6WW8sb0flTmMr7Y1uqKWJ9 I0apA93dFDSNHPUqAEqR/1TaqcU4L2N+GAjYB4mmQQ7nf4qjFBdQyR4FOMBDHohAFdOI5WgmlUVn/ dJDyTXvJ2khIDlfrcyQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3eCZ-008Mbm-6J; Fri, 09 Dec 2022 14:18:11 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3eAR-008LGz-BV for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 14:16:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670595359; x=1702131359; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Q4a9U1SZ0Rp7ftX9JdBYHlEBnCnbX6tXmyOibpHi2+M=; b=dgCsstYfrR3B885WTYERk5x5G/EGvfxT4l4IRgpcp6nqU3iOGM9HZV+0 m+Txxse6+cA40oiGbb0i8pH8fXqBLl8Pj6deWeD8GB1NiuXemCOoDGaSq fbSTpBc9AJvOdAMB//48L/aJ1SVLlIWKSAyQZ4a+W1tsmr4LZui59/bqW vAlc6AOe1CDzKR5fgfmABVcSWL6sLZWAap1cpban02NZiaUFeHhd08pZV rENRHmtZts9tjs4IMuZcV+L34hK4fJy3tu6F03FseTzwEmFjZ0NIfGLUF 1Op6KHs5HIxV+0AHSDNOHbRTyVT3psfiMJh3loBl7bn5qjXiWaNPRh/3X A==; X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="190897842" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Dec 2022 07:15:52 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 9 Dec 2022 07:15:51 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 9 Dec 2022 07:15:51 -0700 Date: Fri, 9 Dec 2022 15:20:58 +0100 From: Horatiu Vultur To: Michael Walle CC: Vladimir Oltean , , , , , , , , , , , , Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221209142058.ww7aijhsr76y3h2t@soft-dev3-1> References: <20221203104348.1749811-5-horatiu.vultur@microchip.com> <20221208092511.4122746-1-michael@walle.cc> <20221208130444.xshazhpg4e2utvjs@soft-dev3-1> <20221209092904.asgka7zttvdtijub@soft-dev3-1> <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> <20221209125611.m5cp3depjigs7452@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_061559_538088_74EACEE2 X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 12/09/2022 15:05, Michael Walle wrote: > > Am 2022-12-09 13:56, schrieb Vladimir Oltean: > > On Fri, Dec 09, 2022 at 01:58:57PM +0100, Horatiu Vultur wrote: > > > > Does it also work out of the box with the following patch if > > > > the interface is part of a bridge or do you still have to do > > > > the tc magic from above? > > > > > > You will still need to enable the TCAM using the tc command to have it > > > working when the interface is part of the bridge. > > > > FWIW, with ocelot (same VCAP mechanism), PTP traps work out of the box, > > no need to use tc. Same goes for ocelot-8021q, which also uses the > > VCAP. > > I wouldn't consider forcing the user to add any tc command in order for > > packet timestamping to work properly. On ocelot, the vcap is enabled at port initialization, while on other platforms(lan966x and sparx5) you have the option to enable or disable. > > +1 > Esp. because there is no warning. I.e. I tried this patch while > the interface was added on a bridge and there was no error > whatsoever. What error/warning were you expecting to see here? > Also, you'd force the user to have that Kconfig option > set. > > -michael > -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel