From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBA3EC4332F for ; Fri, 9 Dec 2022 14:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aq2m1KkHl/xscOqMKHkKBnf5C6uw0ilsJs9ubTB4n1M=; b=jhGa0ZgbwNG0nG Var64kt2qvZj+ohbIO82ZWGnnKXHynfnES8QMvosv4eI+J/Nv3apXuUswbSa20rjIMPaZSfaCuR6o fZ/c+XS1XK8VjaVgvpTc5+rjIeKt+lMJ2DdcJDD+WGpFq5YEGGBfcD3bbCC3vAOGJptZRPJaHSmGH kzEufFxl/KTyVet3h72D89PGmWmTa8zZ+myBz8aE8KwgNgo5mlkIBayRKHuhNtiOnWkq0nE6eX1xs pl8nBHy7op2H9Pb/8luOLPWUhJ5yZlxiwlQin9e30mgA1qaAw9eH6KLY5iIk1Jo6XLGYWyEu62L5v gAaCvaaO/9zPoCjwL2Ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3eex-008aUn-H4; Fri, 09 Dec 2022 14:47:31 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3eev-008aSt-C0 for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 14:47:30 +0000 Received: by mail-ej1-x635.google.com with SMTP id ud5so12037751ejc.4 for ; Fri, 09 Dec 2022 06:47:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Chp2n3ay18nBkST/OunfW2Lm53v//eawAShT7k/YG4U=; b=nnk2q8E3MyYSalH3bsr/ati99hfOgwFx/e9QEnpUthYo8f3xizSWEDDJPTU/+bH55m re2rW7lJr9H/MDxUQ5FufYNFzYTrk9xxjwlw3D/b9Mo2kxgxAlfxH4V+guLuwGiB21TG nrwJidW7XkkpVIP5i6dmpAJFSd1B8iimn3Al6eikIYLAEEa8Q4ukl0WnfWsVYOeHzols 5W/G0lqqrSfEhNECPIFMBUr9eHOEqU5aT9CbQEkQxs9gp5K88+H/vZLs+XRjxQ9sN+sZ IvO5yUL2dcC8vSQ1ZiW2BQ/QCg/khbgA0yd2etuCT7we4n9ps+JceRyHaSeaisg6mnI1 xn5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Chp2n3ay18nBkST/OunfW2Lm53v//eawAShT7k/YG4U=; b=Hvz6Rcl6ha4UP8oon+9I+TIXO5VKIwP8/teExQugIZY5ma4Diuz50y3/Xv0ynWPEq9 U/XPx02NzU2kjQgKU6fHQofZ5i97cifsZfrKqdhmjBbCmRGSQ/kV30z2cWyUV+WBFPkz IpbTGUkJkssyGtc4vOuNXj05EgV08S6MYqMgOByHE/0L0Yc5xxk9+rd25Y0muoEDvAZu lURnTj7eYWDasXdtaeWQ1ELaTeV3T3nStzd4TV90yTcCjiuRE/B1ehSOe5FuR+XToA+t BR4yPSIxe4jPmCruNOekHZO5yRdLlHHk5aMx6i+wWzWFeujDtdp/WqS1kj+u+3L8MMWV r2Hw== X-Gm-Message-State: ANoB5pnsNCMdOOP6+mSNBrVNK0C2r29IeMYu5roEL6YupXwuBpARx9h0 CtQfBCFQi3ToQ+FP6oidCxo= X-Google-Smtp-Source: AA0mqf55KYChBAgv9EmwOTzjF3yLijN9xgZnVbMnD6Cc6AAuNXsai7LDzQ7bd5K6eiyGw8bQSnynJA== X-Received: by 2002:a17:907:a4c1:b0:7c0:a350:9d29 with SMTP id vq1-20020a170907a4c100b007c0a3509d29mr5367908ejc.18.1670597246415; Fri, 09 Dec 2022 06:47:26 -0800 (PST) Received: from skbuf ([188.27.185.190]) by smtp.gmail.com with ESMTPSA id 10-20020a170906308a00b007ad94fd48dfsm628951ejv.139.2022.12.09.06.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 06:47:25 -0800 (PST) Date: Fri, 9 Dec 2022 16:47:23 +0200 From: Vladimir Oltean To: Horatiu Vultur Cc: Michael Walle , Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, daniel.machon@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, lars.povlsen@microchip.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, richardcochran@gmail.com Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221209144723.qdbf2wr6vp2dmty7@skbuf> References: <20221208130444.xshazhpg4e2utvjs@soft-dev3-1> <20221209092904.asgka7zttvdtijub@soft-dev3-1> <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> <20221209125611.m5cp3depjigs7452@skbuf> <20221209142058.ww7aijhsr76y3h2t@soft-dev3-1> <20221209144328.m54ksmoeitmcjo5f@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221209144328.m54ksmoeitmcjo5f@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_064729_428857_139341DD X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 09, 2022 at 04:43:28PM +0200, Vladimir Oltean wrote: > On Fri, Dec 09, 2022 at 03:20:58PM +0100, Horatiu Vultur wrote: > > On ocelot, the vcap is enabled at port initialization, while on other > > platforms(lan966x and sparx5) you have the option to enable or disable. > > Even if that wasn't the case, I'd still consider enabling/disabling VCAP > lookups privately in the ocelot driver when there are non-tc users of > traps, instead of requiring users to do anything with tc. It's simply > too unfriendly for somebody who just wants PTP. You can use devlink > traps to show which non-tc traps are active. To put it differently. Why do you even bother to make the driver auto-install PTP traps, and not let the user do that? It's the same argument as asking the user enable the VCAP lookups. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel