From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B3E0C4332F for ; Fri, 9 Dec 2022 14:50:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7T2jeilox8vDjC/a3AbNEwjxrprVkGGcWhjiNahcwxs=; b=hduFtTSqmQg/Zx a0uvLRQiwGX19bQnL3UbCWjyIIyclCy7Ld0RFV+Oz3qC8HCrNrnuXvH1xmUFQaV6/ENnCDtIH30Ep oFbCF5n8RNvxrATYFJdqXNTRwRIAD+5DaMTJQgFD9IQtg+o16TAbHXy+7vW4QNvBENYUWwb9dmx+l 0zal/Dczg7mIUH9r6+6Hy5Ox55+hf9/AuWS0ci/b579L3N17xo8rVtpgFrH7YGTwkD4+QVKQDBiXb YhUUIiGE7RMuOvdW0jKy9ajvf244fScU0F2T8yzoRWYpDCn9gNurQ4DBqrvqPK/YKw++X8CshOTj0 j61gun/OM9BCKSpwYxUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3eh4-008c8F-HA; Fri, 09 Dec 2022 14:49:42 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3egy-008c5J-Cq for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 14:49:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670597377; x=1702133377; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YUXAzZaiIHP+TeJDcIUQIh8idIpiiNMmvl01maD+8eY=; b=uNcdIcJJLxItudi3dnyWHYnVcCpxw45Wcu5ae8fyBUz/yfgX6JvUiuSv sWdQDPvBOf7kJCinAefTO1lrs2yIZIYFK03HxkcKc6H58lMVBf48EkXrM YcpSdJWHicbhY/CiWAO/nJYPsoC6ej/k1/i0J7K+3ov1b7f5KH6nzXFjo kfUdaA10+L5fDg73TObQ5QVSAfX323LBZmzq2Cqrwktp2fBARNc1+kXkR pttaMH5rCRqkuQqfRYXavuggMVQ4OG2DZyxbEHiLvbBCmIrpeH/ODOZLr 0yeT8G6mC73UVR7lguA0LhKp4Q7/Kt0nQqqle3/Ll8ULnavzPdH3g4dvr g==; X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="187394902" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Dec 2022 07:49:35 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 9 Dec 2022 07:49:29 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 9 Dec 2022 07:49:29 -0700 Date: Fri, 9 Dec 2022 15:54:36 +0100 From: Horatiu Vultur To: Michael Walle CC: Vladimir Oltean , , , , , , , , , , , , Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221209145436.o5nclzrtu2eztvzs@soft-dev3-1> References: <20221208130444.xshazhpg4e2utvjs@soft-dev3-1> <20221209092904.asgka7zttvdtijub@soft-dev3-1> <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> <20221209125611.m5cp3depjigs7452@skbuf> <20221209142058.ww7aijhsr76y3h2t@soft-dev3-1> <287d650a96aaac34ac2f31c6735a9ecc@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <287d650a96aaac34ac2f31c6735a9ecc@walle.cc> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_064936_544766_C47D0259 X-CRM114-Status: GOOD ( 26.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 12/09/2022 15:23, Michael Walle wrote: > > Am 2022-12-09 15:20, schrieb Horatiu Vultur: > > The 12/09/2022 15:05, Michael Walle wrote: > > > > > > Am 2022-12-09 13:56, schrieb Vladimir Oltean: > > > > On Fri, Dec 09, 2022 at 01:58:57PM +0100, Horatiu Vultur wrote: > > > > > > Does it also work out of the box with the following patch if > > > > > > the interface is part of a bridge or do you still have to do > > > > > > the tc magic from above? > > > > > > > > > > You will still need to enable the TCAM using the tc command to have it > > > > > working when the interface is part of the bridge. > > > > > > > > FWIW, with ocelot (same VCAP mechanism), PTP traps work out of the box, > > > > no need to use tc. Same goes for ocelot-8021q, which also uses the > > > > VCAP. > > > > I wouldn't consider forcing the user to add any tc command in order for > > > > packet timestamping to work properly. > > > > On ocelot, the vcap is enabled at port initialization, while on other > > platforms(lan966x and sparx5) you have the option to enable or disable. > > > > > > > > +1 > > > Esp. because there is no warning. I.e. I tried this patch while > > > the interface was added on a bridge and there was no error > > > whatsoever. > > > > What error/warning were you expecting to see here? > > Scrap that. ptp4l is reporting an error in case the device is part > of a bridge: > Jan 1 02:33:04 buildroot user.info syslog: [9184.261] driver rejected > most general HWTSTAMP filter > > Nevertheless, from a users POV I'd just expect it to work. How > would I know what I need to do here? What about a warning in the driver? Say that the vcap needs to be enabled. > > -michael -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel