From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E59F5C4332F for ; Fri, 9 Dec 2022 23:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B+LmGLmvZVLarJtzRGlvrfQ8xe+kPt9X0M29zOokTGA=; b=Rr4cqvG1GNBFaZ 5bT7lkQiSFnHd1NBGbPQT+wvhfAP7wTiPdITcY96aCieakZ7XL+vuGxuOOfvOCnnYi0l0fXhIWHud rhTLSNYPbwkr7aT0t1W87E6Yz8KYe6xXnzcS3O+Lmnx2vcbCu2x8VJgPkhfi2ECmEUYjXmuuQPSyf Y60Z92I7m5xxPByNHhwDoOlVNdnLOHcz3SF+M0UY7fy48qqDe5CiKTaDLezKjybjU/QV/D6ufNEkF yDYAQbu5YEmxSV4HdrkzvrF+bxxg9NKdl5cyITKTC0YUQ/0clKV+Dek8zzkMnRJmfN/+3q2lZmcqP HfyiQ5+liSdpp9wGQlJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3mP7-00C9Xo-HT; Fri, 09 Dec 2022 23:03:41 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3mP4-00C9Sy-I9 for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 23:03:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8FE276238C; Fri, 9 Dec 2022 23:03:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CFD4C433D2; Fri, 9 Dec 2022 23:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670627014; bh=X20+rEzXX4vJaITSaB0VZ8/lv7GD334QlS1f0YhMrgQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aV3gyebBifBlO+/ivgJmIeWcGoyged7eKgF2sgv/BMsJk3fFYL6aIInfw1YHYnN1x V/P0zb+mUJ2CXAc1f8FZtvdiLdHd8FnXx0l1hjJDPCLbB5qGBRq1Lesa3YjWeTMbl7 BxzEVq36MKPG1VBI2cBSx0TPDKl1tmq/oFbvQaAb+fiw312zPZdF94J0+VjD6ctWhg VcobJUa/yv81KP2kHadlzhArWLb7dTI0wVuDcbLcrvEQawvcDy1XTtw4pLxIO9BwjF YGHE5AnRLKRhZu8mNM3vucXpxLqmG/mYp2B3QLlGXzE4gy5vc+TasPPQgl1OB1LWzJ UAkfnhg6KTooA== Date: Fri, 9 Dec 2022 15:03:32 -0800 From: Jakub Kicinski To: Vladimir Oltean Cc: Horatiu Vultur , Michael Walle , Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com, daniel.machon@microchip.com, davem@davemloft.net, edumazet@google.com, lars.povlsen@microchip.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, richardcochran@gmail.com Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221209150332.79a921fd@kernel.org> In-Reply-To: <20221209152713.qmbnovdookrmzvkx@skbuf> References: <20221209092904.asgka7zttvdtijub@soft-dev3-1> <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> <20221209125611.m5cp3depjigs7452@skbuf> <20221209142058.ww7aijhsr76y3h2t@soft-dev3-1> <20221209144328.m54ksmoeitmcjo5f@skbuf> <20221209145720.ahjmercylzqo5tla@soft-dev3-1> <20221209145637.nr6favnsofmwo45s@skbuf> <20221209153010.f4r577ilnlein77e@soft-dev3-1> <20221209152713.qmbnovdookrmzvkx@skbuf> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_150338_662071_18F11203 X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 9 Dec 2022 17:27:13 +0200 Vladimir Oltean wrote: > > So for example, on a fresh started lan966x the user will add the following > > rule: > > tc filter add dev eth0 ingress chain 8000000 prio 1 handle 1 protocol > > all flower skip_sw dst_mac 00:11:22:33:44:55/ff:ff:ff:ff:ff:ff action > > trap action goto chain 8100000 > > > > He expects this rule not to be hit as there is no rule in chain 0. Now if > > PTP is started and it would enable vcap, then suddenly this rule may be > > hit. > > Is it too restrictive to only allow adding offloaded filters to a chain > that has a valid goto towards it, coming (perhaps indirectly) from chain 0? Right, we fumbled the review and let the chain oddness in. Until recently the driver worked without any rules in chain 0 :( Maybe adding and offload of the rules can be separated? Only actually add the rules to the HW once the goto chain rule has been added? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel