From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16E27C3DA71 for ; Fri, 9 Dec 2022 15:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q09dORDSr6EWhxle/BvBInEf410Omp6uhMPHa278w30=; b=ydrDUUNhaUAewp LOK4B4YxXDBfQGI6JUkwr3MdM6esxhasf/H2fygT5ilFTCs6yNZi8Bv9DDCQJztvfTpQAUKlHsk2j jQkygUeDQkbFGdrHST4ql+x68puhGY5ZNSHEnpq0UyO83BI8neP11LAbEgdJxbQW3xDPfVVPokpjB oKvd+2ioU8oWoRZyuonIlzEXqCrEAl90jGR2rAxdT5f0LHphSSkR4ne7COw95E66RRSX3yIdoftQG dGwOAG/9UqOLK8i7KG0y+UHa+JU5BvbEeXIrl4U1hhSyTI2r53d69BaHe/xzSO+O6xevdxCqYn1xh ub9ys0FFUnNoNbTDa2dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3fGL-008yLP-8T; Fri, 09 Dec 2022 15:26:09 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3fFM-008xuX-K0 for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 15:25:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670599508; x=1702135508; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WmwpTYyxcVQtiW1tL9fJMr4BDXHV7YEW8emRKA6pCLM=; b=LDx1wYyGsgYl3m9w78BFcg4OeW0cFo2Pnms9ZdKmhpFqxQd4d0Kuoo9j DCAYTLDuCEfIGR9b0R/T36nwxSS0yjMmmfnDd1hMbuUkRSSp+84YslEQ1 RxzTF3nJasHHH7GZrfAzL2RvPeoflS2ArVUJcIjgqbrn7tqZDUpKzuOyf LgMMxHhdH7PbP0zfuZMB8qEdvgbTtbL9Ap0rKwVE0k1Qi2ySop6oM3zKx a3sHBQFKSM57ghnCxfhYazTEYQERGPdC/eNB+NCW9tYbdV01Kxdmcj67P zc0rjOCQcTTiojktFl4Cn27ST/iiY1XLOWPBp5jbJ6cq2hB2FAS+S5Gu9 w==; X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="190905714" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Dec 2022 08:25:03 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 9 Dec 2022 08:25:02 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 9 Dec 2022 08:25:02 -0700 Date: Fri, 9 Dec 2022 16:30:10 +0100 From: Horatiu Vultur To: Vladimir Oltean CC: Michael Walle , , , , , , , , , , , , Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221209153010.f4r577ilnlein77e@soft-dev3-1> References: <20221209092904.asgka7zttvdtijub@soft-dev3-1> <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> <20221209125611.m5cp3depjigs7452@skbuf> <20221209142058.ww7aijhsr76y3h2t@soft-dev3-1> <20221209144328.m54ksmoeitmcjo5f@skbuf> <20221209145720.ahjmercylzqo5tla@soft-dev3-1> <20221209145637.nr6favnsofmwo45s@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221209145637.nr6favnsofmwo45s@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_072508_835178_E5F9A293 X-CRM114-Status: GOOD ( 21.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 12/09/2022 16:56, Vladimir Oltean wrote: > > On Fri, Dec 09, 2022 at 03:57:20PM +0100, Horatiu Vultur wrote: > > The 12/09/2022 16:43, Vladimir Oltean wrote: > > > > > > On Fri, Dec 09, 2022 at 03:20:58PM +0100, Horatiu Vultur wrote: > > > > On ocelot, the vcap is enabled at port initialization, while on other > > > > platforms(lan966x and sparx5) you have the option to enable or disable. > > > > > > Even if that wasn't the case, I'd still consider enabling/disabling VCAP > > > lookups privately in the ocelot driver when there are non-tc users of > > > traps, instead of requiring users to do anything with tc. > > > > I was thinking also about this, such the ptp to enable the VCAP > > privately. But then the issue would be if a user adds entries using tc > > and then start ptp, then suddently the rules that were added using tc > > could be hit. That is the reason why expected the user to enable the > > tcam manually. > > I don't understand, tc rules which do what? Why would those rules only > be hit after PTP is enabled and not before? Because you have not enabled the vcap. For example this rule: tc filter add dev eth0 ingress chain 8000000 prio 1 handle 1 protocol all flower skip_sw dst_mac 00:11:22:33:44:55/ff:ff:ff:ff:ff:ff action trap action goto chain 8100000 This will not be hit until you add this rule: tc filter add dev eth0 ingress prio 1 handle 2 matchall skip_sw action goto chain 8000000 Because this rule will enable the HW. Just to aligned to a SW implementation of the tc, we don't enable the vcap until there is a rule in chain 0 that has an action to go to chain 8000000 were it resides IS2 rules. So for example, on a fresh started lan966x the user will add the following rule: tc filter add dev eth0 ingress chain 8000000 prio 1 handle 1 protocol all flower skip_sw dst_mac 00:11:22:33:44:55/ff:ff:ff:ff:ff:ff action trap action goto chain 8100000 He expects this rule not to be hit as there is no rule in chain 0. Now if PTP is started and it would enable vcap, then suddenly this rule may be hit. I hope this helps a little bit. -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel