From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CF96C4332F for ; Mon, 12 Dec 2022 21:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cbxXaa5ifX1JUkVS74ygW3wGfHAIclA+4T6odJXDFiQ=; b=JekuNs1HB0HlmA VpKzV3RdwMIOU4gsum8dUXo8JBTEBPBxZGQkvDGfqrqJTM40qhwx+ET3Zg/zk/HE3VKL4ekHXQTkh x5/i3yvFdCFUPa3KR8brKJoujp8OcqK3JzCVSGSLSPJF8xw77TbWu91zXTpECYqiXGGkQYuahTkH8 oqawUB5xKQp/OrjJawDNZQ1Kc8ieOcWPbv5oEYtBHxOWu2OHM31VdTjcr6bmdvlDiqasRa+0oKPEO X9sV6DBUaczmbu5eDglnhOyWx6ZhI2MEEiMS9NaPkJpNiOiNfJFep0iv8MAHtMzq4GTeJ5IqJlRwp splOdVJWyzrdBAsN0E8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4pwZ-005TRL-Ft; Mon, 12 Dec 2022 21:02:35 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4pwW-005THr-Q7 for linux-arm-kernel@lists.infradead.org; Mon, 12 Dec 2022 21:02:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 3DD45CE1133; Mon, 12 Dec 2022 21:02:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1D7CC433D2; Mon, 12 Dec 2022 21:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670878945; bh=UYWCrX2SdeaGdrjephxWJSz8hd3vseMdWBi7qv9hc+c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hUN2PuvqGhiX1804SHPtWkR41XtzZ52cTWV+5ALL1jp2YMmvhQqwLW5uwI2uygFtT 4ATgsyhvJpUt1sce6VRMoOZ5nWFlxN/J4VHy43CDxOweWEyjShth8YYgpCs4+2NsVq 1NMtiUsEy8KYbAMVN12ZccuraMkTPiRnpcAqObDtrB0WvcDF128N6+kUxJSGc0iLkV dkQ0k39cJG9uHzURV4AyyCH4iBsRo+uw2CdtOy92iK5/XZpFTO4V2K6Wa6Jwosgomo LQyv4NnmxMHISkDF5Aw2qKX0I3HZrmFEmcqcACuFq+gvHkRFwNzhWUVyjze5B+bdiM aPlhoLdSoovhw== Date: Mon, 12 Dec 2022 13:02:24 -0800 From: Jakub Kicinski To: Horatiu Vultur Cc: , , , , , , , , , , kernel test robot , "Dan Carpenter" Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask Message-ID: <20221212130224.19bf695f@kernel.org> In-Reply-To: <20221209120701.218937-1-horatiu.vultur@microchip.com> References: <20221209120701.218937-1-horatiu.vultur@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_130233_040992_17B681C9 X-CRM114-Status: UNSURE ( 8.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote: > case VCAP_FIELD_U128: > + value = data->u128.value; > + mask = data->u128.value; If setting both to value is intentional - please mention in the commit message. Otherwise this looks odd. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel