From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C33AAC4332F for ; Mon, 12 Dec 2022 14:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=73mQaHdrai8oVYIACle3HzdWPA8+Ecf0CLfRB+Jlxgs=; b=EOj/FJfsnWEA1l eWZzcKnfBKcwgv8GNUGIGpbo4ajXPpLTIe/00D0lj+RGejXQSfpROd4UnJrqEYyxWwS7aQxuWHTSG RUXPaCxYpEZqP/hKt9NtUcQ4+r1qPlS0FBo0nUL6CtuNoezyi4DQsnevLmiVWkEJMrKHHh6Iq5mMs 1ak3sCZ61nxWzkLFjmQrsN6deggIat3w4H3sl/irZzSrSCtRPAPEpNksBUuZ7Rr8mW/2AXuwXiMhk L6pLG0C8z2I5bYixmn6GWTAbbZ5B1Bq2Fouo96dc7Lh2dQtbGagjmx2xtJ/m+6+066lCP1VpVveLE xl+te7FFA+yJXI15rMoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4jhC-00HIru-EL; Mon, 12 Dec 2022 14:22:18 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4jh5-00HIir-6r for linux-arm-kernel@lists.infradead.org; Mon, 12 Dec 2022 14:22:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670854930; x=1702390930; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7a2DuvLenxyuI7AqD6mHvsidXY3Z0leJSqLMjOih4cw=; b=En1v1FwPebMTowkGRCleVpQ2kON3dz1QaAkqZ0HLJbYn40rwHkiIDZ/W 9+r76Loq0ddgcpQLXqjQ5YKwgJwE2wQqb3XXid9tqJIA5kwtmmIdID48U 2XYTg1ZtiCOWO2jBK6BinIfH014WoYMCxg3xiCaQKdB0mcDB26n9Tqaj1 qoy/4oR3J49HPuFbx8iob7LA8DrRTGRGSKdMu6ogqdrViJjIPflRmpTMJ JqdH0xfO6G7dxQq+cDzyu9Db+k9JiS/f8flKMn4dadNAs83K8IS1fLZ6A mPJIx0xYm6Q20CVcS6cvTYMOUR3VIh93XMOlndRArC03M2wv+CHdCF2FK w==; X-IronPort-AV: E=Sophos;i="5.96,238,1665471600"; d="scan'208";a="191236976" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 12 Dec 2022 07:22:07 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 12 Dec 2022 07:22:04 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Mon, 12 Dec 2022 07:22:04 -0700 Date: Mon, 12 Dec 2022 15:27:12 +0100 From: Horatiu Vultur To: Jakub Kicinski CC: Vladimir Oltean , Michael Walle , , , , , , , , , , , Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221212142712.majhp4yifg72y3b2@soft-dev3-1> References: <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> <20221209125611.m5cp3depjigs7452@skbuf> <20221209142058.ww7aijhsr76y3h2t@soft-dev3-1> <20221209144328.m54ksmoeitmcjo5f@skbuf> <20221209145720.ahjmercylzqo5tla@soft-dev3-1> <20221209145637.nr6favnsofmwo45s@skbuf> <20221209153010.f4r577ilnlein77e@soft-dev3-1> <20221209152713.qmbnovdookrmzvkx@skbuf> <20221209150332.79a921fd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221209150332.79a921fd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_062211_337062_E4FE03D6 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 12/09/2022 15:03, Jakub Kicinski wrote: > > On Fri, 9 Dec 2022 17:27:13 +0200 Vladimir Oltean wrote: > > > So for example, on a fresh started lan966x the user will add the following > > > rule: > > > tc filter add dev eth0 ingress chain 8000000 prio 1 handle 1 protocol > > > all flower skip_sw dst_mac 00:11:22:33:44:55/ff:ff:ff:ff:ff:ff action > > > trap action goto chain 8100000 > > > > > > He expects this rule not to be hit as there is no rule in chain 0. Now if > > > PTP is started and it would enable vcap, then suddenly this rule may be > > > hit. > > > > Is it too restrictive to only allow adding offloaded filters to a chain > > that has a valid goto towards it, coming (perhaps indirectly) from chain 0? > > Right, we fumbled the review and let the chain oddness in. > Until recently the driver worked without any rules in chain 0 :( > > Maybe adding and offload of the rules can be separated? > Only actually add the rules to the HW once the goto chain rule > has been added? Yes, we would like to do something like this. -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel