From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32B11C4332F for ; Tue, 13 Dec 2022 07:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x4ebVyOr0AkBMWXzXI/T+j40B84loGWKulh87KBJRbY=; b=y0ageEvcgYgKg2 osfIWZ5FIYm93waXa3cpvk82LjvBhdU2gWfKjX1xTK/Xri301UZHQm4Ehoorx8r0JSSYvBugA2kEp TexRIjNtpTallsB4oOFL8A3kOjdOrzrbCsaA601Ffia9KlmQn+y4VVetNl1wua4LqBWidsBohK+jB PMueXIp61qxAbL7MSt3EyQurJSyKVvcfsS50YcekxQQagplrboT0FJiyT5vRcddiexDIBgJk1YVRL 75hFG15xK6FmuzikRkMjS/o4w8VDHS2q2RErT87s0UKL8h40XgVi9V6hOsuVbqm2IgzUDHH9xPqRX ifiSNZqeL/l12a5nhs2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4zkT-00CIXI-1E; Tue, 13 Dec 2022 07:30:45 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4zkP-00CIFV-8b for linux-arm-kernel@lists.infradead.org; Tue, 13 Dec 2022 07:30:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670916641; x=1702452641; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=T/4fTI8XAOxsvA34xrnPsv9rjRhIMMEqFu1gCstvong=; b=uKs2mP5VW1wLEMtETwhfIQa+LlB3qGQgmmwr5HcEK6waMXldnAW/N7zv 5GmHMOvU300ffdJM64/k7tpDYgTS9G50FxmzJuk7xTVnF4cLs0Rg03wLi pERWC/vVmMC0sPWOyHh0cqmMZqwDvyeA8iqX+4OHKn9RW5kOcl+rmj30a Md458UJ3aZNngy0b9zmKngzJFfDDKAfkR3QZkaFN4n+qQCVWO/azZlUlb kNGLecHtMQaqxlqEvxhaGiByUfzVJv23WlG2leA3TdlL1BsAm+HDyF9zG 2VgXoJwHXAHQSNE2a37in0VzbxK6ZquZdh+8YLiQTKqAcPXcLV/+7wEAB g==; X-IronPort-AV: E=Sophos;i="5.96,240,1665471600"; d="scan'208";a="192833257" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2022 00:30:37 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 13 Dec 2022 00:30:37 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 13 Dec 2022 00:30:36 -0700 Date: Tue, 13 Dec 2022 08:35:45 +0100 From: Horatiu Vultur To: Jakub Kicinski CC: , , , , , , , , , , kernel test robot , "Dan Carpenter" Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask Message-ID: <20221213073545.vuel5l6k7cej6xk6@soft-dev3-1> References: <20221209120701.218937-1-horatiu.vultur@microchip.com> <20221212130224.19bf695f@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221212130224.19bf695f@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221212_233041_372061_E34F2AF5 X-CRM114-Status: UNSURE ( 8.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 12/12/2022 13:02, Jakub Kicinski wrote: > > On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote: > > case VCAP_FIELD_U128: > > + value = data->u128.value; > > + mask = data->u128.value; > > If setting both to value is intentional - please mention in the commit > message. Otherwise this looks odd. It should not be both set to value. Will fix this in th next version. -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel