From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A307AC4332F for ; Wed, 14 Dec 2022 03:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5T1ophB0LWKL1PCDWWunyovF/CZ1inp6MRk04033Z2s=; b=J7Tuzmy9NY8bZH 6dwb7/YMJ4i5nLg48AH7u4Sc6uE+AB527LTOp4dSV+m+jaFkUFmKnLJJyVZ5ADHmsRZ0cJQG/+BmY t+/PDNBKgQO7nU45Y1w2hhB91/8YQRh0D8mDc8G7MNiTnuv2BBzH0ZqyvcQ8IPwhhWHTlSkCdMh0E dWH9FCGmlxIDl0a8A/WReukVldsoLwMP168LMWscp3tVETogFy6k1ldYhOTPAzIUIS/VdHxQaSs9B 7W7qO1hYoResTrVRnGhFzfRHhU0zT1er8ZimJgOFJJwOSfuR9lgr0aUDHYTMItkptBuVUu/zEHacG Y3Wjue+V6xc9SLRGnjIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5IF5-00B6nN-Dt; Wed, 14 Dec 2022 03:15:35 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5IF2-00B6mh-Q6 for linux-arm-kernel@lists.infradead.org; Wed, 14 Dec 2022 03:15:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 41E67B8163C; Wed, 14 Dec 2022 03:15:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 402FEC433EF; Wed, 14 Dec 2022 03:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670987729; bh=PxLV5VwlxVtw6OSZ3KLbpL+I2EUP7MmcuVvbdO5REos=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kYLU8v4v8oQl7rgdZ3v3RZ13tietFegOmUmqs1Fba9KE/OQ/xmecI6SET3pqarcf/ +RKHemMxsHDzK+s/AEvow7X2zFvOtfvAjmrl8LsXin+geblRhdWQ1x+FOx0Z49Vhlf QrxN0r+FAdVzfTphl7ULiAQrTHA5LZmNQ1b7k74D9NZ7hxV59PXSdxfK9NbGNFJK7e bU7QbMF5uwdlf07GWwr8rbf1tNsX0SaX0nluCyh5bDDzLsH1loT7ei2GwKnWd1uyhu RznF0zh48bYRD0a3xBIDMG5rO7R5NRCM7qONJ9UDEskqsI93rq4cwMmEp4GEt9vFSf 1V3ItX82k+KVQ== Date: Tue, 13 Dec 2022 19:15:28 -0800 From: Jakub Kicinski To: Gaosheng Cui Cc: , , , , , , , , , , , , , , Subject: Re: [PATCH v2] net: stmmac: fix possible memory leak in stmmac_dvr_probe() Message-ID: <20221213191528.75cd2ff0@kernel.org> In-Reply-To: <20221212021350.3066631-1-cuigaosheng1@huawei.com> References: <20221212021350.3066631-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221213_191533_022512_2F7323E6 X-CRM114-Status: UNSURE ( 9.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Dec 2022 10:13:50 +0800 Gaosheng Cui wrote: > The bitmap_free() should be called to free priv->af_xdp_zc_qps > when create_singlethread_workqueue() fails, otherwise there will > be a memory leak, so we add the err path error_wq_init to fix it. > > Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy") > Signed-off-by: Gaosheng Cui The previous version has already been applied and we can't remove it. Could you send an incremental change to just add the errno? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel