From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0253BC4167B for ; Wed, 14 Dec 2022 16:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WIDglx3ZY+3ZSsvzwcgkj+S1iagmbKRpgJPYD+Kfx8o=; b=RSEi3bmM4Asr+m JIbrwMI2ZaOiK2VxCd4jdV7ZmIiQZIK3HXOzjmGK+AjkcmuwQFgOBBfOzjejgdRt/UsKjJyjpWYp6 W7xIdcJnqS9bocvQi+Bf6S2UK7+0N07lxMvAvQLqUR8fd1FNdjT7NgZjLv49fe/MN/Xsh86nlwpBU DQY36oEdz6D0XeaDIWnZOd0y3TjhfzK6QOzdiJr76x4z+d0j9QahJFVci4Ec9OgiZzagEgq08rZ1n 9LLJBiWiO+ilcVxprCe2N6OpI3VhDtl8QbyxWXYN3YtoAHCvtmwQ6NU53p2qEvGmziPkzuz5Sf01W lFYgW+YarYTWfzNmvnew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5UlH-000hlE-7y; Wed, 14 Dec 2022 16:37:39 +0000 Received: from mail-oa1-f42.google.com ([209.85.160.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5UlD-000hgA-86 for linux-arm-kernel@lists.infradead.org; Wed, 14 Dec 2022 16:37:37 +0000 Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-144b21f5e5fso17263163fac.12 for ; Wed, 14 Dec 2022 08:37:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mX4cE3qhh3kTKeX4sLL8Id44ukdMZ3awZY70XaXwpFs=; b=Ce7ZqHmWhwGUibWAWzOjOHuy/goAjgQrJBqacUjxWUIlWaSOr/64fkCE/oHYG7JW7r jfVc3UHAk5x36IkmyOAme8q3Do9IRHW5tQu6olwaxYTVixZzr7Q2RMlrnC+wtgmQ7Qaa J0jtZxXY+PlwWgaozk0J0vXQ5jji0ch/FZiyYTaNAahbOeuCAdpSP0yYldDYHhFetq+Y ZIW16CwhVseAgS7soJOCuUscKhxSjjsCaD98qqdIJUxJ4czaprZ5KrNJDgQBB3R+rEXF 4hiwpFrCSoWKbGgbn2ISaZ/xcjShvIoNhHScApRKETYAaXIHU+ffW+T5uKp2heN558jx gDpA== X-Gm-Message-State: ANoB5pmuywOX0F1MhXvWUd6X/eyFPrfPY/e797Mb6H+pVEeZ17mfundj LzQ4UgoNNp3IJ05qJLiHwECTKGcgAw== X-Google-Smtp-Source: AA0mqf6fUFfNhCc+kvfrGEZbQZ56+/Ui/2BYPoGSMhlbExUzQBb+Es1PIUiVv/s2+9tegxOLP2mY3w== X-Received: by 2002:a05:6870:6982:b0:143:89ce:80ee with SMTP id my2-20020a056870698200b0014389ce80eemr11679785oab.20.1671035851663; Wed, 14 Dec 2022 08:37:31 -0800 (PST) Received: from robh_at_kernel.org (rrcs-98-6-157-194.sw.biz.rr.com. [98.6.157.194]) by smtp.gmail.com with ESMTPSA id o193-20020a4a2cca000000b0049ef7f3b2c8sm2389826ooo.48.2022.12.14.08.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 08:37:31 -0800 (PST) Received: (nullmailer pid 1192000 invoked by uid 1000); Wed, 14 Dec 2022 16:37:29 -0000 Date: Wed, 14 Dec 2022 10:37:29 -0600 From: Rob Herring To: Emekcan Aras Cc: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] arm64: dts: Add Arm corstone500 platform support Message-ID: <20221214163729.GA1181413-robh@kernel.org> References: <20221214132404.439882-1-emekcan.aras@arm.com> <20221214132404.439882-2-emekcan.aras@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221214132404.439882-2-emekcan.aras@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221214_083735_316683_691184B6 X-CRM114-Status: GOOD ( 22.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 14, 2022 at 01:24:03PM +0000, Emekcan Aras wrote: > From: Emekcan Aras > > Corstone500[0] is a platform from arm, which includes Cortex-A cores and > ideal starting point for feature rich System on Chip (SoC) designs > based on the Cortex-A5 core. > > These device trees contains the necessary bits to support the > Corstone 500 FVP (Fixed Virtual Platform) and the > FPGA MPS3 board. > > 0: https://developer.arm.com/documentation/102262/0000 > > Signed-off-by: Emekcan Aras > --- > arch/arm/boot/dts/corstone500.dts | 181 ++++++++++++++++++++++++++++++ > 1 file changed, 181 insertions(+) > create mode 100644 arch/arm/boot/dts/corstone500.dts > > diff --git a/arch/arm/boot/dts/corstone500.dts b/arch/arm/boot/dts/corstone500.dts > new file mode 100644 > index 000000000000..976aa333ffbc > --- /dev/null > +++ b/arch/arm/boot/dts/corstone500.dts > @@ -0,0 +1,181 @@ > +// SPDX-License-Identifier: GPL-2.0 or MIT > +/* > + * Copyright (c) 2022, Arm Limited. All rights reserved. > + * > + */ > + > + > +#include > + > +/ { > + model = "ARM Corstone500"; > + compatible = "arm,corstone500"; > + interrupt-parent = <&gic>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + aliases { > + serial0 = &uart0; > + serial1 = &uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + psci { > + compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci"; You really need to be compatible with all these PSCI versions? 'arm,psci' means you have the function IDs in DT before they were standardized (in 2013 IIRC). You need to support OS's from that time? > + method = "smc"; > + cpu_on = <0x84000003>; And here is one, but the rest? Really, it should be dropped along with 'arm,psci'. > + }; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + enable-method = "psci"; > + > + cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a5"; > + reg = <0>; > + next-level-cache = <&L2>; > + }; > + > + cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a5"; > + reg = <1>; > + next-level-cache = <&L2>; > + }; > + > + cpu@2 { > + device_type = "cpu"; > + compatible = "arm,cortex-a5"; > + reg = <2>; > + next-level-cache = <&L2>; > + }; > + > + cpu@3 { > + device_type = "cpu"; > + compatible = "arm,cortex-a5"; > + reg = <3>; > + next-level-cache = <&L2>; > + }; > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x7f000000>; > + }; > + > + L2: cache-controller@1c010000 { > + compatible = "arm,pl310-cache"; > + reg = <0x1c010000 0x1000>; > + interrupts = ; > + cache-level = <2>; > + cache-unified; > + arm,data-latency = <1 1 1>; > + arm,tag-latency = <1 1 1>; > + }; > + > + refclk7500khz: refclk7500khz { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <7500000>; > + clock-output-names = "apb_pclk"; > + }; > + > + refclk24mhz: refclk24mhz { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <24000000>; > + clock-output-names = "apb_pclk"; > + }; > + > + smbclk: refclk24mhzx2 { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <48000000>; > + clock-output-names = "smclk"; > + }; > + > + rtc@1a220000 { Why is this one not under 'soc'. Really, all MMIO nodes should be. > + compatible = "arm,pl031", "arm,primecell"; > + reg = <0x1a220000 0x1000>; > + clocks = <&refclk24mhz>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + clock-names = "apb_pclk"; > + }; > + > + gic: interrupt-controller@1c001000 { > + compatible = "arm,cortex-a5-gic"; > + #interrupt-cells = <3>; > + #address-cells = <0>; > + interrupt-controller; > + reg = <0x1c001000 0x1000>, > + <0x1c000100 0x100>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + }; > + > + soc{ > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + clock_frequency = <50000000>; > + interrupt-parent = <&gic>; > + ranges; > + > + uart0: serial@1a200000 { > + compatible = "arm,pl011", "arm,primecell"; > + reg = <0x1a200000 0x1000>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + clocks = <&refclk7500khz>; > + clock-names = "apb_pclk"; > + }; > + > + uart1: serial@1a210000 { > + compatible = "arm,pl011", "arm,primecell"; > + reg = <0x1a210000 0x1000>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + clocks = <&refclk7500khz>; > + clock-names = "apb_pclk"; > + }; > + > + timer0: timer@1a040000 { > + compatible = "arm,armv7-timer-mem"; > + reg = <0x1a040000 0x1000>; > + clock-frequency = <7500000>; > + > + frame@1a050000 { > + frame-number = <0>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + reg = <0x1a050000 0x1000>; > + }; > + }; > + > + smsc: ethernet@4020000 { > + compatible = "smsc,lan9220", "smsc,lan9115"; > + reg = <0x40200000 0x10000>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + reg-io-width = <4>; > + phy-mode = "mii"; > + smsc,irq-active-high; > + vdd33a-supply = <&v2m_fixed_3v3>; > + vddvario-supply = <&v2m_fixed_3v3>; > + }; > + }; > + > + v2m_fixed_3v3: fixed-regulator-0 { > + compatible = "regulator-fixed"; > + regulator-name = "3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > +}; > -- > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel