* [PATCH] cpufreq: apple: remove duplicate intializer
@ 2022-12-15 16:55 Arnd Bergmann
2022-12-15 17:10 ` Eric Curtin
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2022-12-15 16:55 UTC (permalink / raw)
To: Hector Martin, Sven Peter, Rafael J. Wysocki, Viresh Kumar
Cc: Arnd Bergmann, Alyssa Rosenzweig, Marc Zyngier, asahi,
linux-arm-kernel, linux-pm, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When -Woverride-init is enabled, gcc notices that the .attr
field is initialized twice:
drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
331 | .attr = apple_soc_cpufreq_hw_attr,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
Remove the first one, since this is not actually used.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/cpufreq/apple-soc-cpufreq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c
index d1801281cdd9..6f26395184c4 100644
--- a/drivers/cpufreq/apple-soc-cpufreq.c
+++ b/drivers/cpufreq/apple-soc-cpufreq.c
@@ -321,7 +321,6 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = {
.flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV,
.verify = cpufreq_generic_frequency_table_verify,
- .attr = cpufreq_generic_attr,
.get = apple_soc_cpufreq_get_rate,
.init = apple_soc_cpufreq_init,
.exit = apple_soc_cpufreq_exit,
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: apple: remove duplicate intializer
2022-12-15 16:55 [PATCH] cpufreq: apple: remove duplicate intializer Arnd Bergmann
@ 2022-12-15 17:10 ` Eric Curtin
2022-12-16 4:55 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Eric Curtin @ 2022-12-15 17:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Hector Martin, Sven Peter, Rafael J. Wysocki, Viresh Kumar,
Arnd Bergmann, Alyssa Rosenzweig, Marc Zyngier, asahi,
linux-arm-kernel, linux-pm, linux-kernel
On Thu, 15 Dec 2022 at 17:05, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When -Woverride-init is enabled, gcc notices that the .attr
> field is initialized twice:
>
> drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
> 331 | .attr = apple_soc_cpufreq_hw_attr,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Remove the first one, since this is not actually used.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Eric Curtin <ecurtin@redhat.com>
> ---
> drivers/cpufreq/apple-soc-cpufreq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c
> index d1801281cdd9..6f26395184c4 100644
> --- a/drivers/cpufreq/apple-soc-cpufreq.c
> +++ b/drivers/cpufreq/apple-soc-cpufreq.c
> @@ -321,7 +321,6 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = {
> .flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
> CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV,
> .verify = cpufreq_generic_frequency_table_verify,
> - .attr = cpufreq_generic_attr,
> .get = apple_soc_cpufreq_get_rate,
> .init = apple_soc_cpufreq_init,
> .exit = apple_soc_cpufreq_exit,
> --
> 2.35.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: apple: remove duplicate intializer
2022-12-15 17:10 ` Eric Curtin
@ 2022-12-16 4:55 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2022-12-16 4:55 UTC (permalink / raw)
To: Eric Curtin
Cc: Arnd Bergmann, Hector Martin, Sven Peter, Rafael J. Wysocki,
Arnd Bergmann, Alyssa Rosenzweig, Marc Zyngier, asahi,
linux-arm-kernel, linux-pm, linux-kernel
On 15-12-22, 17:10, Eric Curtin wrote:
> On Thu, 15 Dec 2022 at 17:05, Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > When -Woverride-init is enabled, gcc notices that the .attr
> > field is initialized twice:
> >
> > drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
> > 331 | .attr = apple_soc_cpufreq_hw_attr,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Remove the first one, since this is not actually used.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Eric Curtin <ecurtin@redhat.com>
Applied. Thanks.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-16 4:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 16:55 [PATCH] cpufreq: apple: remove duplicate intializer Arnd Bergmann
2022-12-15 17:10 ` Eric Curtin
2022-12-16 4:55 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox