From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E629EC4332F for ; Sun, 18 Dec 2022 16:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iYwSnEhhvrO2o7E+03RGONEkQuDouJO4hBm0w5pNj34=; b=QqIooDBzub7efG WuogINlbmA37Ypt9gK+6XefaQrLOGmKm5fjYHiq7+kp/wJmreCAmJ07OaIjizowrUas6tXkZFcjsq r+293tFlmxm0UcpzpAu2tOq5Z3HKUlNrkC0OoFiQxCtK51ocnDtt/3XuRB4+9YCht7xA1TsTxoav4 9TL5Sc/F6I1QAWujd/W+fRsh6+h0o6SD1l+bUWx8s5Fktp97pAueVgb0ceP1N9oGQbMaJi0mJIYzE bZN4UWUZixcpY92lh9Xh/00Zod3VOXC8VmYVj4GQjh3gmYvDv7bOoXTgVLpNUkgkc9YshbMJk3ClL vt4wym/rtofGSqOnH8lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6wCo-002pfs-QW; Sun, 18 Dec 2022 16:08:03 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6wCa-002pWi-K3 for linux-arm-kernel@lists.infradead.org; Sun, 18 Dec 2022 16:07:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0A315B80BA4; Sun, 18 Dec 2022 16:07:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9065C433F1; Sun, 18 Dec 2022 16:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671379665; bh=AJg30lQM+3uKhnVTxpxBj1HiLwsVIJR8eAyQmiDceYU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u29djQgzkddmftc7IT2sYsHvuEeoWS/ChbHG4Y6HFUGF5abaDgyhRRaa+Iwlni0OW gDQjP7opaM7DEU2hE1f1AQ1JEgHrmjMwkMrlBYW20/O4PpVdS9xJNdE8mKo+Qh6AwM JUlG5vdl7YiFYtBO5klupzasxZeJ8126/uZbmkpuKbuLanfkDbbNJFneKIFnkL1Ryf GrIkOPPbBPjwm0ysiIJU0leLk+XppR6yavyCM22BH0PR4ohXVdDCd53f/621nHBnBr KRNdIgWiHR/oO3TAx0OD1uR7zv+L9YnCSOpif8yt9G+mAIzOj4j+Z/bUgeumlBFjgM hvF7MIXvi6/Vg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ming Qian , Mirela Rabulea , Hans Verkuil , Sasha Levin , mchehab@kernel.org, shawnguo@kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.0 02/73] media: imx-jpeg: Disable useless interrupt to avoid kernel panic Date: Sun, 18 Dec 2022 11:06:30 -0500 Message-Id: <20221218160741.927862-2-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221218160741.927862-1-sashal@kernel.org> References: <20221218160741.927862-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221218_080748_877105_B86DC90A X-CRM114-Status: GOOD ( 11.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ming Qian [ Upstream commit c3720e65c9013a7b2a5dbb63e6bf6d74a35dd894 ] There is a hardware bug that the interrupt STMBUF_HALF may be triggered after or when disable interrupt. It may led to unexpected kernel panic. And interrupt STMBUF_HALF and STMBUF_RTND have no other effect. So disable them and the unused interrupts. meanwhile clear the interrupt status when disable interrupt. Signed-off-by: Ming Qian Reviewed-by: Mirela Rabulea Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c index 9418fcf740a8..ef28122a5ed4 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.c @@ -76,12 +76,14 @@ void print_wrapper_info(struct device *dev, void __iomem *reg) void mxc_jpeg_enable_irq(void __iomem *reg, int slot) { - writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN)); + writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS)); + writel(0xF0C, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN)); } void mxc_jpeg_disable_irq(void __iomem *reg, int slot) { writel(0x0, reg + MXC_SLOT_OFFSET(slot, SLOT_IRQ_EN)); + writel(0xFFFFFFFF, reg + MXC_SLOT_OFFSET(slot, SLOT_STATUS)); } void mxc_jpeg_sw_reset(void __iomem *reg) -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel