From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BCB1C4332F for ; Tue, 20 Dec 2022 18:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=buGE1J3EnLPAU+X0r27Xj0+mrHKAFDBzALQ4bwEqTRM=; b=Bd79SpomjfsPdY bsBfh8RwYpe9UFZtWamAr0DTXSgTAQVeQ+1drEeKzUUpIQsWmr9IStesIAsPr0krCBWV7psofo4gn 4UBBI+9qDtgnOV4Cl/74H5RKwY+J9JEqSJlk4lN132RKlJpuIXwRa96F6yElbs5Y+5SWaM4/d+jxP vA/HQQRFycfVZGM/h56Bse2vJ5/JIZyhpTlbcmEzquYl2tZfdleJNdTLyTb0GuwBfbTUgubpJBE1C IitJvZPX0+01thqU+mKeoUENLEeEbsGlPaUlfAisetsAfuIMDGMbs4G6r49XCBgdnRmKs2uE26uYT TLwaZxGdXujqA3MxYsaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7hDc-0028yW-73; Tue, 20 Dec 2022 18:20:00 +0000 Received: from mail-oa1-f43.google.com ([209.85.160.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7hDY-0028sT-Tp for linux-arm-kernel@lists.infradead.org; Tue, 20 Dec 2022 18:19:58 +0000 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1442977d77dso16364541fac.6 for ; Tue, 20 Dec 2022 10:19:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yvYSUhN9Lgqqo8NRRxAwZN/kbVSJbYqRGacsJ+ZY83o=; b=MGsFQgOTwHRwNPIpEukDuEsyC1kaCMxk4MLZLOYNQhc7v/c1bYTobl4Q9WQQ0PPA70 gCbJo37sXbUKvEt+WOtDSXPk/EbX4YBtFjUQMKXvJpDxrVk1DFzhSCGIpW60jo+rATaY 2U6OaCoOk1R/CRHXdXaWIaN4Ce4iZgrqPhAQSdOIbxZI3W99sEgYp3MmEkomfANa2o/R JJPrxHp+9BlZTpHK7pIh1Mk9zJ14BJMGRKU8Xq9jDH1DAV65ke8mZr129pM+yf8KGiB1 KemVrAe6xhibkFixZkR+eZCIYcMk/tDaqi6kh6gNRBx7iQS8ereIhAYCV9W72Tx2xrd/ PSKA== X-Gm-Message-State: ANoB5plNQ/q5eN1NmlUN7Q3++jxZOEi09XVVIUMFHwVpbGYxV/Nm3BSQ 6oAhoKPgWmGf6L9mFXheGw== X-Google-Smtp-Source: AA0mqf4DhOxwDe9Kor6K8GQK2yyyxze1bgPG9xFLll91lFoFwbbg5+AyBLIX7Xq27noEvso5Iwxv5w== X-Received: by 2002:a05:6870:ed45:b0:144:a626:218b with SMTP id ex5-20020a056870ed4500b00144a626218bmr22778212oab.56.1671560390074; Tue, 20 Dec 2022 10:19:50 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d20-20020a056871041400b0013c8ae74a14sm6257284oag.42.2022.12.20.10.19.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 10:19:49 -0800 (PST) Received: (nullmailer pid 858419 invoked by uid 1000); Tue, 20 Dec 2022 18:19:48 -0000 Date: Tue, 20 Dec 2022 12:19:48 -0600 From: Rob Herring To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: devicetree@vger.kernel.org, Fabio Estevam , Daniel Vetter , David Airlie , Sascha Hauer , dri-devel@lists.freedesktop.org, NXP Linux Team , Krzysztof Kozlowski , Philipp Zabel , Shawn Guo , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/2] drm/imx/lcdc: Implement DRM driver for imx21 Message-ID: <20221220181948.GA828243-robh@kernel.org> References: <20221216175006.456831-1-u.kleine-koenig@pengutronix.de> <20221216235758.GA88372-robh@kernel.org> <20221217183806.bvo5vypm6axycdte@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221217183806.bvo5vypm6axycdte@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221220_101957_009749_01A89CDD X-CRM114-Status: GOOD ( 24.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 17, 2022 at 07:38:06PM +0100, Uwe Kleine-K=F6nig wrote: > On Fri, Dec 16, 2022 at 05:57:58PM -0600, Rob Herring wrote: > > On Fri, Dec 16, 2022 at 06:50:04PM +0100, Uwe Kleine-K=F6nig wrote: > > > Hello, > > > = > > > Changes since v2: > > > = > > > - added allOf as Krzysztof requested > > > - reworked driver based on Philipp's comments > > > (improved error handling, different selects, moved driver to a sub= directory, > > > header sorting, drm_err instead of DRM_ERROR, inlined > > > imx_lcdc_check_mode_change, make use of dev_err_probe()) > > > = > > > Krzysztof also pointed out that we're now having two compatibles for a > > > single hardware. Admittedly this is unusual, but this is the chance t= hat > > > the (bad) compatible identifier imx21-fb gets deprecated. The hardware > > > is called LCDC and only the linux (framebuffer) driver is called imxf= b. > > = > > The problem is you can't have firmware (with the DTB) that supports = > > both. Well, you can if you want to have some firmware setting that = > > selects which one. Otherwise, it's really an OS problem to decide what = > > to use. = > = > I don't understand what you intend to say here. The same applies if the > compatible is the same for both binding alternatives, isn't it? = Only if you have both nodes in the DT and both enabled. But 2 enabled = nodes at the same address is also a dtc warning, so I was assuming you = didn't do that. > Do you consider a firmware problem better or an OS problem? The OS created the problem, so they get to keep it. But a PC BIOS is = full of OS compatibility switches, so... In the end, it's the platforms' decision really. I just want what the = implications of having 2 compatibles are to be understood. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel