From: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Stephen Boyd <sboyd@kernel.org>, Ikjoon Jang <ikjn@chromium.org>
Cc: <Project_Global_Chrome_Upstream_Group@mediatek.com>,
<angelogioacchino.delregno@collabora.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
Chen-Yu Tsai <wenst@chromium.org>,
Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Subject: [PATCH v2 2/6] soc: mediatek: pm-domains: Add buck isolation setting in power domain
Date: Wed, 21 Dec 2022 11:44:03 +0800 [thread overview]
Message-ID: <20221221034407.19605-3-allen-kh.cheng@mediatek.com> (raw)
In-Reply-To: <20221221034407.19605-1-allen-kh.cheng@mediatek.com>
In MT8192, we need to disable EXT_BUCK_ISO before turning on the ADSP
power pm-domains (mtcmos).
Add the MTK_SCPD_EXT_BUCK_ISO flag to control the buck isolation
setting in the mediatek power domain driver.
Fixes: 59b644b01cf4 ("soc: mediatek: Add MediaTek SCPSYS power domains")
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
drivers/soc/mediatek/mtk-pm-domains.c | 8 ++++++++
drivers/soc/mediatek/mtk-pm-domains.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
index 09e3c38b8466..63f1e183f645 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.c
+++ b/drivers/soc/mediatek/mtk-pm-domains.c
@@ -218,6 +218,10 @@ static int scpsys_power_on(struct generic_pm_domain *genpd)
if (ret)
goto err_reg;
+ if (MTK_SCPD_CAPS(pd, MTK_SCPD_EXT_BUCK_ISO))
+ regmap_clear_bits(scpsys->base, pd->data->ext_buck_iso_offs,
+ pd->data->ext_buck_iso_mask);
+
/* subsys power on */
regmap_set_bits(scpsys->base, pd->data->ctl_offs, PWR_ON_BIT);
regmap_set_bits(scpsys->base, pd->data->ctl_offs, PWR_ON_2ND_BIT);
@@ -272,6 +276,10 @@ static int scpsys_power_off(struct generic_pm_domain *genpd)
if (ret < 0)
return ret;
+ if (MTK_SCPD_CAPS(pd, MTK_SCPD_EXT_BUCK_ISO))
+ regmap_set_bits(scpsys->base, pd->data->ext_buck_iso_offs,
+ pd->data->ext_buck_iso_mask);
+
clk_bulk_disable_unprepare(pd->num_subsys_clks, pd->subsys_clks);
/* subsys power off */
diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h
index a5f24c58e35a..5ec53ee073c4 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.h
+++ b/drivers/soc/mediatek/mtk-pm-domains.h
@@ -10,6 +10,7 @@
#define MTK_SCPD_DOMAIN_SUPPLY BIT(4)
/* can't set MTK_SCPD_KEEP_DEFAULT_OFF at the same time */
#define MTK_SCPD_ALWAYS_ON BIT(5)
+#define MTK_SCPD_EXT_BUCK_ISO BIT(6)
#define MTK_SCPD_CAPS(_scpd, _x) ((_scpd)->data->caps & (_x))
#define SPM_VDE_PWR_CON 0x0210
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-21 3:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 3:44 [PATCH v2 0/6] Add ADSP power domains controller support for MT8192 Allen-KH Cheng
2022-12-21 3:44 ` [PATCH v2 1/6] soc: mediatek: pm-domains: Add buck isolation offset and mask to power domain data Allen-KH Cheng
2022-12-21 10:18 ` AngeloGioacchino Del Regno
2022-12-21 3:44 ` Allen-KH Cheng [this message]
2022-12-21 10:20 ` [PATCH v2 2/6] soc: mediatek: pm-domains: Add buck isolation setting in power domain AngeloGioacchino Del Regno
2022-12-21 3:44 ` [PATCH v2 3/6] dt-bindings: power: Add MT8192 ADSP " Allen-KH Cheng
2022-12-21 10:21 ` AngeloGioacchino Del Regno
2022-12-21 3:44 ` [PATCH v2 4/6] soc: mediatek: pm-domains: Add ADSP power domain data for MT8192 Allen-KH Cheng
2022-12-21 10:21 ` AngeloGioacchino Del Regno
2023-02-03 13:07 ` Matthias Brugger
2022-12-21 3:44 ` [PATCH v2 5/6] dt-bindings: arm: mediatek: Add missing power-domains property Allen-KH Cheng
2022-12-21 8:18 ` Krzysztof Kozlowski
2022-12-29 10:15 ` Chen-Yu Tsai
2022-12-21 10:22 ` AngeloGioacchino Del Regno
2022-12-21 10:33 ` Krzysztof Kozlowski
2022-12-21 10:34 ` AngeloGioacchino Del Regno
2022-12-21 3:44 ` [PATCH v2 6/6] arm64: dts: mediatek: Add the missing ADSP power domains controller for MT8192 Allen-KH Cheng
2022-12-21 10:23 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221034407.19605-3-allen-kh.cheng@mediatek.com \
--to=allen-kh.cheng@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=ikjn@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox