From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 796D7C4167B for ; Fri, 30 Dec 2022 18:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JGuyOiQjySHIvsXi++ivSbjyTYW5Q5aCtAJoNFJxySg=; b=eqSElim48aA+XT 54BQF98zYs3ErXiFAwmpP0KNo6CH3QlTvY72M2F4ECcXLwNnU9QyxOtsdV3moJ+WcxBkLbuDisGmC /yVPG2kQJB/Pa9eHgh+hqf8FXJBiDidqEOaQNvwiGt2X/XjQKZwHHIjkt5fzBn2JMcyjKZB9gNox0 W5UriHX0ZfmdV1cgJD6qj9ClDCGlvVUn5NDS8u8phcrlrxUJs1hI5MF+xDgEswzhixtN7rxJvW9uP KwRgJv9VJZaoenFfLJSuPG9FKLEqtTjFu5ueWAxyLA7jiPmsMCtkYjHtT2u4hhxfNyjdSzr42k2ST hYv5lq2bhOwJRxDbVq2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBKXw-00CPLd-Iw; Fri, 30 Dec 2022 18:56:02 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBJap-00Bpxl-US for linux-arm-kernel@lists.infradead.org; Fri, 30 Dec 2022 17:54:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BD7A9B81CEA; Fri, 30 Dec 2022 17:54:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A16E6C433EF; Fri, 30 Dec 2022 17:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672422891; bh=n26j3UNEBWhnst1Oo9v8s52C4KD49fhyEge2J4vzAmc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mzqd2UgN5mNYi2ZRQozGDhqjfBuD6TjIX+dV/JNT/N+/DTkzRqDdGSw9BiUyKGAYM KsZYneFe0OmEFn5LhB8boWiTMgaKAnOdXJeMKW/NlvhbJnLMmDcOt7QCTRLoNtx5Sz BohFSRe++CrN0yTtaklYUKypwsd9zqxHBxnER+am3OymXkeK447j3e3DGOy6/kcXz2 hBxBqYb1Gu0buKUl0s6bjN7G2sTlWIihvYOWgzEV+isQiI/HM544kYR7kRLujrYUEf b4b9sjOQMAwdrAnqbpuKeHTxbuYRpCfx+Vmq7HTGh5PUELXbU8pxyxMcpqfnSwu16K eqvl7Jf2gtBEQ== Date: Fri, 30 Dec 2022 18:08:09 +0000 From: Jonathan Cameron To: Alexander Sverdlin Cc: linux-iio@vger.kernel.org, Hartley Sweeten , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v3 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description Message-ID: <20221230180809.051fc6bd@jic23-huawei> In-Reply-To: <20221223162636.6488-1-alexander.sverdlin@gmail.com> References: <20221223162636.6488-1-alexander.sverdlin@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221230_095456_802286_470B4B47 X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 23 Dec 2022 17:26:35 +0100 Alexander Sverdlin wrote: > Add device tree bindings for Cirrus Logic EP9301/EP9302 internal SoCs' ADC > block. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Alexander Sverdlin Applied to the togreg branch of iio.git and pushed out as testing. Whilst we are looking at this driver, Alexander, would you mind if we relaxed the Kconfig dependencies to: diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 46c4fc2fc534..fd1d68dce507 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -441,7 +441,7 @@ config ENVELOPE_DETECTOR config EP93XX_ADC tristate "Cirrus Logic EP93XX ADC driver" - depends on ARCH_EP93XX + depends on ARCH_EP93XX || COMPILE_TEST help Driver for the ADC module on the EP93XX series of SoC from Cirrus Logic. It's recommended to switch on CONFIG_HIGH_RES_TIMERS option, in this I end up doing that locally to build test patches like this one and it doesn't seem to cause any problems. Jonathan > --- > Changelog: > v2: removed clock-names property, soc node and include as Krzysztof suggested > > .../bindings/iio/adc/cirrus,ep9301-adc.yaml | 47 +++++++++++++++++++ > MAINTAINERS | 2 + > 2 files changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml b/Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > new file mode 100644 > index 000000000000..6d4fb3e1d2a2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/cirrus,ep9301-adc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic EP930x internal ADC > + > +description: | > + Cirrus Logic EP9301/EP9302 SoCs' internal ADC block. > + > + User's manual: > + https://cdn.embeddedts.com/resource-attachments/ts-7000_ep9301-ug.pdf > + > +maintainers: > + - Alexander Sverdlin > + > +properties: > + compatible: > + const: cirrus,ep9301-adc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + adc: adc@80900000 { > + compatible = "cirrus,ep9301-adc"; > + reg = <0x80900000 0x28>; > + clocks = <&syscon 24>; > + interrupt-parent = <&vic1>; > + interrupts = <30>; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 69565ac0c224..4a914d5bc2e6 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2027,8 +2027,10 @@ M: Hartley Sweeten > M: Alexander Sverdlin > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > S: Maintained > +F: Documentation/devicetree/bindings/iio/adc/cirrus,ep9301-adc.yaml > F: arch/arm/mach-ep93xx/ > F: arch/arm/mach-ep93xx/include/mach/ > +F: drivers/iio/adc/ep93xx_adc.c > > ARM/CLKDEV SUPPORT > M: Russell King _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel