From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9E49C4332F for ; Sat, 31 Dec 2022 05:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/CbGzMK/wmsqIWD5o/3oNPuBtNst5gNCCNZO/Q6uaQo=; b=Ll2BKyrpXGm+mA qN9ol77/vmbntXtLteknjHxtIymeFKX8IOPzFeO/D1NyP4g2SE9Zw3Ehzt62BiZ1NASPy7Snayfin s1id22tTYc8tjGnWmwnaA9BmP5mLMC/pVgiFZrAKiK0veeHC1XG7o46kOBFIG4ilFjxeArpS/97PM i37Ckeqvysi48GoJc1Qz3Y/iv9GSu7zU54ALp3KqxXvhJXS9jXhnJTftqttxQ7zPopqtBw0JK/zOR RC1P0/GAXCCpViEr5xVvabu25oLCGuV8tKqUH0YSdsXOAI6dJ7AKl+kVqmim3vUxhAznYP48Brbki AHvxDt6b38yOJrdoQlwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBUTY-000tg3-UK; Sat, 31 Dec 2022 05:32:09 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBUTV-000tch-Ih for linux-arm-kernel@lists.infradead.org; Sat, 31 Dec 2022 05:32:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0E1BB81DC6; Sat, 31 Dec 2022 05:31:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2198C433EF; Sat, 31 Dec 2022 05:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672464714; bh=a0beEdEjQhcL13CqoIrDh3Eqnh0R13DLBFnhUT3QFq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MPCg7IZl4FjSK4IxLgTv3dnVId92/dZMWcgyY7j6nAjDJ+cY6LBkUT97YIZJ6fnpW 0//lBFrVKeC1EBqv5lYIIRzlmXHlt49cvoOP884qYvp4Gff3muG4lmSGq9cU9QwsvR 28s+sBBhwp38BZGn2jJ3GsF4h56JIP1NhubHz0gWY+Y3VJmVWqVBNinI130Smml18N r7wJIZo6x702iC2kZr1SHwsAkj9GqDFUxkSKpQ6DWOYD6f8NzZvFFlyk8RktpqLpKD zq3qYbQP6zvGnvpK/Ni4E2wdwWXztT4rx6awsvX8Wz20l9mS/qwZi+QDJyhHWi9fmQ YTeT5j1WunfaA== Date: Sat, 31 Dec 2022 13:31:47 +0800 From: Shawn Guo To: Lucas Stach Cc: Fabio Estevam , NXP Linux Team , Peng Fan , Kieran Bingham , linux-arm-kernel@lists.infradead.org, patchwork-lst@pengutronix.de, kernel@pengutronix.de Subject: Re: [PATCH 1/3] soc: imx: imx8mp-blk-ctrl: don't set power device name in Message-ID: <20221231053146.GA6112@T480> References: <20220826191305.3215706-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220826191305.3215706-1-l.stach@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221230_213205_812873_D37C2DCB X-CRM114-Status: GOOD ( 19.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 26, 2022 at 09:13:03PM +0200, Lucas Stach wrote: > Setting the device name after it has been registered confuses the sysfs > cleanup paths. This has already been fixed for the imx8m-blk-ctrl driver in > b64b46fbaa1d ("Revert "soc: imx: imx8m-blk-ctrl: set power device name""), > but the same problem exists in imx8mp-blk-ctrl. > > Fixes: 556f5cf9568a ("soc: imx: add i.MX8MP HSIO blk-ctrl") > Signed-off-by: Lucas Stach For patch subject, what does "in" mean there? Should we just drop it or add something after it? Shawn > --- > drivers/soc/imx/imx8mp-blk-ctrl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > index 4ca2ede6871b..9401df25c85a 100644 > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > @@ -529,7 +529,6 @@ static int imx8mp_blk_ctrl_probe(struct platform_device *pdev) > ret = PTR_ERR(domain->power_dev); > goto cleanup_pds; > } > - dev_set_name(domain->power_dev, "%s", data->name); > > domain->genpd.name = data->name; > domain->genpd.power_on = imx8mp_blk_ctrl_power_on; > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel