From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD6F7C46CD2 for ; Tue, 2 Jan 2024 08:27:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sc5AYxb6ihd6/PWy1+eNINrb6xHayfhF0AeagP5ezBU=; b=J76g7e3pLRhZkP 7StsJv2g323rJXYfX1RWHUtuyPTvSczLvq2UoV0SgWdqhjUEvA90iQn3+Ra1oE4ON6FNkifwkePkg BcEo5OBXyJlChN726lCa5/haNvHKNFLpFO+5vsP4mY0NvHYYhh6P6vS5EfESVtsE8GZJA1Gc/BCg+ uPC6hfU8KhBpT1RYUFI5PuqK+2ClZKusHUegb5p0CRvQYYhuKivYkGjkyVyuON+4pcIaFRfS47K4K 1KcipMsKK8CFo7S3SChc4jXZPFU2gVZqz0eiVx1wTfLLkgIf+FXmVzNAS1SZdS0r1d//Q7EUUAgPB S5IStvpMp0bEe9LK0PiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKa6q-007L6I-0E; Tue, 02 Jan 2024 08:26:48 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKa6n-007L4m-18; Tue, 02 Jan 2024 08:26:47 +0000 X-UUID: a74afacca94811ee9a662f17bb45267e-20240102 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=IQPWnM3n4hAzrH3tsrDEvo6suXoJsA7mNXzz3NyzuFk=; b=Ns61RSiskUA2VHjESRAcc7LZGcvahcOzDoMZMlFUsOBF+wSjxfHGI/YeA6+9Oe+JZKLrxoProcByheAZAu+VhAKIM7eFA8OCJzVWoz+M5jDMplucrVDwm/UUdS5TYrWm9PO+aWTv5ltvguvjgRZHGxd33ovi7zWFdacBm0YiGNk=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:76302c72-ceff-4970-9250-3f0bfc195b10,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5d391d7,CLOUDID:a8a2cc8d-e2c0-40b0-a8fe-7c7e47299109,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: a74afacca94811ee9a662f17bb45267e-20240102 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1440641885; Tue, 02 Jan 2024 01:26:40 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 2 Jan 2024 16:26:06 +0800 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 2 Jan 2024 16:26:06 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RZVc133p1rakvqmQraYYDILt9wcOhr9oLnP5wT1Ny1yvIeYy1wGSxGcp610veYkqMuOoExUiAk7Rrybbk3Qq8ExyxjKae1VNhswD8cD+4YncVG3DvokYTFWNHsXddLkao4xJm2HQDhb4RTFWVdEfIZ9zFFQk9NnsCQgDBrLNqquZQyqKuJSwKIQhSH1E3CKNgdvgkhx+8uj72Yo0R560rKkGGsXhSgy1l18ms4taZ03pPKHuZjmngz3jYmOq9/ZC+2Bfgm454e40D6Z9EFdxQlYmOlOrHPrd/izKYLCUi3helKSw6EDXTaDkAu2MWnE6iLmlHvZaWS5D/2TbeGOjeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IQPWnM3n4hAzrH3tsrDEvo6suXoJsA7mNXzz3NyzuFk=; b=FCSfQtG15rheMu+WYe3hxSChaG29iDx9+AVkwQy8/hIIOQHQYu2wUX7yy/qHXQyqx1uXgCAEfiaMlJWAahJPbpJmOUZW5eJgU5bHQpaZdQMKJzyx4G1Iymz0XZee3ZUyDn0kVWDRjQeR5xNaoFi8aJ9VJfzIZHRJFXbEWDhXy78crGlnlJikkf6O+g7rrY4pU78p2UBBcAANtPMlj/Dn8j99vJnKOFxjJ6f8rxGXCP07O2jo0UTRDcFefaISAFqCyFsLycq3D/QIek69MQ6Xn2bomh+Rfmd+MAs4ePf/X8zBH+PGao5aADfv7nm+eb9oZq1mGVI700TefdIVWf+ZnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IQPWnM3n4hAzrH3tsrDEvo6suXoJsA7mNXzz3NyzuFk=; b=J/3ubEQSm3MgkVePPSafu1Vh0ACXvbqCMXTOA4j/cSZFElVT/cyDUYMe0PCwMMFpJY77wbGWQMftCAfeQqLPQ+KdDdDYs+ONKpaNHjWaJ9ogNl/jcMgqdsI+Ksxd1hgmlDQDUbzlL2bcDDJTSz6TW9eLQwikU+XCQlMR749EiMA= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by TY0PR03MB7000.apcprd03.prod.outlook.com (2603:1096:400:27e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Tue, 2 Jan 2024 08:26:03 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::eb43:57cb:edfd:3762]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::eb43:57cb:edfd:3762%7]) with mapi id 15.20.7135.023; Tue, 2 Jan 2024 08:26:03 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: =?utf-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , "angelogioacchino.delregno@collabora.com" , "chunkuang.hu@kernel.org" CC: "linux-mediatek@lists.infradead.org" , "robh+dt@kernel.org" , "linux-kernel@vger.kernel.org" , "wenst@chromium.org" , =?utf-8?B?QmliYnkgSHNpZWggKOisnea/n+mBoCk=?= , "devicetree@vger.kernel.org" , "daniel@ffwll.ch" , "p.zabel@pengutronix.de" , "dri-devel@lists.freedesktop.org" , "airlied@gmail.com" , "krzysztof.kozlowski+dt@linaro.org" , "sean@poorly.run" , "matthias.bgg@gmail.com" , "fshao@chromium.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 16/17] drm/mediatek: Fix errors when reporting rotation capability Thread-Topic: [PATCH v4 16/17] drm/mediatek: Fix errors when reporting rotation capability Thread-Index: AQHaLPWZwjDA6QrbXki1E+NyllZnIbDGULkA Date: Tue, 2 Jan 2024 08:26:03 +0000 Message-ID: <2022d3d5de21167355929590cb5d6687aa1b4d29.camel@mediatek.com> References: <20231212121957.19231-1-shawn.sung@mediatek.com> <20231212121957.19231-17-shawn.sung@mediatek.com> In-Reply-To: <20231212121957.19231-17-shawn.sung@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|TY0PR03MB7000:EE_ x-ms-office365-filtering-correlation-id: 6e954c73-4ec8-427a-b153-08dc0b6c7592 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q2qHfdmPga4Y6fAfBo1jokFWemMR16/Lxohc3PmAEZUlvisu6p/yZflq0gVdvCy2sf9XRpHEr1UhQjwqVsAFjp67lLJs8d92cbJFFkUGzhF87P6ERkWDIIWH9w83mmyxIIIquiQ7H5J3/5wkTB+SBQsHfhBuo4z69OP+ojE4Kl5nL7SEjQRS7RVBdDoN+lC77pYNGxxoWlHJoRNOjZvLG5Erd5/X9O8x63+xi3qeWlSnHBA+B7XLv5NhGgRRFbzCcBSpQwmV61jr8n6Hvq7XgvPbuEb4KPLJPGaiUzjQfUbbVqT1WqJV0pfIuFjIIrcxAEMPIaiv4fKyso77ax/WgqJMapj2fIAly73TXBYO4T/qjmU4XgsEhRxRMChAbMoNRHUZk0AmzjKPMLRODTmM1qTv4C65xa+0uxuSSBeZnlYSYiC9CTo1Wc71Ptn80U1RL4UgXRqH94cPsuNXZ81wPWIFInnSmDt5vAYdPeUh15Qmqbw//ZD0ElMlCIQiLysOlpfSzr9ELcqYICqqDoRtVHRu2umRTnOBT3ghZZttMZw1NE/0q7cr8bbqtbj90XbjRaFfPhvTVKzHbjShVO35PUzk+7sTWmMj7QF++4bidCHGBa5JN1o7XUC54fhs6/qe/lNWov0fPc4KbhU1GIhrQ4s7KYgKtsiDTjnlmhpxowM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(346002)(136003)(366004)(39860400002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(2616005)(26005)(83380400001)(71200400001)(6506007)(6512007)(7416002)(5660300002)(4326008)(2906002)(41300700001)(4001150100001)(66946007)(6486002)(478600001)(54906003)(316002)(76116006)(8676002)(8936002)(64756008)(66446008)(66476007)(66556008)(122000001)(110136005)(86362001)(38100700002)(36756003)(85182001)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RUVDTktpdmFUS08xNVpvN3dmekdOZVErcHpmQkt1Kzg3OGNoSC9KTE52VGg4?= =?utf-8?B?NzlUbWZrUWU5TVE0d0luS29ZZlRYYnhFTkJ1bXQwYnVyb2lCSm1BbDFCRzc3?= =?utf-8?B?Z2JFZFBKUktNbFNwQnJralZRdWlVODVjSENDSndVUmk1ajJkMVRrSHMxOWhF?= =?utf-8?B?dTRoOENrRlpDWTdBNy9mcUJmK2wzYUJsSXFheThGNktJNjZqUmlyRmx1bXhP?= =?utf-8?B?dEsvZ1Y0bW1ZdzJPY3ZuVGlHRXVHaU91Yk1qL2oxZjNFb1JpdjZ6U09EYXBR?= =?utf-8?B?UzV1UTY5amVJaVprcktiVm5Mc0V5V3MrTUIreEh3VWw0UGJUU3JHWU1sN044?= =?utf-8?B?SkwwajBWQVo5dXAyeERMUVFBeVdEelFHNWdBY1IvK2pra2Ivd3FycjI5Mm13?= =?utf-8?B?dzVXMHZJZUhqaWFsM0pPUUsvYXZWRGQ5TWNPYjJaQ3pDM2tWcWlDRHpsdUNK?= =?utf-8?B?a2JlMWhVWi9GRVFFbHhRU2ZrTUN6K1B2dEgzeHJ2MzNINFQzZkFOalJkcGVL?= =?utf-8?B?bjVsVGo4dWYxQm54bFFSZ1JkVmNUQ1FOV3UzV0luWldoYzZkTmRnaytrcEU2?= =?utf-8?B?OWIvNnNlTmloaHoyL2Ftcno1QUtoT2Y0WlRibXBZckRCKzJ3bzZUZ1hZZkJU?= =?utf-8?B?VGhhT1FGVk1PTldVSDNuTXQ5MTFpOXBtSENHdmxrdGhyV0JwS2RVZzRIbWRE?= =?utf-8?B?Y3MvNXQ3VUFWK0ZyNkhwWUlFOVdrS2dIczFUN0xDTHBCOVhQY0t4eHRuQnVa?= =?utf-8?B?ZUthaHVHLy9FR0ZhMkVsRDZPNjl2MWdKdXRCQWdSUDFSYnJudURkYWFNM3lx?= =?utf-8?B?cE5iMERnK3BxTE9hYjhRZmZUWnpqNHBTZlZYS2Z4dElJSDdiRm9tUUNiV2Zp?= =?utf-8?B?U0VLbW53K1A2WEFDSEQzZmpiSE9oQlZMcTBBTUZiMUdoV2ExTTQrMWpBNy80?= =?utf-8?B?NmpZdGd0MWxOZk0waU9LTGEvMjdHUCtsU2xwZnNNdHhNVGl5cEtaSGxZM3Vr?= =?utf-8?B?RkVvM2J5UUI0RHQzMFNISm11TU14WXQ2SHl2b1MvOFVFL2hSNWtaZXkzTlRW?= =?utf-8?B?TkRiRjllUnc2S1oxLzNZZ3M3UEduTzJkVEN6SFd0aUM5TGVhemlReTE2cU5v?= =?utf-8?B?TWpybG9HZWtoTkE3RG5WZGp1L2VGaDYrSzBya1FsejNJL2lJa2lQdEp6UDRX?= =?utf-8?B?M2xvQm13NlZEOXp2T2dEaUtFbDY4YmlsVGE3UkZRTlkwdTQ1dEE5V1RvM2Ix?= =?utf-8?B?bmkwbHVVeHFvZ1h5enRTNHFDSzgyamlvSWZHMFJCWFk5Ym9UeFZOcnNoWThL?= =?utf-8?B?bUdzdWxPY0NlREdGVEhMWU9kd25rU0p2aVJZVTRJU1VDUzlwb0NYYjE5aXVw?= =?utf-8?B?L1A4L1NhTWlCUUJzVkpGRURVSzV4M2tjZ2tPbXhESUJGMDdxOGFNZys3Z1Zr?= =?utf-8?B?bXIrV29xdlRVZVNKYzJGZEtCWVlhZEc2cVJxTWFweFdFdnF6L0NFbTFWcXhV?= =?utf-8?B?UnExSjAzRXUzbTBza2tvZHg1bDE4VDQ5WjZlTWdWVU5oQWZWaVd5MjdHbUJo?= =?utf-8?B?OGRORUVMc0sxdk5nWXhudEdyczdSRW9RcmFXYUZQQ1RaL0prdEFhWTc0MkJo?= =?utf-8?B?WEdvU0VWRHR6b3FURzhFdFdmUzRsR1dpQklkMnl3SERhTG1pZzFWZEVlOGxL?= =?utf-8?B?dXZzNU5ON3p3c2JQdks4czQ0STB4ZmR6S1IwSGFHdEJvUlowaFZ3c3dOQkRq?= =?utf-8?B?bWZDeTlpbmJzbVF3NkpscWVDeVdLYUhIVm9nWWlsc2VIOEI1OWtQbkRwYTVO?= =?utf-8?B?WHBLNEhTamNiUzdmbU1YRWJyeWZzSlpWSlUzdERZc2ZTeFBuak9WZVA5RS9T?= =?utf-8?B?M2xRMm9qNWVZL2p0alE5emRDK2E2ZytCdnhITjZmcEtlR2d2citxSmtiQWtu?= =?utf-8?B?YndHS2JReWNxSjNqdm0vWGdiQUMxUlNkRHJvVEU0MlpSZ1k4QzFoNjNmeDN1?= =?utf-8?B?bm9nR0J3SmUxWmlNN3ZrcnRScFVtWVJ5OGRCSFJXUkR3aWwwNThSOW5YSlBC?= =?utf-8?B?L3I3WXcyTFErcE5iTUR3UGEyUUFsQXNRQjBMQk5LN0F4QjVqb0dkVlAvNXBr?= =?utf-8?Q?7sRqvhuffDMA9NSP3996O1+M/?= Content-ID: <8B2BF214E8F907488CDB22EA63AFD1E7@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e954c73-4ec8-427a-b153-08dc0b6c7592 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2024 08:26:03.6213 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V4KdIewzzPEtZndlar6yji3Xwe9Jb7qhQJG3MtDU1ONLLPMXTyV6LGyg5+xwWfoWZ0EdPcsP2vu0EXVIDQeChw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR03MB7000 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240102_002645_395752_C40F90DF X-CRM114-Status: GOOD ( 23.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Hsiao-chien: On Tue, 2023-12-12 at 20:19 +0800, Hsiao Chien Sung wrote: > Create rotation property according to the hardware capability. > Since currently OVL of all chips support same rotation, > no need to define it in the driver data. > > Fixes: 84d805753983 ("drm/mediatek: Support reflect-y plane > rotation") > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > Signed-off-by: Hsiao Chien Sung > --- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 18 ++++++-------- > ---- > .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 9 +++++++++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 +- > 5 files changed, 18 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_drv.h > b/drivers/gpu/drm/mediatek/mtk_disp_drv.h > index 4d6e8b667bc3..c5afeb7c5527 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_drv.h > +++ b/drivers/gpu/drm/mediatek/mtk_disp_drv.h > @@ -127,6 +127,7 @@ void mtk_ovl_adaptor_register_vblank_cb(struct > device *dev, void (*vblank_cb)(vo > void mtk_ovl_adaptor_unregister_vblank_cb(struct device *dev); > void mtk_ovl_adaptor_enable_vblank(struct device *dev); > void mtk_ovl_adaptor_disable_vblank(struct device *dev); > +unsigned int mtk_ovl_adaptor_supported_rotations(struct device > *dev); > void mtk_ovl_adaptor_start(struct device *dev); > void mtk_ovl_adaptor_stop(struct device *dev); > unsigned int mtk_ovl_adaptor_layer_nr(struct device *dev); > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index 78749dabeb43..f019737078f6 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -399,6 +399,10 @@ unsigned int mtk_ovl_layer_nr(struct device > *dev) > > unsigned int mtk_ovl_supported_rotations(struct device *dev) > { > + /* > + * although currently OVL can only do reflection, > + * reflect x + reflect y = rotate 180 > + */ > return DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_180 | > DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y; > } > @@ -407,27 +411,17 @@ int mtk_ovl_layer_check(struct device *dev, > unsigned int idx, > struct mtk_plane_state *mtk_state) > { > struct drm_plane_state *state = &mtk_state->base; > - unsigned int rotation = 0; > > - rotation = drm_rotation_simplify(state->rotation, > - DRM_MODE_ROTATE_0 | > - DRM_MODE_REFLECT_X | > - DRM_MODE_REFLECT_Y); > - rotation &= ~DRM_MODE_ROTATE_0; > - > - /* We can only do reflection, not rotation */ > - if ((rotation & DRM_MODE_ROTATE_MASK) != 0) > + if (state->rotation & ~mtk_ovl_supported_rotations(dev)) > return -EINVAL; > > /* > * TODO: Rotating/reflecting YUV buffers is not supported at > this time. > * Only RGB[AX] variants are supported. > */ > - if (state->fb->format->is_yuv && rotation != 0) > + if (state->fb->format->is_yuv && (state->rotation & > ~DRM_MODE_ROTATE_0)) You still no explain what you do here. > return -EINVAL; > > - state->rotation = rotation; > - > return 0; > } > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > index 4398db9a6276..273c79d37bef 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > @@ -383,6 +383,15 @@ void mtk_ovl_adaptor_register_vblank_cb(struct > device *dev, void (*vblank_cb)(vo > vblank_cb, vblank_cb_data); > } > > +unsigned int mtk_ovl_adaptor_supported_rotations(struct device *dev) > +{ > + /* > + * should still return DRM_MODE_ROTATE_0 if rotation is not > supported, > + * or IGT will fail. > + */ > + return DRM_MODE_ROTATE_0; > +} > + > void mtk_ovl_adaptor_unregister_vblank_cb(struct device *dev) > { > struct mtk_disp_ovl_adaptor *ovl_adaptor = > dev_get_drvdata(dev); > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index ffa4868b1222..206dd6f6f99e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -422,6 +422,7 @@ static const struct mtk_ddp_comp_funcs > ddp_ovl_adaptor = { > .remove = mtk_ovl_adaptor_remove_comp, > .get_formats = mtk_ovl_adaptor_get_formats, > .get_num_formats = mtk_ovl_adaptor_get_num_formats, > + .supported_rotations = mtk_ovl_adaptor_supported_rotations, > }; > > static const char * const mtk_ddp_comp_stem[MTK_DDP_COMP_TYPE_MAX] = > { > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index ff300426b590..e73b9793dee2 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -343,7 +343,7 @@ int mtk_plane_init(struct drm_device *dev, struct > drm_plane *plane, > return err; > } > > - if (supported_rotations & ~DRM_MODE_ROTATE_0) { > + if (supported_rotations) { Try report issue to IGT team. Regards, CK > err = drm_plane_create_rotation_property(plane, > DRM_MODE_ROTAT > E_0, > supported_rota > tions); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel