From: Shawn Guo <shawnguo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>, Peng Fan <peng.fan@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC
Date: Sun, 1 Jan 2023 10:37:03 +0800 [thread overview]
Message-ID: <20230101023702.GL6112@T480> (raw)
In-Reply-To: <20221216000552.237219-1-marex@denx.de>
On Fri, Dec 16, 2022 at 01:05:52AM +0100, Marek Vasut wrote:
> The GPIO watchdog property name is 'always-running', not 'always-enabled'.
The patch only adds property 'always-running'. Why is 'always-enabled'
involved here?
Shawn
> Use the correct property name and reinstate it into the DT.
>
> Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> To: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> index b337af03dacf2..5672662c62aca 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> @@ -88,6 +88,7 @@ watchdog {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_watchdog_gpio>;
> compatible = "linux,wdt-gpio";
> + always-running;
> gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
> hw_algo = "level";
> /* Reset triggers in 2..3 seconds */
> --
> 2.35.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-01 2:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 0:05 [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC Marek Vasut
2023-01-01 2:37 ` Shawn Guo [this message]
2023-01-02 23:36 ` Marek Vasut
2023-01-09 7:19 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230101023702.GL6112@T480 \
--to=shawnguo@kernel.org \
--cc=festevam@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).