[PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC

[PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC

[Marek Vasut]

The GPIO watchdog property name is 'always-running', not 'always-enabled'.
Use the correct property name and reinstate it into the DT.

Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@denx.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
To: linux-arm-kernel@lists.infradead.org
---
 arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
index b337af03dacf2..5672662c62aca 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
@@ -88,6 +88,7 @@ watchdog {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_watchdog_gpio>;
 		compatible = "linux,wdt-gpio";
+		always-running;
 		gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
 		hw_algo = "level";
 		/* Reset triggers in 2..3 seconds */
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC

[Shawn Guo]

On Fri, Dec 16, 2022 at 01:05:52AM +0100, Marek Vasut wrote:
> The GPIO watchdog property name is 'always-running', not 'always-enabled'.

The patch only adds property 'always-running'.  Why is 'always-enabled'
involved here?

Shawn

> Use the correct property name and reinstate it into the DT.
> 
> Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> To: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> index b337af03dacf2..5672662c62aca 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> @@ -88,6 +88,7 @@ watchdog {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_watchdog_gpio>;
>  		compatible = "linux,wdt-gpio";
> +		always-running;
>  		gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
>  		hw_algo = "level";
>  		/* Reset triggers in 2..3 seconds */
> -- 
> 2.35.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC

[Marek Vasut]

On 1/1/23 03:37, Shawn Guo wrote:
> On Fri, Dec 16, 2022 at 01:05:52AM +0100, Marek Vasut wrote:
>> The GPIO watchdog property name is 'always-running', not 'always-enabled'.
> 
> The patch only adds property 'always-running'.  Why is 'always-enabled'
> involved here?

Have a look at the Fixes: commit eff6b33c9ce9 below, that one removed 
'always-enabled' , this one adds the correct one 'always-running'. The 
naming got confused.

> Shawn
> 
>> Use the correct property name and reinstate it into the DT.
>>
>> Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Fabio Estevam <festevam@denx.de>
>> Cc: Peng Fan <peng.fan@nxp.com>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> To: linux-arm-kernel@lists.infradead.org
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
>> index b337af03dacf2..5672662c62aca 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
>> @@ -88,6 +88,7 @@ watchdog {
>>   		pinctrl-names = "default";
>>   		pinctrl-0 = <&pinctrl_watchdog_gpio>;
>>   		compatible = "linux,wdt-gpio";
>> +		always-running;
>>   		gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
>>   		hw_algo = "level";
>>   		/* Reset triggers in 2..3 seconds */

[...]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC

[Shawn Guo]

On Fri, Dec 16, 2022 at 01:05:52AM +0100, Marek Vasut wrote:
> The GPIO watchdog property name is 'always-running', not 'always-enabled'.
> Use the correct property name and reinstate it into the DT.
> 
> Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")
> Signed-off-by: Marek Vasut <marex@denx.de>

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel