From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57A1CC4332F for ; Sun, 1 Jan 2023 02:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X5NAg1gRMZ/+XvMBoFatBQ14T4Tn3CxRvI4oRN9y/ck=; b=LBVKE3hkxoFn4i J/NVVLYj5yrQdDnvKHhAxZnOcGylCib0Zmk3ClKP4syDpkjred4hXyin5vOMoVDV+8Mqc07q7w7yR 4PfcwFwfHIV8z4lQn3X3WtGmE/cfJonvfhx7J+TuQKa2MSNXHJJ6+P8pQnECvC3KAKCE6IOBaoFpy A2BVakLPkKJMjD6OgRjvteYgdIQE2slsIFsCVjhM4yMRu9ZT0i2L6/pd+sAs1yv/GAdmHpPamA0Py vtbAM9rkMVItV/rswzjvR5i41cf6uwvwIXsX/DKk7FhlSoScUnuCMwJxsmFtudExMB35eYQtF7J5l oMTf6vAD6rr99lyvOIKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBoE7-00DMUY-Vg; Sun, 01 Jan 2023 02:37:32 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBoDn-00DMP4-Lv for linux-arm-kernel@lists.infradead.org; Sun, 01 Jan 2023 02:37:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1DDD9B80951; Sun, 1 Jan 2023 02:37:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8602C433D2; Sun, 1 Jan 2023 02:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672540628; bh=5zr+3Dr6FwzxZq4LNsiKgAgzPVTUAPuq5wPQMRgakrE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y2tblZiaiHaqw6Q5eeZKgEEL5Gtr2LEHhYIj/0m7Y14jFKS8CiLko1mFVfIYD4unD uI0eVJsE207ZJ9SZoxzcvmA9qWPoRNu6shyM3B8u2rcZOMIO+bDuFNG9psh8RDrSOz Lxuj7mV7p58e5tTtd8cDbZdKTCdq/vxdCylbD6fsaqePZPX/SfDs8dAbAu3i8ZW/C0 6G7F5E/4ZI/IZ+ulxyQd2LYHm8d/3TcNnypYKThxVXE494mVyHDkC2YzOjZryirSpC 3k0BpwAe65hEpqijT/A/ZrpQF9sBABcj5wXv8LT3AKJNUeCjJVuu69AwZjXeMPmmSl qgrOQz/2cz3Nw== Date: Sun, 1 Jan 2023 10:37:03 +0800 From: Shawn Guo To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Peng Fan , NXP Linux Team Subject: Re: [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC Message-ID: <20230101023702.GL6112@T480> References: <20221216000552.237219-1-marex@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221216000552.237219-1-marex@denx.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221231_183713_912085_82F98571 X-CRM114-Status: GOOD ( 17.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 16, 2022 at 01:05:52AM +0100, Marek Vasut wrote: > The GPIO watchdog property name is 'always-running', not 'always-enabled'. The patch only adds property 'always-running'. Why is 'always-enabled' involved here? Shawn > Use the correct property name and reinstate it into the DT. > > Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC") > Signed-off-by: Marek Vasut > --- > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Shawn Guo > Cc: NXP Linux Team > To: linux-arm-kernel@lists.infradead.org > --- > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts > index b337af03dacf2..5672662c62aca 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts > @@ -88,6 +88,7 @@ watchdog { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_watchdog_gpio>; > compatible = "linux,wdt-gpio"; > + always-running; > gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; > hw_algo = "level"; > /* Reset triggers in 2..3 seconds */ > -- > 2.35.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel