* [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC
@ 2022-12-16 0:05 Marek Vasut
2023-01-01 2:37 ` Shawn Guo
2023-01-09 7:19 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2022-12-16 0:05 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Fabio Estevam, Peng Fan, Shawn Guo, NXP Linux Team
The GPIO watchdog property name is 'always-running', not 'always-enabled'.
Use the correct property name and reinstate it into the DT.
Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Fabio Estevam <festevam@denx.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
To: linux-arm-kernel@lists.infradead.org
---
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
index b337af03dacf2..5672662c62aca 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
@@ -88,6 +88,7 @@ watchdog {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_watchdog_gpio>;
compatible = "linux,wdt-gpio";
+ always-running;
gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
hw_algo = "level";
/* Reset triggers in 2..3 seconds */
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC
2022-12-16 0:05 [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC Marek Vasut
@ 2023-01-01 2:37 ` Shawn Guo
2023-01-02 23:36 ` Marek Vasut
2023-01-09 7:19 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2023-01-01 2:37 UTC (permalink / raw)
To: Marek Vasut; +Cc: linux-arm-kernel, Fabio Estevam, Peng Fan, NXP Linux Team
On Fri, Dec 16, 2022 at 01:05:52AM +0100, Marek Vasut wrote:
> The GPIO watchdog property name is 'always-running', not 'always-enabled'.
The patch only adds property 'always-running'. Why is 'always-enabled'
involved here?
Shawn
> Use the correct property name and reinstate it into the DT.
>
> Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> To: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> index b337af03dacf2..5672662c62aca 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> @@ -88,6 +88,7 @@ watchdog {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_watchdog_gpio>;
> compatible = "linux,wdt-gpio";
> + always-running;
> gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
> hw_algo = "level";
> /* Reset triggers in 2..3 seconds */
> --
> 2.35.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC
2023-01-01 2:37 ` Shawn Guo
@ 2023-01-02 23:36 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2023-01-02 23:36 UTC (permalink / raw)
To: Shawn Guo; +Cc: linux-arm-kernel, Fabio Estevam, Peng Fan, NXP Linux Team
On 1/1/23 03:37, Shawn Guo wrote:
> On Fri, Dec 16, 2022 at 01:05:52AM +0100, Marek Vasut wrote:
>> The GPIO watchdog property name is 'always-running', not 'always-enabled'.
>
> The patch only adds property 'always-running'. Why is 'always-enabled'
> involved here?
Have a look at the Fixes: commit eff6b33c9ce9 below, that one removed
'always-enabled' , this one adds the correct one 'always-running'. The
naming got confused.
> Shawn
>
>> Use the correct property name and reinstate it into the DT.
>>
>> Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Fabio Estevam <festevam@denx.de>
>> Cc: Peng Fan <peng.fan@nxp.com>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> To: linux-arm-kernel@lists.infradead.org
>> ---
>> arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
>> index b337af03dacf2..5672662c62aca 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
>> @@ -88,6 +88,7 @@ watchdog {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_watchdog_gpio>;
>> compatible = "linux,wdt-gpio";
>> + always-running;
>> gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
>> hw_algo = "level";
>> /* Reset triggers in 2..3 seconds */
[...]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC
2022-12-16 0:05 [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC Marek Vasut
2023-01-01 2:37 ` Shawn Guo
@ 2023-01-09 7:19 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2023-01-09 7:19 UTC (permalink / raw)
To: Marek Vasut; +Cc: linux-arm-kernel, Fabio Estevam, Peng Fan, NXP Linux Team
On Fri, Dec 16, 2022 at 01:05:52AM +0100, Marek Vasut wrote:
> The GPIO watchdog property name is 'always-running', not 'always-enabled'.
> Use the correct property name and reinstate it into the DT.
>
> Fixes: eff6b33c9ce9 ("arm64: dts: imx8mm: Remove watchdog always-enabled property from eDM SBC")
> Signed-off-by: Marek Vasut <marex@denx.de>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-09 7:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-16 0:05 [PATCH] arm64: dts: imx8mm: Reinstate GPIO watchdog always-running property on eDM SBC Marek Vasut
2023-01-01 2:37 ` Shawn Guo
2023-01-02 23:36 ` Marek Vasut
2023-01-09 7:19 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).