linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mp: Enable spba-bus on AIPS3
@ 2022-12-18 17:05 Adam Ford
  2022-12-21 14:45 ` Marco Felsch
  2023-01-01  4:47 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Adam Ford @ 2022-12-18 17:05 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: aford, marex, Adam Ford, Rob Herring, Krzysztof Kozlowski,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel

There is an SPBA bus on AIPS3 which includes ecspi1-3,
UART1-3, and Flexcan1-2 according to the TRM.

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 2ce45e7cbbdf..9b0a47e7b8fd 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -719,121 +719,129 @@ aips3: bus@30800000 {
 			#size-cells = <1>;
 			ranges;
 
-			ecspi1: spi@30820000 {
+			spba-bus@30800000 {
+				compatible = "fsl,spba-bus", "simple-bus";
+				reg = <0x30800000 0x100000>;
 				#address-cells = <1>;
-				#size-cells = <0>;
-				compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
-				reg = <0x30820000 0x10000>;
-				interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_ECSPI1_ROOT>,
-					 <&clk IMX8MP_CLK_ECSPI1_ROOT>;
-				clock-names = "ipg", "per";
-				assigned-clock-rates = <80000000>;
-				assigned-clocks = <&clk IMX8MP_CLK_ECSPI1>;
-				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
-				dmas = <&sdma1 0 7 1>, <&sdma1 1 7 2>;
-				dma-names = "rx", "tx";
-				status = "disabled";
-			};
+				#size-cells = <1>;
+				ranges;
 
-			ecspi2: spi@30830000 {
-				#address-cells = <1>;
-				#size-cells = <0>;
-				compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
-				reg = <0x30830000 0x10000>;
-				interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_ECSPI2_ROOT>,
-					 <&clk IMX8MP_CLK_ECSPI2_ROOT>;
-				clock-names = "ipg", "per";
-				assigned-clock-rates = <80000000>;
-				assigned-clocks = <&clk IMX8MP_CLK_ECSPI2>;
-				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
-				dmas = <&sdma1 2 7 1>, <&sdma1 3 7 2>;
-				dma-names = "rx", "tx";
-				status = "disabled";
-			};
+				ecspi1: spi@30820000 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
+					reg = <0x30820000 0x10000>;
+					interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clk IMX8MP_CLK_ECSPI1_ROOT>,
+						 <&clk IMX8MP_CLK_ECSPI1_ROOT>;
+					clock-names = "ipg", "per";
+					assigned-clock-rates = <80000000>;
+					assigned-clocks = <&clk IMX8MP_CLK_ECSPI1>;
+					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+					dmas = <&sdma1 0 7 1>, <&sdma1 1 7 2>;
+					dma-names = "rx", "tx";
+					status = "disabled";
+				};
 
-			ecspi3: spi@30840000 {
-				#address-cells = <1>;
-				#size-cells = <0>;
-				compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
-				reg = <0x30840000 0x10000>;
-				interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_ECSPI3_ROOT>,
-					 <&clk IMX8MP_CLK_ECSPI3_ROOT>;
-				clock-names = "ipg", "per";
-				assigned-clock-rates = <80000000>;
-				assigned-clocks = <&clk IMX8MP_CLK_ECSPI3>;
-				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
-				dmas = <&sdma1 4 7 1>, <&sdma1 5 7 2>;
-				dma-names = "rx", "tx";
-				status = "disabled";
-			};
+				ecspi2: spi@30830000 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
+					reg = <0x30830000 0x10000>;
+					interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clk IMX8MP_CLK_ECSPI2_ROOT>,
+						 <&clk IMX8MP_CLK_ECSPI2_ROOT>;
+					clock-names = "ipg", "per";
+					assigned-clock-rates = <80000000>;
+					assigned-clocks = <&clk IMX8MP_CLK_ECSPI2>;
+					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+					dmas = <&sdma1 2 7 1>, <&sdma1 3 7 2>;
+					dma-names = "rx", "tx";
+					status = "disabled";
+				};
 
-			uart1: serial@30860000 {
-				compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
-				reg = <0x30860000 0x10000>;
-				interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_UART1_ROOT>,
-					 <&clk IMX8MP_CLK_UART1_ROOT>;
-				clock-names = "ipg", "per";
-				dmas = <&sdma1 22 4 0>, <&sdma1 23 4 0>;
-				dma-names = "rx", "tx";
-				status = "disabled";
-			};
+				ecspi3: spi@30840000 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+					compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
+					reg = <0x30840000 0x10000>;
+					interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clk IMX8MP_CLK_ECSPI3_ROOT>,
+						 <&clk IMX8MP_CLK_ECSPI3_ROOT>;
+					clock-names = "ipg", "per";
+					assigned-clock-rates = <80000000>;
+					assigned-clocks = <&clk IMX8MP_CLK_ECSPI3>;
+					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
+					dmas = <&sdma1 4 7 1>, <&sdma1 5 7 2>;
+					dma-names = "rx", "tx";
+					status = "disabled";
+				};
 
-			uart3: serial@30880000 {
-				compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
-				reg = <0x30880000 0x10000>;
-				interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_UART3_ROOT>,
-					 <&clk IMX8MP_CLK_UART3_ROOT>;
-				clock-names = "ipg", "per";
-				dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>;
-				dma-names = "rx", "tx";
-				status = "disabled";
-			};
+				uart1: serial@30860000 {
+					compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
+					reg = <0x30860000 0x10000>;
+					interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clk IMX8MP_CLK_UART1_ROOT>,
+						 <&clk IMX8MP_CLK_UART1_ROOT>;
+					clock-names = "ipg", "per";
+					dmas = <&sdma1 22 4 0>, <&sdma1 23 4 0>;
+					dma-names = "rx", "tx";
+					status = "disabled";
+				};
 
-			uart2: serial@30890000 {
-				compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
-				reg = <0x30890000 0x10000>;
-				interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_UART2_ROOT>,
-					 <&clk IMX8MP_CLK_UART2_ROOT>;
-				clock-names = "ipg", "per";
-				dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
-				dma-names = "rx", "tx";
-				status = "disabled";
-			};
+				uart3: serial@30880000 {
+					compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
+					reg = <0x30880000 0x10000>;
+					interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clk IMX8MP_CLK_UART3_ROOT>,
+						 <&clk IMX8MP_CLK_UART3_ROOT>;
+					clock-names = "ipg", "per";
+					dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>;
+					dma-names = "rx", "tx";
+					status = "disabled";
+				};
 
-			flexcan1: can@308c0000 {
-				compatible = "fsl,imx8mp-flexcan";
-				reg = <0x308c0000 0x10000>;
-				interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
-					 <&clk IMX8MP_CLK_CAN1_ROOT>;
-				clock-names = "ipg", "per";
-				assigned-clocks = <&clk IMX8MP_CLK_CAN1>;
-				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
-				assigned-clock-rates = <40000000>;
-				fsl,clk-source = /bits/ 8 <0>;
-				fsl,stop-mode = <&gpr 0x10 4>;
-				status = "disabled";
-			};
+				uart2: serial@30890000 {
+					compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
+					reg = <0x30890000 0x10000>;
+					interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clk IMX8MP_CLK_UART2_ROOT>,
+						 <&clk IMX8MP_CLK_UART2_ROOT>;
+					clock-names = "ipg", "per";
+					dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
+					dma-names = "rx", "tx";
+					status = "disabled";
+				};
 
-			flexcan2: can@308d0000 {
-				compatible = "fsl,imx8mp-flexcan";
-				reg = <0x308d0000 0x10000>;
-				interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
-					 <&clk IMX8MP_CLK_CAN2_ROOT>;
-				clock-names = "ipg", "per";
-				assigned-clocks = <&clk IMX8MP_CLK_CAN2>;
-				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
-				assigned-clock-rates = <40000000>;
-				fsl,clk-source = /bits/ 8 <0>;
-				fsl,stop-mode = <&gpr 0x10 5>;
-				status = "disabled";
+				flexcan1: can@308c0000 {
+					compatible = "fsl,imx8mp-flexcan";
+					reg = <0x308c0000 0x10000>;
+					interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
+						 <&clk IMX8MP_CLK_CAN1_ROOT>;
+					clock-names = "ipg", "per";
+					assigned-clocks = <&clk IMX8MP_CLK_CAN1>;
+					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
+					assigned-clock-rates = <40000000>;
+					fsl,clk-source = /bits/ 8 <0>;
+					fsl,stop-mode = <&gpr 0x10 4>;
+					status = "disabled";
+				};
+
+				flexcan2: can@308d0000 {
+					compatible = "fsl,imx8mp-flexcan";
+					reg = <0x308d0000 0x10000>;
+					interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
+					clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
+						 <&clk IMX8MP_CLK_CAN2_ROOT>;
+					clock-names = "ipg", "per";
+					assigned-clocks = <&clk IMX8MP_CLK_CAN2>;
+					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
+					assigned-clock-rates = <40000000>;
+					fsl,clk-source = /bits/ 8 <0>;
+					fsl,stop-mode = <&gpr 0x10 5>;
+					status = "disabled";
+				};
 			};
 
 			crypto: crypto@30900000 {
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp: Enable spba-bus on AIPS3
  2022-12-18 17:05 [PATCH] arm64: dts: imx8mp: Enable spba-bus on AIPS3 Adam Ford
@ 2022-12-21 14:45 ` Marco Felsch
  2023-01-01  4:47 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Marco Felsch @ 2022-12-21 14:45 UTC (permalink / raw)
  To: Adam Ford
  Cc: linux-arm-kernel, marex, devicetree, Fabio Estevam,
	Pengutronix Kernel Team, Sascha Hauer, aford, linux-kernel,
	Rob Herring, NXP Linux Team, Krzysztof Kozlowski, Shawn Guo

Hi Adam,

On 22-12-18, Adam Ford wrote:
> There is an SPBA bus on AIPS3 which includes ecspi1-3,
> UART1-3, and Flexcan1-2 according to the TRM.

LGTM

> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 2ce45e7cbbdf..9b0a47e7b8fd 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -719,121 +719,129 @@ aips3: bus@30800000 {
>  			#size-cells = <1>;
>  			ranges;
>  
> -			ecspi1: spi@30820000 {
> +			spba-bus@30800000 {
> +				compatible = "fsl,spba-bus", "simple-bus";
> +				reg = <0x30800000 0x100000>;
>  				#address-cells = <1>;
> -				#size-cells = <0>;
> -				compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> -				reg = <0x30820000 0x10000>;
> -				interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_ECSPI1_ROOT>,
> -					 <&clk IMX8MP_CLK_ECSPI1_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clock-rates = <80000000>;
> -				assigned-clocks = <&clk IMX8MP_CLK_ECSPI1>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> -				dmas = <&sdma1 0 7 1>, <&sdma1 1 7 2>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				#size-cells = <1>;
> +				ranges;
>  
> -			ecspi2: spi@30830000 {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -				compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> -				reg = <0x30830000 0x10000>;
> -				interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_ECSPI2_ROOT>,
> -					 <&clk IMX8MP_CLK_ECSPI2_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clock-rates = <80000000>;
> -				assigned-clocks = <&clk IMX8MP_CLK_ECSPI2>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> -				dmas = <&sdma1 2 7 1>, <&sdma1 3 7 2>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				ecspi1: spi@30820000 {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +					compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> +					reg = <0x30820000 0x10000>;
> +					interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_ECSPI1_ROOT>,
> +						 <&clk IMX8MP_CLK_ECSPI1_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clock-rates = <80000000>;
> +					assigned-clocks = <&clk IMX8MP_CLK_ECSPI1>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> +					dmas = <&sdma1 0 7 1>, <&sdma1 1 7 2>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			ecspi3: spi@30840000 {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -				compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> -				reg = <0x30840000 0x10000>;
> -				interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_ECSPI3_ROOT>,
> -					 <&clk IMX8MP_CLK_ECSPI3_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clock-rates = <80000000>;
> -				assigned-clocks = <&clk IMX8MP_CLK_ECSPI3>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> -				dmas = <&sdma1 4 7 1>, <&sdma1 5 7 2>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				ecspi2: spi@30830000 {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +					compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> +					reg = <0x30830000 0x10000>;
> +					interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_ECSPI2_ROOT>,
> +						 <&clk IMX8MP_CLK_ECSPI2_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clock-rates = <80000000>;
> +					assigned-clocks = <&clk IMX8MP_CLK_ECSPI2>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> +					dmas = <&sdma1 2 7 1>, <&sdma1 3 7 2>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			uart1: serial@30860000 {
> -				compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> -				reg = <0x30860000 0x10000>;
> -				interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_UART1_ROOT>,
> -					 <&clk IMX8MP_CLK_UART1_ROOT>;
> -				clock-names = "ipg", "per";
> -				dmas = <&sdma1 22 4 0>, <&sdma1 23 4 0>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				ecspi3: spi@30840000 {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +					compatible = "fsl,imx8mp-ecspi", "fsl,imx6ul-ecspi";
> +					reg = <0x30840000 0x10000>;
> +					interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_ECSPI3_ROOT>,
> +						 <&clk IMX8MP_CLK_ECSPI3_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clock-rates = <80000000>;
> +					assigned-clocks = <&clk IMX8MP_CLK_ECSPI3>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>;
> +					dmas = <&sdma1 4 7 1>, <&sdma1 5 7 2>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			uart3: serial@30880000 {
> -				compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> -				reg = <0x30880000 0x10000>;
> -				interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_UART3_ROOT>,
> -					 <&clk IMX8MP_CLK_UART3_ROOT>;
> -				clock-names = "ipg", "per";
> -				dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				uart1: serial@30860000 {
> +					compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> +					reg = <0x30860000 0x10000>;
> +					interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_UART1_ROOT>,
> +						 <&clk IMX8MP_CLK_UART1_ROOT>;
> +					clock-names = "ipg", "per";
> +					dmas = <&sdma1 22 4 0>, <&sdma1 23 4 0>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			uart2: serial@30890000 {
> -				compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> -				reg = <0x30890000 0x10000>;
> -				interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_UART2_ROOT>,
> -					 <&clk IMX8MP_CLK_UART2_ROOT>;
> -				clock-names = "ipg", "per";
> -				dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
> -				dma-names = "rx", "tx";
> -				status = "disabled";
> -			};
> +				uart3: serial@30880000 {
> +					compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> +					reg = <0x30880000 0x10000>;
> +					interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_UART3_ROOT>,
> +						 <&clk IMX8MP_CLK_UART3_ROOT>;
> +					clock-names = "ipg", "per";
> +					dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			flexcan1: can@308c0000 {
> -				compatible = "fsl,imx8mp-flexcan";
> -				reg = <0x308c0000 0x10000>;
> -				interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
> -					 <&clk IMX8MP_CLK_CAN1_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clocks = <&clk IMX8MP_CLK_CAN1>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
> -				assigned-clock-rates = <40000000>;
> -				fsl,clk-source = /bits/ 8 <0>;
> -				fsl,stop-mode = <&gpr 0x10 4>;
> -				status = "disabled";
> -			};
> +				uart2: serial@30890000 {
> +					compatible = "fsl,imx8mp-uart", "fsl,imx6q-uart";
> +					reg = <0x30890000 0x10000>;
> +					interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_UART2_ROOT>,
> +						 <&clk IMX8MP_CLK_UART2_ROOT>;
> +					clock-names = "ipg", "per";
> +					dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>;
> +					dma-names = "rx", "tx";
> +					status = "disabled";
> +				};
>  
> -			flexcan2: can@308d0000 {
> -				compatible = "fsl,imx8mp-flexcan";
> -				reg = <0x308d0000 0x10000>;
> -				interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
> -					 <&clk IMX8MP_CLK_CAN2_ROOT>;
> -				clock-names = "ipg", "per";
> -				assigned-clocks = <&clk IMX8MP_CLK_CAN2>;
> -				assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
> -				assigned-clock-rates = <40000000>;
> -				fsl,clk-source = /bits/ 8 <0>;
> -				fsl,stop-mode = <&gpr 0x10 5>;
> -				status = "disabled";
> +				flexcan1: can@308c0000 {
> +					compatible = "fsl,imx8mp-flexcan";
> +					reg = <0x308c0000 0x10000>;
> +					interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
> +						 <&clk IMX8MP_CLK_CAN1_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clocks = <&clk IMX8MP_CLK_CAN1>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
> +					assigned-clock-rates = <40000000>;
> +					fsl,clk-source = /bits/ 8 <0>;
> +					fsl,stop-mode = <&gpr 0x10 4>;
> +					status = "disabled";
> +				};
> +
> +				flexcan2: can@308d0000 {
> +					compatible = "fsl,imx8mp-flexcan";
> +					reg = <0x308d0000 0x10000>;
> +					interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
> +					clocks = <&clk IMX8MP_CLK_IPG_ROOT>,
> +						 <&clk IMX8MP_CLK_CAN2_ROOT>;
> +					clock-names = "ipg", "per";
> +					assigned-clocks = <&clk IMX8MP_CLK_CAN2>;
> +					assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_40M>;
> +					assigned-clock-rates = <40000000>;
> +					fsl,clk-source = /bits/ 8 <0>;
> +					fsl,stop-mode = <&gpr 0x10 5>;
> +					status = "disabled";
> +				};
>  			};
>  
>  			crypto: crypto@30900000 {
> -- 
> 2.34.1
> 
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp: Enable spba-bus on AIPS3
  2022-12-18 17:05 [PATCH] arm64: dts: imx8mp: Enable spba-bus on AIPS3 Adam Ford
  2022-12-21 14:45 ` Marco Felsch
@ 2023-01-01  4:47 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-01-01  4:47 UTC (permalink / raw)
  To: Adam Ford
  Cc: linux-arm-kernel, aford, marex, Rob Herring, Krzysztof Kozlowski,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel

On Sun, Dec 18, 2022 at 11:05:44AM -0600, Adam Ford wrote:
> There is an SPBA bus on AIPS3 which includes ecspi1-3,
> UART1-3, and Flexcan1-2 according to the TRM.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-01  4:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-18 17:05 [PATCH] arm64: dts: imx8mp: Enable spba-bus on AIPS3 Adam Ford
2022-12-21 14:45 ` Marco Felsch
2023-01-01  4:47 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).