From: MD Danish Anwar <danishanwar@ti.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: nm@ti.com, srk@ti.com, vigneshr@ti.com,
devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org,
MD Danish Anwar <danishanwar@ti.com>,
"Andrew F . Davis" <afd@ti.com>,
Roger Quadros <rogerq@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v13 4/6] remoteproc: pru: Make sysfs entries read-only for PRU client driven boots
Date: Thu, 5 Jan 2023 14:51:47 +0530 [thread overview]
Message-ID: <20230105092149.686201-5-danishanwar@ti.com> (raw)
In-Reply-To: <20230105092149.686201-1-danishanwar@ti.com>
From: Suman Anna <s-anna@ti.com>
The PRU remoteproc driver is not configured for 'auto-boot' by default,
and allows to be booted either by in-kernel PRU client drivers or by
userspace using the generic remoteproc sysfs interfaces. The sysfs
interfaces should not be permitted to change the remoteproc firmwares
or states when a PRU is being managed by an in-kernel client driver.
Use the newly introduced remoteproc generic 'sysfs_read_only' flag to
provide these restrictions by setting and clearing it appropriately
during the PRU acquire and release steps.
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
---
drivers/remoteproc/pru_rproc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index fe4ca1584e91..8e2fbe392ef3 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -223,6 +223,7 @@ struct rproc *pru_rproc_get(struct device_node *np, int index,
}
pru->client_np = np;
+ rproc->sysfs_read_only = true;
mutex_unlock(&pru->lock);
@@ -261,6 +262,7 @@ void pru_rproc_put(struct rproc *rproc)
}
pru->client_np = NULL;
+ rproc->sysfs_read_only = false;
mutex_unlock(&pru->lock);
rproc_put(rproc);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-05 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 9:21 [PATCH v13 0/6] Introduce PRU remoteproc consumer API MD Danish Anwar
2023-01-05 9:21 ` [PATCH v13 1/6] dt-bindings: remoteproc: Add PRU consumer bindings MD Danish Anwar
2023-01-05 9:21 ` [PATCH v13 2/6] remoteproc: pru: Add enum for PRU Core Identifiers MD Danish Anwar
2023-01-05 20:23 ` Mathieu Poirier
2023-01-06 12:02 ` [EXTERNAL] " Md Danish Anwar
2023-01-05 9:21 ` [PATCH v13 3/6] remoteproc: pru: Add APIs to get and put the PRU cores MD Danish Anwar
2023-01-05 9:21 ` MD Danish Anwar [this message]
2023-01-05 9:21 ` [PATCH v13 5/6] remoteproc: pru: Add pru_rproc_set_ctable() function MD Danish Anwar
2023-01-05 9:21 ` [PATCH v13 6/6] remoteproc: pru: Configure firmware based on client setup MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105092149.686201-5-danishanwar@ti.com \
--to=danishanwar@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox