From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C048C4708E for ; Thu, 5 Jan 2023 23:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r6H/LdXM/oyno77V1weBiDQdpLufAmy8isr8IdBQ188=; b=dvtvKA4cIO/b0H nAN+PVR8/Q2XyLx2yf8zxlEv4o5pwXRGibTjXswcRTlfBGwXYzkpxHU2qb+PGfkayytbpSt0qN1cn W5NwZwtNNeQPuarOWCte2xHbW2p9XdP0N+s8eG7xSOcnoBn/rNwd3bpRSgz0hk7nCzjq3bUKDTh6t 0qLbXfdoZdkdGH+noM7o3bazsc3fNLpAG+mVMz7oXtQutnMQ/XD2n9PSQSlj8ZAfbW7iF+mthGZpm Ub5jR6rytU2JGg5VqnwkuJqU9lz785OVEzWpf2lTERxkLxl2gLPI48hUiprNt7doe6EnOWY2KhfjK CBL0TpIU2vXZ5uYxRKxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDZWs-00G4cp-P0; Thu, 05 Jan 2023 23:20:11 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDWmQ-00EVoe-3M for linux-arm-kernel@lists.infradead.org; Thu, 05 Jan 2023 20:24:03 +0000 Received: by mail-pj1-x1030.google.com with SMTP id w4-20020a17090ac98400b002186f5d7a4cso3175273pjt.0 for ; Thu, 05 Jan 2023 12:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BdPQnZPsNbU7v8vdnBDPJX4Ei7uk+/hU47MzzdZv4JY=; b=ZJHtyhEbEExG2mK0lt1w8Q95zOYeqLbYfa2RGWpffEkSjaoUfhTWukEDeXUBn1RHCM fpt/aRXL7SJietjXBvp3Qdpm7J8Xd3BeZdDX7EKMJEhuic0nFlOveIf+X7mLwyIi5ep2 B60IIcWgy33ab0hKe1nIEGIRLXP/Zqq7i0auZB0hKMF0wCXyYupOmr0GorHRDLETpQcR HqnLX9VK100Ft4wEykjD/Pp8UrkpsaRHRSKc74MRDpr+YZQyvGJOlQt9zyrUyALJsT8P 1Ik0zpFAlUB6sV0TG3P5zFVUMPUKeMGHniNV98i4EHVRhgZ/dARSooUlS5xbCYRFzaIx dkgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BdPQnZPsNbU7v8vdnBDPJX4Ei7uk+/hU47MzzdZv4JY=; b=PeWOK66Ye7b8iXG5VmZT4+3XdFWjt/eNuf90+n/lgVFFaNrG9DWON8ENTjAC0JSiEq pV5n7GVCjwITegtS2n9ch29mAtCBANCS4hqC0UIjtpxglUZGP5dfwX4OkzMJSzUyWJxa wftGFWxdsiNF8FosK7eB7vSsRSREIve0arFgitTHZLnW8ze1MuloL5wqWmyFKNphYPFA x7pBw2/wP/DiOMeOIJ/YKTRs9kAVYysNq17NPr6tUC4z6HSbCRpLJ0WiSESZwVUsdyQs sE6H3LI9rIM3wVNnR9I1KExxrLngtwRzrxUu6NE06l0XjIEZTRM/zToJIbZ1MUahU/xd 49EA== X-Gm-Message-State: AFqh2kryVQVU+k77ZzUYmG+F9XqkvzyAXTA//V7wYi/8BoH23gCtSqej fKcyBLMNxHSTn2KZf73THHzlfQ== X-Google-Smtp-Source: AMrXdXsSdNJpdEDK6HJVJgTdEB6KWYZUS7shO4sAk0iXvj/JheXjC6QWpmD7mmCU+NMPyL2hCoJzYg== X-Received: by 2002:a17:902:c102:b0:192:8e05:1505 with SMTP id 2-20020a170902c10200b001928e051505mr36182840pli.31.1672950240412; Thu, 05 Jan 2023 12:24:00 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:1328:ca09:d4c2:fcbc]) by smtp.gmail.com with ESMTPSA id d12-20020a170903230c00b00187033cac81sm19030920plh.145.2023.01.05.12.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 12:23:59 -0800 (PST) Date: Thu, 5 Jan 2023 13:23:56 -0700 From: Mathieu Poirier To: MD Danish Anwar Subject: Re: [PATCH v13 2/6] remoteproc: pru: Add enum for PRU Core Identifiers. Message-ID: <20230105202356.GA2281956@p14s> References: <20230105092149.686201-1-danishanwar@ti.com> <20230105092149.686201-3-danishanwar@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230105092149.686201-3-danishanwar@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230105_122402_219954_DAE081B7 X-CRM114-Status: GOOD ( 20.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, srk@ti.com, vigneshr@ti.com, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, "Andrew F . Davis" , Roger Quadros , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 05, 2023 at 02:51:45PM +0530, MD Danish Anwar wrote: > Introducing enum pruss_pru_id for PRU Core Identifiers. > PRUSS_PRU0 indicates PRU Core 0. > PRUSS_PRU1 indicates PRU Core 1. > PRUSS_NUM_PRUS indicates the total number of PRU Cores. > > Signed-off-by: MD Danish Anwar > Reviewed-by: Roger Quadros > --- > drivers/remoteproc/pru_rproc.c | 7 ++++--- > include/linux/pruss.h | 31 +++++++++++++++++++++++++++++++ Please add this under include/linux/remoteproc/ to avoid adding an orphan file under include/linux/. Thanks, Mathieu > 2 files changed, 35 insertions(+), 3 deletions(-) > create mode 100644 include/linux/pruss.h > > diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c > index 128bf9912f2c..a1a208b31846 100644 > --- a/drivers/remoteproc/pru_rproc.c > +++ b/drivers/remoteproc/pru_rproc.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -438,7 +439,7 @@ static void *pru_d_da_to_va(struct pru_rproc *pru, u32 da, size_t len) > dram0 = pruss->mem_regions[PRUSS_MEM_DRAM0]; > dram1 = pruss->mem_regions[PRUSS_MEM_DRAM1]; > /* PRU1 has its local RAM addresses reversed */ > - if (pru->id == 1) > + if (pru->id == PRUSS_PRU1) > swap(dram0, dram1); > shrd_ram = pruss->mem_regions[PRUSS_MEM_SHRD_RAM2]; > > @@ -747,14 +748,14 @@ static int pru_rproc_set_id(struct pru_rproc *pru) > case RTU0_IRAM_ADDR_MASK: > fallthrough; > case PRU0_IRAM_ADDR_MASK: > - pru->id = 0; > + pru->id = PRUSS_PRU0; > break; > case TX_PRU1_IRAM_ADDR_MASK: > fallthrough; > case RTU1_IRAM_ADDR_MASK: > fallthrough; > case PRU1_IRAM_ADDR_MASK: > - pru->id = 1; > + pru->id = PRUSS_PRU1; > break; > default: > ret = -EINVAL; > diff --git a/include/linux/pruss.h b/include/linux/pruss.h > new file mode 100644 > index 000000000000..e94a81e97a4c > --- /dev/null > +++ b/include/linux/pruss.h > @@ -0,0 +1,31 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/** > + * PRU-ICSS Subsystem user interfaces > + * > + * Copyright (C) 2015-2022 Texas Instruments Incorporated - http://www.ti.com > + * Suman Anna > + */ > + > +#ifndef __LINUX_PRUSS_H > +#define __LINUX_PRUSS_H > + > +#include > +#include > + > +#define PRU_RPROC_DRVNAME "pru-rproc" > + > +/** > + * enum pruss_pru_id - PRU core identifiers > + * @PRUSS_PRU0: PRU Core 0. > + * @PRUSS_PRU1: PRU Core 1. > + * @PRUSS_NUM_PRUS: Total number of PRU Cores available. > + * > + */ > + > +enum pruss_pru_id { > + PRUSS_PRU0 = 0, > + PRUSS_PRU1, > + PRUSS_NUM_PRUS, > +}; > + > +#endif /* __LINUX_PRUSS_H */ > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel