From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F3D8C3DA7A for ; Thu, 5 Jan 2023 23:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tef+zQIdltXvmNoPQimGJyw0Mo+/z70bKikiHZYry5U=; b=xigvGhwUPbUD0z M3MUc7jz753XKtevrPJAICoa4YYxNGljuAP1yzZdoGKVPvpZ6ObOuC1xEi10UCHX3mVI5mOKNHq3Z lM5e7tRck/sU+YiIMriFUlikHDb5iYKw4tNmYxL08HvDPrTLWsisKdoiIts6Q9iTAlFDfQH7KyuIK 3CD/it+7bLqpQ6yk2Qs6u+pG566FaeQZHvk4atvidfdsGTg+olNUysYtiEOMJ/yW/wlzXrc5pQZK4 ZedcqTTMlPGq4htAAULiU3ko6+7jK0Ouh6mIa/VXd6CoR6+/JxWahllkKqG3Q6jT+VwKuKWN1phSS 6RQ4wm8ARgz+LF7Z8ngQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDZo8-00GDtT-Tg; Thu, 05 Jan 2023 23:38:01 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDY7c-00FHaX-IE for linux-arm-kernel@lists.infradead.org; Thu, 05 Jan 2023 21:50:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1672955400; x=1704491400; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GWLfTS968CloPMevtoM4MSviKK8lba7mNlv0zXAMW2M=; b=xOGKqDzON/tOBuBiZNIej1TspO/AY3Y3+7Xyh8Fj3Y+ZyAzSihzXK+eT B3yvEnA03vbjH1f+Q0hcmwUoZqNWtwqaKQOG6kvEmp0c7rlsFwE7IQbIZ yL2ITFET9TzMUWbF/6bE5SNT+Ezm0UQaw1VRlamdBFG3j++IA8r4pItzG g4toI+Fb86T3JAVfyK9BZxkJdfEv6WbHYHJGlhMbyBoFbEX2vNDLQGYhF OIzIREC5ROt50YHlTkU0ktPXGIlm04DM+iTvqfEwfI+A/eEsKLwwTjYEq ejTau3hkZDXqB87U9xo6h5gFjtuSZrbsk1bLjVRpWrNE9Rl2MnM4LWYXc g==; X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="194503577" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 05 Jan 2023 14:49:54 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 5 Jan 2023 14:49:53 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Thu, 5 Jan 2023 14:49:53 -0700 Date: Thu, 5 Jan 2023 22:55:12 +0100 From: Horatiu Vultur To: Michael Walle CC: , , , , , , , , , , , , Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20230105215512.uck2gy4hyd2z7hq4@soft-dev3-1> References: <20221203104348.1749811-5-horatiu.vultur@microchip.com> <20221208092511.4122746-1-michael@walle.cc> <20221208130444.xshazhpg4e2utvjs@soft-dev3-1> <20221209092904.asgka7zttvdtijub@soft-dev3-1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230105_135000_802593_E1E29467 X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 01/05/2023 16:09, Michael Walle wrote: > > Hi, Hi Michael, > > > > Also, if the answer to my question above is yes, and ptp should > > > have worked on eth0 before, this is a regression then. > > > > OK, I can see your point. > > With the following diff, you should see the same behaviour as before: > > --- > > diff --git > > a/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_impl.c > > b/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_impl.c > > index 904f5a3f636d3..538f4b76cf97a 100644 > > --- a/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_impl.c > > +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_impl.c > > @@ -91,8 +91,6 @@ lan966x_vcap_is2_get_port_keysets(struct net_device > > *dev, int lookup, > > > > /* Check if the port keyset selection is enabled */ > > val = lan_rd(lan966x, ANA_VCAP_S2_CFG(port->chip_port)); > > - if (!ANA_VCAP_S2_CFG_ENA_GET(val)) > > - return -ENOENT; > > > > /* Collect all keysets for the port in a list */ > > if (l3_proto == ETH_P_ALL) > > Any news on this? Apart from the patches which would change the > need to use some tc magic, this should be a separate fixes patch, > right? My colleague Steen, has sent a patch series here [1]. This allows to PTP rules in HW without any tc commands. [1] https://lore.kernel.org/lkml/20230105081335.1261636-1-steen.hegelund@microchip.com/T/ > > -michael -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel