From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B54BC61DB3 for ; Fri, 6 Jan 2023 19:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4UJhfAie27QzlE1ElGnJTZl17wXnkRKD4UAXEDxuH3k=; b=GyxE9rjk1AeI/R u5Do67OTEuILcMPvsEMbwWjS8xpMH15Iza2gLfbxhjc/mwpYjlihhp5i6KE0wXbmyjIl8qRnGdR5D soECiBcpTp+nwqYJyxKMCgtswbrSFi9Kl5A2TEC4LF8Z5fpErfpsv00FZM3qjzhU0GSSNbveA3Hyq VEHhzv2QNFyB0/iAIw54BpYApfdFx4eIhWoCxLBlauDmpFsVM4VZ8bGSHIU96WRsbObkjC1mKc8/Y z/Xc4vrC9oMc+dt5Zl+bpQFAQARNXPsfppn7lwThlyTibXoMfZuGNG20E3Xi8S4lJf2FAhH3oeE43 oLZWVJG/tAiOYfLtXq2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDsTq-00EbrK-Ny; Fri, 06 Jan 2023 19:34:18 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDsTl-00Eboq-3o for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 19:34:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+/GD8PRl+jyl3wTiMZAp9rcLOar4g14C13jzDgJg/Mk=; b=Y08UrcZINgykpAfN/XOYJlNenG 7iRZP0/+vD80IcmcIiFvLMVB4jecfgBFDY/9PpTb1LxhMJ4Amyrq4q9WBl/fuZO7sJmOQ7TjJaoX3 ouYW9IDjciXV0ep2Y/NHv9SzRuPYJXGCt9qRe45M87uounVerUcFM5OdjaEZkg8BXhel6ZEaeBHMB d656BJUCcEh28YYMlgr5JblevdbwE2QcYsd950FLgVccD/YezIF5hx/ArmJ4PDJLSCyRQZJyhDOg8 6hT41t0/5gHoyhzJbbTlXovPj2c1Zat7KwrYQFqO6bD6s+3yvdgZAI4nMzIPfGSWKp3V2RM8vyh5T f48T+wQA==; Received: from p200300ccff08c9001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff08:c900:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1pDsTY-0003X1-2R; Fri, 06 Jan 2023 20:34:00 +0100 Date: Fri, 6 Jan 2023 20:33:58 +0100 From: Andreas Kemnade To: Krzysztof Kozlowski Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: mmc: fsl-imx-esdhc: allow more compatible combinations Message-ID: <20230106203358.14878660@aktux> In-Reply-To: References: <20230105213856.1828360-1-andreas@kemnade.info> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_113413_342305_E1E4226D X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 6 Jan 2023 09:41:01 +0100 Krzysztof Kozlowski wrote: > On 05/01/2023 22:38, Andreas Kemnade wrote: > > Currently make dtbs_check shows lots of errors because imx*.dtsi does > > not use single compatibles but combinations of them. > > Allow all the combinations used there. > > > > Patches fixing the dtsi files according to binding documentation were > > submitted multiple times and are commonly rejected, so relax the rules. > > Example: > > https://lore.kernel.org/linux-devicetree/72e1194e10ccb4f87aed96265114f0963e805092.camel@pengutronix.de/ > > > > Reason: compatibility of new dtbs with old kernels or bootloaders. > > > > This will significantly reduce noise on make dtbs_check. > > > > Signed-off-by: Andreas Kemnade > > --- > > .../bindings/mmc/fsl-imx-esdhc.yaml | 24 +++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > index dc6256f04b42..118ebb75f136 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > @@ -37,6 +37,30 @@ properties: > > - fsl,imx8mm-usdhc > > - fsl,imxrt1050-usdhc > > - nxp,s32g2-usdhc > > You must drop the items from enum above. Binding saying: > compatible="A" > or: > compatible="A", "B" > > is not correct. Either A is or is not compatible with B. > hmm, here we have A = B + some additional features or A = B + some additional features and additional quirks required. For the latter we have e.g. A= static const struct esdhc_soc_data usdhc_imx6sx_data = { .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200 | ESDHC_FLAG_STATE_LOST_IN_LPMODE | ESDHC_FLAG_BROKEN_AUTO_CMD23, }; B= static const struct esdhc_soc_data usdhc_imx6sl_data = { .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING | ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_ERR004536 | ESDHC_FLAG_HS200 | ESDHC_FLAG_BROKEN_AUTO_CMD23, }; so there is the difference in ESDHC_FLAG_STATE_LOST_IN_LPMODE. That might make no difference in some usage scenario (e.g. some bootloader not doing any LPMODE), but I wonder why we need to *enforce* specifying such half-compatible things. Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel