From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 255B1C61DB3 for ; Sun, 8 Jan 2023 21:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GEwpi5i3+w1SbERg8FMuJ/LYIFPSZsBSY1Zy15w6q2k=; b=p5iIA1NOjcQj9U jm28t9TptGDM05vYyfMkDhqvqmHy+DVCF2iKD3rNh8ksZ0aSpBmsmU57oLPYe6YwSeTruYeYkMxCU hseTCYrnZr/KYi+8FsYXG+jpIKL9nJ0Ol0LD1CL6qfd+ln3rR2JWivAnXAylYCq5FhUTQBgpi+aRN J26qdPgtIefdW4n7WODIKQXRloQx8mBdmM4pCZgQpaNOrPf2stAN8pGEYMhX5qSR71+tNc/Cyd2yr 7jeq7crr/y6G+TUnkhScWOIH/4nQcBj4bh6U7b7fJbFqs8LK+Tbv9/psRo0tvktUWR7zAif+Cc1Ik WTBYvXKhIAnG8R65q+3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEcrf-00FmiX-Q8; Sun, 08 Jan 2023 21:05:59 +0000 Received: from mail-il1-f179.google.com ([209.85.166.179]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEcrc-00Fmgz-Ew for linux-arm-kernel@lists.infradead.org; Sun, 08 Jan 2023 21:05:58 +0000 Received: by mail-il1-f179.google.com with SMTP id h26so3989384ila.11 for ; Sun, 08 Jan 2023 13:05:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KPKQ08od6rHLoq7984ZDPiViPYt1/bkoxC1qgBWseP0=; b=sby7RoBLWWRt2jHn5tuBLlpAISfJh6hBpCJFzNZhjbOAoFzT3rOTyBcmSK+jf3twVK vAsLv2cht0Eu/PqIj4M6uMjZFJTRm62g2UtXeY+EFVZDr/aelfK2D05CWPmmu4Djp7gv XYWqkQ1kUv+p6BekeYqJy0PqCrrtLftw+oH0sunEb/B6cfs53TqwxruzXG5AL1SsAXu5 j16lPShJXIFKKqxhXfmDw6f+sVa2hr5MV2q6CrFPwDAyjtj/cT1ypVNb7sAzpbXpWzj0 eeJiJcJmWI0UWXGyBy2WVc3b88Vf6MEhwWAki4Y7REwZflu564ZhkAZ5daNEPChdNBpk uQSw== X-Gm-Message-State: AFqh2ko2+qG9XG2BNGxVhxVDqAoeBming06Qv6WNi/8ztQWoeQ6QibFh QXwODidbMv0JponNhR9B4Q== X-Google-Smtp-Source: AMrXdXucC5wdnbW/SytqqN4gbWqjLRgD4reAyzuMo8g6fP6Y3I4fXLE34jwZukSvHl4kryvCfxn2Ow== X-Received: by 2002:a05:6e02:2169:b0:303:6d1e:e5d1 with SMTP id s9-20020a056e02216900b003036d1ee5d1mr60884245ilv.6.1673211954982; Sun, 08 Jan 2023 13:05:54 -0800 (PST) Received: from robh_at_kernel.org ([2605:ef80:8069:516a:f2b0:691e:4315:7c0f]) by smtp.gmail.com with ESMTPSA id g20-20020a92c7d4000000b0030c661606eesm2259367ilk.63.2023.01.08.13.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 13:05:54 -0800 (PST) Received: (nullmailer pid 275898 invoked by uid 1000); Sun, 08 Jan 2023 21:05:51 -0000 Date: Sun, 8 Jan 2023 15:05:51 -0600 From: Rob Herring To: Jacky Bai Cc: lee@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, dmitry.torokhov@gmail.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com, festevam@gmail.com Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: Add nxp bbnsm Message-ID: <20230108210551.GA268766-robh@kernel.org> References: <20230103074742.2324924-1-ping.bai@nxp.com> <20230103074742.2324924-2-ping.bai@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230103074742.2324924-2-ping.bai@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230108_130556_518037_FC9BAD08 X-CRM114-Status: GOOD ( 23.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 03, 2023 at 03:47:39PM +0800, Jacky Bai wrote: > Add binding for NXP BBNSM(Battery-Backed Non-Secure Module). > > Signed-off-by: Jacky Bai > --- > - v2 changes: > - remove the redundant 'bindings' string > - add ref to rtc.yaml > - add start-year property > - rename 'regmap' to 'nxp,bbnsm-regmap' and add description & type define > - add header files including in the example and correct the indentation > > -v3 changes: > - remove the 'nxp,bbnsm-regmap' property, get the regmap directly from the > parent node in rtc/pwrkey driver > --- > .../devicetree/bindings/mfd/nxp,bbnsm.yaml | 99 +++++++++++++++++++ > 1 file changed, 99 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > new file mode 100644 > index 000000000000..bcd8fbc6e297 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > @@ -0,0 +1,99 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/nxp,bbnsm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP Battery-Backed Non-Secure Module > + > +maintainers: > + - Jacky Bai > + > +description: | > + NXP BBNSM serves as non-volatile logic and storage for the system. > + it Intergrates RTC & ON/OFF control. > + The RTC can retain its state and continues counting even when the > + main chip is power down. A time alarm is generated once the most > + significant 32 bits of the real-time counter match the value in the > + Time Alarm register. > + The ON/OFF logic inside the BBNSM allows for connecting directly to > + a PMIC or other voltage regulator device. both smart PMIC mode and > + Dumb PMIC mode supported. > + > +properties: > + compatible: > + items: > + - enum: > + - nxp,bbnsm Is this a standalone device or block in an SoC. In the latter case, this needs to be SoC specific. > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + rtc: > + type: object > + $ref: /schemas/rtc/rtc.yaml# > + > + properties: > + compatible: > + const: nxp,bbnsm-rtc > + > + interrupts: > + maxItems: 1 > + > + start-year: true > + > + required: > + - compatible > + - interrupts > + > + additionalProperties: false > + > + pwrkey: > + type: object > + $ref: /schemas/input/input.yaml# > + > + properties: > + compatible: > + const: nxp,bbnsm-pwrkey > + > + interrupts: > + maxItems: 1 > + > + linux,code: true > + > + required: > + - compatible > + - interrupts > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - rtc > + - pwrkey > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + bbnsm: bbnsm@44440000 { > + compatible = "nxp,bbnsm", "syscon", "simple-mfd"; > + reg = <0x44440000 0x10000>; > + > + bbnsm_rtc: rtc { > + compatible = "nxp,bbnsm-rtc"; > + interrupts = ; > + }; > + > + bbnsm_pwrkey: pwrkey { > + compatible = "nxp,bbnsm-pwrkey"; > + interrupts = ; > + linux,code = ; > + }; > + }; > -- > 2.37.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel