From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7DADC54EBC for ; Tue, 10 Jan 2023 20:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NdFytGCHtdUXEU9UM/a9wGtPMZ6ooZCx5B5MMHDKlN0=; b=CZbrGgCTkp0PQE xWdl9rPxQxGJDaeVBeHccY3ic/pKAHn1f/1R2xYFWdWi8p5zyHp9ZdGpatO1w/6W9TNUGRzdd2cNr e+OzpsM+174/8oVJyiCmtZg6atwishh1doBIfOoFPv0jEaLejxmLkhN7Rco5Zv8kgXdnWCyzL11SD 7Xx4Xwr3oeJfI1ajHGADXeGnl6lH/ypS/3J6+AvL6H1ETNvSvHLV5G0jnbN0SV8ANgmPb4/OyfnXf PbsEsbMZp/pN6haHChBmiKozHlUZNtwUD8GCFAVeOjS5cKyOTAZaXqdeN9z99vopAZfcyzPu0PlHh 1ntlosNFWDy8IPBxnumA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFLT5-008VbC-I0; Tue, 10 Jan 2023 20:43:35 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFLT0-008VaV-Fk for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 20:43:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D109B81981; Tue, 10 Jan 2023 20:43:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89A5BC433D2; Tue, 10 Jan 2023 20:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673383406; bh=W4MoENF/ZOiCtEvF2sFd7AEBeWJSmcxY8vS9xvYYyAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z0l+GfmccPc59TMwfpjWMzXm46RrWGT66OgnGrYEF1zsssiS20y8X1VXaXzfn2/t/ Fyj9pcyU3crMJbdwuTJOyQsdIYaT+GJPlPufw4AKNfdgG5o+ZErWBrEDsJ05He2epL 6VOw34eBe+4QCrvucf3Gl6tYmebkoWDycRgntnZXRiDiaRhbFrXsDaOgFMJv974Q54 J66tAbM0lb38UVPoCI/XNozRfBGEziaiBuaP4ei4YD0Mmu2bVn2HPlth28tvijc5a7 dJsQtLMBtfOWv/VibgLhTowXA1hcU52p/Irg7bCEwDpdxdNFtI1A/hFfAmvMr6NMpY 9ZMEJeaCnAJJQ== Date: Tue, 10 Jan 2023 20:43:20 +0000 From: Will Deacon To: Peter Zijlstra Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, mhiramat@kernel.org, ndesaulniers@google.com, ojeda@kernel.org, rafael.j.wysocki@intel.com, revest@chromium.org, robert.moore@intel.com, rostedt@goodmis.org Subject: Re: [PATCH 3/8] arm64: Extend support for CONFIG_FUNCTION_ALIGNMENT Message-ID: <20230110204320.GA9739@willie-the-truck> References: <20230109135828.879136-1-mark.rutland@arm.com> <20230109135828.879136-4-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_124330_705036_572EDAB3 X-CRM114-Status: GOOD ( 16.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 10, 2023 at 09:35:18PM +0100, Peter Zijlstra wrote: > On Mon, Jan 09, 2023 at 01:58:23PM +0000, Mark Rutland wrote: > > > diff --git a/arch/arm64/include/asm/linkage.h b/arch/arm64/include/asm/linkage.h > > index 1436fa1cde24d..df18a3446ce82 100644 > > --- a/arch/arm64/include/asm/linkage.h > > +++ b/arch/arm64/include/asm/linkage.h > > @@ -5,8 +5,14 @@ > > #include > > #endif > > > > -#define __ALIGN .align 2 > > -#define __ALIGN_STR ".align 2" > > +#if CONFIG_FUNCTION_ALIGNMENT > 0 > > +#define ARM64_FUNCTION_ALIGNMENT CONFIG_FUNCTION_ALIGNMENT > > +#else > > +#define ARM64_FUNCTION_ALIGNMENT 4 > > +#endif > > + > > +#define __ALIGN .balign ARM64_FUNCTION_ALIGNMENT > > +#define __ALIGN_STR ".balign " #ARM64_FUNCTION_ALIGNMENT > > Isn't that much the same as having ARM64 select FUNCTION_ALIGNMENT_4B > and simply removing all these lines and relying on the default > behaviour? There's a proposal (with some rough performance claims) to select FUNCTION_ALIGNMENT_16B over at: https://lore.kernel.org/r/20221208053649.540891-1-almasrymina@google.com so we could just go with that? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel