From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D23DEC5479D for ; Wed, 11 Jan 2023 04:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yfdnIfNHhG++RS7Dex4bATGwXDT3Qu5Qw3j3jhA5e5I=; b=mmZVm3aL+bFOVU +IInUNN+roO/tCE7TyVP2pKVn7SEkUCLsOEDD4YtE8mlXq7Y7CSBbeLjk+hCzKr6Cjt9+sRfULk+/ d35V7ILAITvBO4DUoPsurZn0Sp4KYdQ+RHB4C+HyJs9v0BtixZMHGFOOdpJC7sSEsRB1D+Mfzz6YL LUHVxlwBO94MrTyTDUGrC+wgtQPufXCpm4dqfh7ALEcfICjzkZMB8jjJ3W9MewUnjMDKzGB0DN+Qp 68QcQCOkGfTf1G7xtvx4ydncq5DE2xF+TR58kP84bbIfDZjnq3hu00jYUm9c0oQJ9SZklp4UOkB0Y uQZ9XulYcV1oszq3L6Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFT4W-009afn-W6; Wed, 11 Jan 2023 04:50:45 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFT4P-009af8-EI; Wed, 11 Jan 2023 04:50:38 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 53F5368BEB; Wed, 11 Jan 2023 05:50:32 +0100 (CET) Date: Wed, 11 Jan 2023 05:50:32 +0100 From: Christoph Hellwig To: Hector Martin Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Eric Curtin , Janne Grunau , Sven Peter , Alyssa Rosenzweig , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] nvme: Handle shut down controllers during initialization Message-ID: <20230111045032.GA15520@lst.de> References: <20230111043614.27087-1-marcan@marcan.st> <20230111043614.27087-3-marcan@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230111043614.27087-3-marcan@marcan.st> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_205037_644375_021663B8 X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 11, 2023 at 01:36:14PM +0900, Hector Martin wrote: > According to the spec, controllers need an explicit reset to become > active again after a controller shutdown. Check for this state in > nvme_enable_ctrl and issue an explicit disable if required, which will > trigger the required reset. I don't think this belongs into nvme_enable_ctrl. It seems like nvme-apple is missing the equivalent to the nvme_disable_ctrl call in nvme_pci_configure_admin_queue, though. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel