From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F84BC5479D for ; Wed, 11 Jan 2023 04:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/aG3hDnCxmXWxyUV5DwAm2uSl8QHFPg04zvOZZC7vu4=; b=OZyIIi9HyLRm7v uJYzVJi3HqmHuXhiqOCMTQfsnKiOcrEVoSyqRGTkZAh18sSgocpKUf4tytAD2wiIeq9xaLlgHjbAn Y1DN80KHU94EUiU6PAPqJIEvvLE3ibw5g7MHndLq17Wbo8WixthVBD/A4Si2hVnEsDvTBnk1m9mXw 31U9vT94AFi5ve1rZpvVCt0Bc3s7qglkEhjPtCY227rsyrGC+slYNoVaX2RydVdPh8/ZO7hJ4ekKK YYGmTnaC1AH+AOFZ5pGmYuTufs6f34lBR88O1YQwDIgmtBHgefIkrrDN/B7IboU36Yh7QQbVd1pq7 x0pSIboHOuo4N7hXwnew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFT7q-009bAZ-FQ; Wed, 11 Jan 2023 04:54:10 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFT7m-009b9V-QL; Wed, 11 Jan 2023 04:54:08 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2A92C68BEB; Wed, 11 Jan 2023 05:54:03 +0100 (CET) Date: Wed, 11 Jan 2023 05:54:02 +0100 From: Christoph Hellwig To: Hector Martin Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Eric Curtin , Janne Grunau , Sven Peter , Alyssa Rosenzweig , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] nvme-apple: Do not try to shut down the controller twice Message-ID: <20230111045402.GB15520@lst.de> References: <20230111043614.27087-1-marcan@marcan.st> <20230111043614.27087-2-marcan@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230111043614.27087-2-marcan@marcan.st> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_205407_012454_6DF0F9A6 X-CRM114-Status: GOOD ( 15.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 11, 2023 at 01:36:13PM +0900, Hector Martin wrote: > The blamed commit stopped explicitly disabling the controller when we do > a controlled shutdown, but apple_nvme_reset_work was only checking for > the disable bit before deciding to issue another disable. Check for the > shutdown state too, to avoid breakage. > > This issue does not affect nvme-pci, since it only issues controller > shutdowns when the system is actually shutting down anyway. There's a few other places where nvme-pci does a shutdown like probe/reset failure and most notably and mostly notably various power management scenarios. What path is causing a problem here for nvme-apple? I fear we're missing some highler level check here and getting further out of sync. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel