Re: [PATCH v7 net-next 00/10] dt-binding preparation for ocelot switches

Colin Foster
2023-01-16T17:48:40Z

I saw on Patchwork I'd missed Krzysztof's CC. Apologies - I missed it
in a copy-paste error.

On Thu, Jan 12, 2023 at 07:56:03AM -1000, Colin Foster wrote:
> Ocelot switches have the abilitiy to be used internally via
> memory-mapped IO or externally via SPI or PCIe. This brings up issues
> for documentation, where the same chip might be accessed internally in a
> switchdev manner, or externally in a DSA configuration. This patch set
> is perparation to bring DSA functionality to the VSC7512, utilizing as
> much as possible with an almost identical VSC7514 chip.
>
> This patch set changed quite a bit from v2, so I'll omit the background
> of how those sets came to be. Rob offered a lot of very useful guidance.
> My thanks.
>
> At the end of the day, with this patch set, there should be a framework
> to document Ocelot switches (and any switch) in scenarios where they can
> be controlled internally (ethernet-switch) or externally (dsa-switch).
>
> ---
>
> v6 -> v7
> * Add Reviewed / Acked on patch 1
> * Clean up descriptions on Ethernet / DSA switch port bindings
>
> v5 -> v6
> * Rebase so it applies to net-next cleanly.
> * No other changes - during the last submission round I said I'd
> submit v6 with a change to move $dsa-port.yaml to outside the allOf
> list. In retrospect that wasn't the right thing to do, because later
> in the patch series the $dsa-port.yaml is removed outright. So I
> believe the submission in v5 to keep "type: object" was correct.
>
> v4 -> v5
> * Sync DSA maintainers with MAINTAINERS file (new patch 1)
> * Undo move of port description of mediatek,mt7530.yaml (patch 4)
> * Move removal of "^(ethernet-)?switch(@.*)?$" in dsa.yaml from patch 4
> to patch 8
> * Add more consistent capitalization in title lines and better Ethernet
> switch port description. (patch 8)
>
> v3 -> v4
> * Renamed "base" to "ethernet-ports" to avoid confusion with the concept
> of a base class.
> * Squash ("dt-bindings: net: dsa: mediatek,mt7530: fix port description location")
> patch into ("dt-bindings: net: dsa: utilize base definitions for standard dsa
> switches")
> * Corrections to fix confusion about additonalProperties vs unevaluatedProperties.
> See specific patches for details.
>
> v2 -> v3
> * Restructured everything to use a "base" iref for devices that don't
> have additional properties, and simply a "ref" for devices that do.
> * New patches to fix up brcm,sf2, qca8k, and mt7530
> * Fix unevaluatedProperties errors from previous sets (see specific
> patches for more detail)
> * Removed redundant "Device Tree Binding" from titles, where applicable.
>
> v1 -> v2
> * Two MFD patches were brought into the MFD tree, so are dropped
> * Add first patch 1/6 to allow DSA devices to add ports and port
> properties
> * Test qca8k against new dt-bindings and fix warnings. (patch 2/6)
> * Add tags (patch 3/6)
> * Fix vsc7514 refs and properties
>
> ---
>
> Colin Foster (10):
> dt-bindings: dsa: sync with maintainers
> dt-bindings: net: dsa: sf2: fix brcm,use-bcm-hdr documentation
> dt-bindings: net: dsa: qca8k: remove address-cells and size-cells from
> switch node
> dt-bindings: net: dsa: utilize base definitions for standard dsa
> switches
> dt-bindings: net: dsa: allow additional ethernet-port properties
> dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml
> dt-bindings: net: dsa: mediatek,mt7530: remove unnecessary dsa-port
> reference
> dt-bindings: net: add generic ethernet-switch
> dt-bindings: net: add generic ethernet-switch-port binding
> dt-bindings: net: mscc,vsc7514-switch: utilize generic
> ethernet-switch.yaml
>
> .../bindings/net/dsa/arrow,xrs700x.yaml | 2 +-
> .../devicetree/bindings/net/dsa/brcm,b53.yaml | 2 +-
> .../devicetree/bindings/net/dsa/brcm,sf2.yaml | 15 +++--
> .../devicetree/bindings/net/dsa/dsa-port.yaml | 30 ++-------
> .../devicetree/bindings/net/dsa/dsa.yaml | 49 +++++++--------
> .../net/dsa/hirschmann,hellcreek.yaml | 2 +-
> .../bindings/net/dsa/mediatek,mt7530.yaml | 6 +-
> .../bindings/net/dsa/microchip,ksz.yaml | 2 +-
> .../bindings/net/dsa/microchip,lan937x.yaml | 2 +-
> .../bindings/net/dsa/mscc,ocelot.yaml | 2 +-
> .../bindings/net/dsa/nxp,sja1105.yaml | 2 +-
> .../devicetree/bindings/net/dsa/qca8k.yaml | 14 +----
> .../devicetree/bindings/net/dsa/realtek.yaml | 2 +-
> .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 2 +-
> .../bindings/net/ethernet-switch-port.yaml | 26 ++++++++
> .../bindings/net/ethernet-switch.yaml | 62 +++++++++++++++++++
> .../bindings/net/mscc,vsc7514-switch.yaml | 31 +---------
> MAINTAINERS | 2 +
> 18 files changed, 145 insertions(+), 108 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/ethernet-switch-port.yaml
> create mode 100644 Documentation/devicetree/bindings/net/ethernet-switch.yaml
>
> --
> 2.25.1
>