* [PATCH] crypto: atmel-i2c - avoid defines prefixed with CONFIG
@ 2023-01-13 7:47 Lukas Bulwahn
2023-01-20 10:35 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2023-01-13 7:47 UTC (permalink / raw)
To: Herbert Xu, David S . Miller, linux-crypto
Cc: Alexandre Belloni, kernel-janitors, linux-kernel, Lukas Bulwahn,
Claudiu Beznea, linux-arm-kernel
Defines prefixed with "CONFIG" should be limited to proper Kconfig options,
that are introduced in a Kconfig file.
Here, a definition for the driver's configuration zone is named
CONFIG_ZONE. Rename this local definition to CONFIGURATION_ZONE to avoid
defines prefixed with "CONFIG".
No functional change.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Herbert, David, please pick this clean-up work into your crypto tree. Thanks.
drivers/crypto/atmel-i2c.c | 2 +-
drivers/crypto/atmel-i2c.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
index 55bff1e13142..66e27f71e37e 100644
--- a/drivers/crypto/atmel-i2c.c
+++ b/drivers/crypto/atmel-i2c.c
@@ -59,7 +59,7 @@ void atmel_i2c_init_read_cmd(struct atmel_i2c_cmd *cmd)
* Read the word from Configuration zone that contains the lock bytes
* (UserExtra, Selector, LockValue, LockConfig).
*/
- cmd->param1 = CONFIG_ZONE;
+ cmd->param1 = CONFIGURATION_ZONE;
cmd->param2 = cpu_to_le16(DEVICE_LOCK_ADDR);
cmd->count = READ_COUNT;
diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h
index 35f7857a7f7c..c1fdc04eac07 100644
--- a/drivers/crypto/atmel-i2c.h
+++ b/drivers/crypto/atmel-i2c.h
@@ -63,7 +63,7 @@ struct atmel_i2c_cmd {
#define STATUS_WAKE_SUCCESSFUL 0x11
/* Definitions for eeprom organization */
-#define CONFIG_ZONE 0
+#define CONFIGURATION_ZONE 0
/* Definitions for Indexes common to all commands */
#define RSP_DATA_IDX 1 /* buffer index of data in response */
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: atmel-i2c - avoid defines prefixed with CONFIG
2023-01-13 7:47 [PATCH] crypto: atmel-i2c - avoid defines prefixed with CONFIG Lukas Bulwahn
@ 2023-01-20 10:35 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2023-01-20 10:35 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Alexandre Belloni, linux-kernel, kernel-janitors,
David S . Miller, linux-crypto, Claudiu Beznea, linux-arm-kernel
On Fri, Jan 13, 2023 at 08:47:15AM +0100, Lukas Bulwahn wrote:
> Defines prefixed with "CONFIG" should be limited to proper Kconfig options,
> that are introduced in a Kconfig file.
>
> Here, a definition for the driver's configuration zone is named
> CONFIG_ZONE. Rename this local definition to CONFIGURATION_ZONE to avoid
> defines prefixed with "CONFIG".
>
> No functional change.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Herbert, David, please pick this clean-up work into your crypto tree. Thanks.
>
> drivers/crypto/atmel-i2c.c | 2 +-
> drivers/crypto/atmel-i2c.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-20 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-13 7:47 [PATCH] crypto: atmel-i2c - avoid defines prefixed with CONFIG Lukas Bulwahn
2023-01-20 10:35 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).