From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBC6DC3DA78 for ; Fri, 13 Jan 2023 21:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SbwJlRdZsALBSceNSYyvE6Kyv67vAtXPzu0NRQF8mig=; b=S1hG0k5m8Rx75T FYRGG3lvATZMuU+a4jpnnHJSFnfyl+qbRo6tTTa3oeVxQ5/iNc55VyA0allDcx1XqxWw4fKcly1dd y7d5mvykN9EHmQsF7Q6rq+VYpATGq/YnPoq3zRCPbsyTCsFbmJ2nkUcgpFdLZPISHs2bY2UFLqt1j jIDGAdM4/JuSMrnwgQ3QZpEhT4hRd0wlzMd1uPj8jjw96A4HafJnTBwk5j/SGXR63Pvr/7Rtc3SZB frjWFePsD3igJdWkArjSL+gdjvLno9GsIEEqd3R7jZGczoNHNwMwusXWGb3SAav/AQAfy1AtcLvC8 0w/3gYFTO0SEdHvrjsxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGS07-004f17-F4; Fri, 13 Jan 2023 21:54:15 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGRza-004epa-HL; Fri, 13 Jan 2023 21:53:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673646822; x=1705182822; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Y3oi7Gj2ErV8+ybgUGSfWPirQT8+KB+Vm+W6w2+sHKU=; b=SINzGWmzct5utKR8N8x4o7MXiCI8kO4Lq+1ZR+UU9SOIctp0OoY+We95 ZC/O3KuT5BVwvOUyaTaBV7JwljtU10zkXvuWso1ox+QDbDRVMVyDNziW+ ZxX+vPHHVn3xU32ls6bhdvIQmm55CYekndOsrnwi4ySEGnp5bd7U5B2UM NcvUINssmbtnA4lLyiAKG5dtSDg8+cQaSwWVkgSlQxhqIluyk9IAzeBUT r/aACOw5v4bZcHr+hb5e5LyUtMVdDlI4CbLW8PF3I0svH4DE3CDuScW5o b71FtJOeTPqEaKJQQtflX69IEY5PiYEZwFIcXaAPfTl/5SVIcQAjSpgjm A==; X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="351343148" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="351343148" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 13:53:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="766170867" X-IronPort-AV: E=Sophos;i="5.97,215,1669104000"; d="scan'208";a="766170867" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 13 Jan 2023 13:53:22 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 658C292; Fri, 13 Jan 2023 23:53:56 +0200 (EET) From: Andy Shevchenko To: Bartosz Golaszewski , Dmitry Torokhov , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Stefan Wahren Subject: [PATCH v3 1/4] gpiolib: Check "gpio-ranges" before calling ->add_pin_ranges() Date: Fri, 13 Jan 2023 23:53:49 +0200 Message-Id: <20230113215352.44272-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230113215352.44272-1-andriy.shevchenko@linux.intel.com> References: <20230113215352.44272-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230113_135342_609723_BEB2C560 X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The ->add_pin_ranges() is supposed to be called for the backward compatiblity on Device Tree platforms or non-DT ones. Ensure that by checking presense of the "gpio-ranges" property. This allows to clean up a few existing drivers to avoid duplication of the check. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpiolib.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 16858ef4dac1..49cfcc7510e1 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -533,6 +533,14 @@ static void gpiochip_free_valid_mask(struct gpio_chip *gc) static int gpiochip_add_pin_ranges(struct gpio_chip *gc) { + /* + * Device Tree platforms are supposed to use "gpio-ranges" + * property. This check ensures that the ->add_pin_ranges() + * won't be called for them. + */ + if (device_property_present(&gc->gpiodev->dev, "gpio-ranges")) + return 0; + if (gc->add_pin_ranges) return gc->add_pin_ranges(gc); -- 2.39.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel